Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1989973: Fix Azure typo #5144

Merged
merged 1 commit into from
Aug 12, 2021
Merged

Bug 1989973: Fix Azure typo #5144

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 5 additions & 5 deletions data/data/install.openshift.io_installconfigs.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1258,11 +1258,11 @@ spec:
description: ResourceGroupName is the name of an already existing
resource group where the cluster should be installed. This resource
group should only be used for this specific cluster and the
cluster components will assume assume ownership of all resources
in the resource group. Destroying the cluster using installer
will delete this resource group. This resource group must be
empty with no other resources when trying to use it for creating
a cluster. If empty, a new resource group will created for the
cluster components will assume ownership of all resources in
the resource group. Destroying the cluster using installer will
delete this resource group. This resource group must be empty
with no other resources when trying to use it for creating a
cluster. If empty, a new resource group will created for the
cluster.
type: string
virtualNetwork:
Expand Down
2 changes: 1 addition & 1 deletion docs/user/azure/customization.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ The following options are available when using Azure:

## Installing to Existing Resource Group

The installer can use an existing resource group when provisioning an OpenShift cluster. This resource group should only be used for this specific cluster and the cluster components will assume assume ownership of all resources in the resource group. Destroying the cluster using installer will delete this resource group. This resource group must be empty with no other resources when trying to use it for creating a cluster.
The installer can use an existing resource group when provisioning an OpenShift cluster. This resource group should only be used for this specific cluster and the cluster components will assume ownership of all resources in the resource group. Destroying the cluster using installer will delete this resource group. This resource group must be empty with no other resources when trying to use it for creating a cluster.

If you're limiting the installer's Service Principal scope to the Resource Group defined with `resourceGroupName`, you will also need to ensure proper permissions for any other resource used by the installer in your environment such as Public DNS Zone, VNet, etc.

Expand Down
2 changes: 1 addition & 1 deletion pkg/explain/printer_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@ func Test_PrintFields(t *testing.T) {
Region specifies the Azure region where the cluster will be created.

resourceGroupName <string>
ResourceGroupName is the name of an already existing resource group where the cluster should be installed. This resource group should only be used for this specific cluster and the cluster components will assume assume ownership of all resources in the resource group. Destroying the cluster using installer will delete this resource group. This resource group must be empty with no other resources when trying to use it for creating a cluster. If empty, a new resource group will created for the cluster.
ResourceGroupName is the name of an already existing resource group where the cluster should be installed. This resource group should only be used for this specific cluster and the cluster components will assume ownership of all resources in the resource group. Destroying the cluster using installer will delete this resource group. This resource group must be empty with no other resources when trying to use it for creating a cluster. If empty, a new resource group will created for the cluster.

virtualNetwork <string>
VirtualNetwork specifies the name of an existing VNet for the installer to use`,
Expand Down
2 changes: 1 addition & 1 deletion pkg/types/azure/platform.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ type Platform struct {
OutboundType OutboundType `json:"outboundType"`

// ResourceGroupName is the name of an already existing resource group where the cluster should be installed.
// This resource group should only be used for this specific cluster and the cluster components will assume assume
// This resource group should only be used for this specific cluster and the cluster components will assume
// ownership of all resources in the resource group. Destroying the cluster using installer will delete this
// resource group.
// This resource group must be empty with no other resources when trying to use it for creating a cluster.
Expand Down