Bug 1976016: Display proper error message on failure to delete #5157
Conversation
If there are other resources in the resource group that are in use by resources in other groups then the deletion will be blocked. The error message displayed is not user friendly and hence adding a check to see if the error code returned by azure autorest is 409, which is ResourceGroupDeletionBlocked, and display a proper message to the user.
openshift-ci
bot
added
the
bugzilla/severity-medium
|
@rna-afk: This pull request references Bugzilla bug 1976016, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Bugzilla (tsze@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
bugzilla/valid-bug
|
/test e2e-azure |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: patrickdillon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest |
|
@rna-afk: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@rna-afk: All pull requests linked via external trackers have merged: Bugzilla bug 1976016 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
If there are other resources in the resource group that are in use
by resources in other groups then the deletion will be blocked.
The error message displayed is not user friendly and hence adding
a check to see if the error code returned by azure autorest is
409, which is ResourceGroupDeletionBlocked, and display a proper
message to the user.