Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2004236: Document how to enable Octavia Day 2 #5161

Merged

Conversation

iamemilio
Copy link

Documentation to describe the steps to enable octavia as a day 2
operation in a cluster.

/hold
/cc @dulek

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 19, 2021

@iamemilio: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Document how to enable Octavia Day 2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from dulek August 19, 2021 18:23
@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 19, 2021
docs/user/openstack/README.md Outdated Show resolved Hide resolved
docs/user/openstack/README.md Outdated Show resolved Hide resolved
docs/user/openstack/README.md Outdated Show resolved Hide resolved
docs/user/openstack/README.md Outdated Show resolved Hide resolved
@iamemilio iamemilio force-pushed the octavia_support branch 2 times, most recently from 37c3df6 to 7b5dec2 Compare August 23, 2021 13:34
@iamemilio
Copy link
Author

cc @mandre

@iamemilio
Copy link
Author

/assign @mandre
/assign @dulek

@iamemilio
Copy link
Author

/assign @MaysaMacedo

docs/user/openstack/README.md Outdated Show resolved Hide resolved
@iamemilio
Copy link
Author

cc @maxwelldb how does this look?

docs/user/openstack/README.md Outdated Show resolved Hide resolved
docs/user/openstack/README.md Show resolved Hide resolved
Copy link
Contributor

@maxwelldb maxwelldb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lookin' pretty good. Made a few comments and suggestions.

docs/user/openstack/README.md Outdated Show resolved Hide resolved
docs/user/openstack/README.md Outdated Show resolved Hide resolved
docs/user/openstack/README.md Outdated Show resolved Hide resolved
docs/user/openstack/README.md Outdated Show resolved Hide resolved
docs/user/openstack/README.md Outdated Show resolved Hide resolved
docs/user/openstack/README.md Outdated Show resolved Hide resolved
docs/user/openstack/README.md Outdated Show resolved Hide resolved
docs/user/openstack/README.md Outdated Show resolved Hide resolved
docs/user/openstack/README.md Outdated Show resolved Hide resolved
docs/user/openstack/README.md Outdated Show resolved Hide resolved
@iamemilio
Copy link
Author

Updated, thanks all for the reviews :)


As a day 2 operation, you can create load balancer service types and ingress controllers that have load balancers as backends by using octavia. However, there are a few known issues to be aware of:
* Only TCP traffic is supported.
* The floating IP addresses that are attached to your Octavia load balancers are not deleted when you delete your cluster.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we add a link to a BZ tracking this feature, so 1) users can follow the feature and 2) we have a BZ in our backlog and solve it one day :)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Talked this over with Martin, I am not going to track this with a BZ because we can never backport support for this. It would be considered a feature backport. We will just document it here and downstream.

Copy link
Member

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. How do you plan to merge this? We'll need to reference a BZ, where the parent is validated, if we want to merge in release-4.8.

@iamemilio iamemilio changed the title Document how to enable Octavia Day 2 Bug 2004236: Document how to enable Octavia Day 2 Sep 14, 2021
@openshift-ci openshift-ci bot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Sep 14, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 14, 2021

@iamemilio: This pull request references Bugzilla bug 2004236, which is invalid:

  • expected the bug to target the "4.8.z" release, but it targets "---" instead
  • expected dependent Bugzilla bug 2004235 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is NEW instead
  • expected dependent Bugzilla bug 2004235 to target a release in 4.9.0, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2004236: Document how to enable Octavia Day 2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Sep 14, 2021
@mandre
Copy link
Member

mandre commented Sep 15, 2021

/bugzilla refresh
/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 15, 2021

@mandre: This pull request references Bugzilla bug 2004236, which is invalid:

  • expected dependent Bugzilla bug 2004235 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is NEW instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh
/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mandre
Copy link
Member

mandre commented Sep 15, 2021

/bugzilla refresh

@openshift-ci openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Sep 15, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 15, 2021

@mandre: This pull request references Bugzilla bug 2004236, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.z) matches configured target release for branch (4.8.z)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 2004235 is in the state CLOSED (CURRENTRELEASE), which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 2004235 targets the "4.9.0" release, which is one of the valid target releases: 4.9.0
  • bug has dependents

Requesting review from QA contact:
/cc @eurijon

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from eurijon September 15, 2021 10:31
Copy link
Member

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 15, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 15, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mandre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 15, 2021
@iamemilio
Copy link
Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 16, 2021
@hardys
Copy link
Contributor

hardys commented Sep 16, 2021

[patch-manager] Can someone help me understand the dependency chain here please? https://bugzilla.redhat.com/show_bug.cgi?id=2004236 depends on https://bugzilla.redhat.com/show_bug.cgi?id=2004235 which links to #5090 but AFAICS this isn't a backport of that patch.

@iamemilio
Copy link
Author

iamemilio commented Sep 16, 2021

sorry, I removed that dependency. We closed the 4.9 bz, and this is not a backport.

@hardys
Copy link
Contributor

hardys commented Sep 17, 2021

sorry, I removed that dependency. We closed the 4.9 bz, and this is not a backport.

[patch-manager] Thanks @iamemilio - so from what I can understand the situation is:

  • Code changes landed in 4.9 to make this configuration easier so the process/docs are different
  • This documents a 4.8 only interim method, thus it's not a backport of the 4.9 patch

I just wanted to understand the impact if users start doing this, e.g can they cleanly upgrade from this 4.8 only method to the new-for-4.9 method, and is that tested anywhere?

Not trying to be too pedantic here, I do realize it's just a docs change (and that $customers will likely follow downstream docs), but I wanted to ensure we fully understand the potential upgrade impact before merging, thanks for any further info you can provide! :)

@iamemilio
Copy link
Author

yeah, so actually, what we are having users manually do in 4.8 is exactly what we automated in 4.9. In order to use these fetaures in a 4.9 cluster, we would actually require users to follow this documentation if they were upgrading from 4.8.

@iamemilio
Copy link
Author

cc @mandre for a fact check, just in case we did some fancy upgrade automation I dont know about

@mandre
Copy link
Member

mandre commented Sep 22, 2021

yeah, so actually, what we are having users manually do in 4.8 is exactly what we automated in 4.9. In order to use these fetaures in a 4.9 cluster, we would actually require users to follow this documentation if they were upgrading from 4.8.
cc @mandre for a fact check, just in case we did some fancy upgrade automation I dont know about

This is correct, nothing fancy here, just instruction on how to edit the cloud provider configuration. It should have no impact on upgrades.

@dhellmann dhellmann added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Sep 23, 2021
@dhellmann
Copy link
Contributor

[patch-manager] 🚀 Approved for z-stream by score: 0.50

picked

@openshift-merge-robot openshift-merge-robot merged commit 3f78c07 into openshift:release-4.8 Sep 23, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 23, 2021

@iamemilio: All pull requests linked via external trackers have merged:

Bugzilla bug 2004236 has been moved to the MODIFIED state.

In response to this:

Bug 2004236: Document how to enable Octavia Day 2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants