New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 2004236: Document how to enable Octavia Day 2 #5161
Bug 2004236: Document how to enable Octavia Day 2 #5161
Conversation
@iamemilio: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
37c3df6
to
7b5dec2
Compare
cc @mandre |
/assign @MaysaMacedo |
7b5dec2
to
1511ac6
Compare
1511ac6
to
76412b4
Compare
cc @maxwelldb how does this look? |
76412b4
to
078f545
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lookin' pretty good. Made a few comments and suggestions.
078f545
to
6f4fb85
Compare
Updated, thanks all for the reviews :) |
docs/user/openstack/README.md
Outdated
|
||
As a day 2 operation, you can create load balancer service types and ingress controllers that have load balancers as backends by using octavia. However, there are a few known issues to be aware of: | ||
* Only TCP traffic is supported. | ||
* The floating IP addresses that are attached to your Octavia load balancers are not deleted when you delete your cluster. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could we add a link to a BZ tracking this feature, so 1) users can follow the feature and 2) we have a BZ in our backlog and solve it one day :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Talked this over with Martin, I am not going to track this with a BZ because we can never backport support for this. It would be considered a feature backport. We will just document it here and downstream.
6f4fb85
to
47e5ece
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. How do you plan to merge this? We'll need to reference a BZ, where the parent is validated, if we want to merge in release-4.8.
47e5ece
to
29b383e
Compare
@iamemilio: This pull request references Bugzilla bug 2004236, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh |
@mandre: This pull request references Bugzilla bug 2004236, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh |
@mandre: This pull request references Bugzilla bug 2004236, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 6 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mandre The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
[patch-manager] Can someone help me understand the dependency chain here please? https://bugzilla.redhat.com/show_bug.cgi?id=2004236 depends on https://bugzilla.redhat.com/show_bug.cgi?id=2004235 which links to #5090 but AFAICS this isn't a backport of that patch. |
sorry, I removed that dependency. We closed the 4.9 bz, and this is not a backport. |
[patch-manager] Thanks @iamemilio - so from what I can understand the situation is:
I just wanted to understand the impact if users start doing this, e.g can they cleanly upgrade from this 4.8 only method to the new-for-4.9 method, and is that tested anywhere? Not trying to be too pedantic here, I do realize it's just a docs change (and that $customers will likely follow downstream docs), but I wanted to ensure we fully understand the potential upgrade impact before merging, thanks for any further info you can provide! :) |
yeah, so actually, what we are having users manually do in 4.8 is exactly what we automated in 4.9. In order to use these fetaures in a 4.9 cluster, we would actually require users to follow this documentation if they were upgrading from 4.8. |
cc @mandre for a fact check, just in case we did some fancy upgrade automation I dont know about |
This is correct, nothing fancy here, just instruction on how to edit the cloud provider configuration. It should have no impact on upgrades. |
[patch-manager] 🚀 Approved for z-stream by score: 0.50 picked |
@iamemilio: All pull requests linked via external trackers have merged: Bugzilla bug 2004236 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Documentation to describe the steps to enable octavia as a day 2
operation in a cluster.
/hold
/cc @dulek