Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ovirt: update of upi playbook files #5222

Merged
merged 1 commit into from Oct 12, 2021
Merged

ovirt: update of upi playbook files #5222

merged 1 commit into from Oct 12, 2021

Conversation

santos1709
Copy link

guaranteed memory added, ovirt.ovirt collection role updated and check for template added)

Gal-Zaidman
Gal-Zaidman reviewed Sep 19, 2021
View reviewed changes
upi/ovirt/inventory.yml Outdated
@@ -38,8 +39,9 @@ all:
compute:
cluster: "{{ ovirt_cluster }}"
memory: 16GiB
sockets: 4
cores: 1
guarantee_memory: 16GiB
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that since this is upsteam I would change it to 12GB

Gal-Zaidman
Gal-Zaidman reviewed Sep 19, 2021
View reviewed changes
upi/ovirt/inventory.yml Outdated
@@ -15,8 +15,9 @@ all:
control_plane:
cluster: "{{ ovirt_cluster }}"
memory: 16GiB
sockets: 4
cores: 1
guarantee_memory: 16GiB
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that since this is upsteam I would change it to 12GB

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@santos1709 can you please look into this note

@Gal-Zaidman
Copy link
Contributor

Please notive the following errors from CI test ci/prow/yaml-lint[1]:

./upi/ovirt/create-templates-and-vms.yml
  30:7      error    wrong indentation: expected 4 but found 6  (indentation)
  40:1      error    trailing spaces  (trailing-spaces)
  47:1      error    trailing spaces  (trailing-spaces)
  51:1      error    trailing spaces  (trailing-spaces)

[1] https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_installer/5222/pull-ci-openshift-installer-master-yaml-lint/1438512175940374528

@santos1709 santos1709 force-pushed the ovirt_upi_devel branch 3 times, most recently from 475fada to 95688b2 Compare October 1, 2021 16:34
@santos1709
Copy link
Author

/retest

ovirt: update of upi playbook files (guaranteed memory added,
a7a2d5b 
ovirt.ovirt collection role updated and check for template added)
@Gal-Zaidman
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 11, 2021
@Gal-Zaidman
Copy link
Contributor

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 12, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Gal-Zaidman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 12, 2021
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 12, 2021 •
edited

@santos1709: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-workers-rhel8 a7a2d5b link false /test e2e-aws-workers-rhel8
ci/prow/e2e-aws-workers-rhel7 a7a2d5b link false /test e2e-aws-workers-rhel7
ci/prow/e2e-openstack a7a2d5b link false /test e2e-openstack
ci/prow/e2e-crc a7a2d5b link false /test e2e-crc

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 4152310 into openshift:master Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gal-Zaidman Gal-Zaidman Gal-Zaidman left review comments

@dougsland dougsland Awaiting requested review from dougsland

@rgolangh rgolangh Awaiting requested review from rgolangh

Assignees

@Gal-Zaidman Gal-Zaidman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@santos1709 @Gal-Zaidman @openshift-bot @openshift-merge-robot