Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1982001: Bump RHCOS 4.8 boot image #5227

Merged

Conversation

mike-nguyen
Copy link
Member

@mike-nguyen mike-nguyen commented Sep 17, 2021

This updates the RHCOS boot image metadata in the installer with the
most recent version of RHCOS 4.8 artifacts.

This includes fixes for the following BZs:
2000696 - RHCOS live ISO can fail to boot in UEFI mode; drops to grub shell
1984086 - Installation with multipath parameters in parmfile fails (DNS resolution missing)
1983773 - coreos-installer fails to download Ignition (DNS error, failed to lookup address)
1982002 - On a Azure IPI installation MCO fails to create new nodes
2004677 - Boot option recovery menu prevents image boot
2004716 - Inexplicably slow kubelet on bootstrap makes installation fail
2007090 - Intermittent failure mounting /run/media/iso when booting live ISO from USB stick

ppc64le=48.84.202109242319-0
s390x=48.84.202109242319-0
x86_64=48.84.202109241901-0

@openshift-ci openshift-ci bot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Sep 17, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 17, 2021

@mike-nguyen: This pull request references Bugzilla bug 1982001, which is invalid:

  • expected dependent Bugzilla bug 1981999 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is POST instead
  • expected dependent Bugzilla bug 2004716 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is NEW instead
  • expected dependent Bugzilla bug 2004716 to target a release in 4.9.0, but it targets "4.8.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1982001: Bump RHCOS 4.8 boot image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Sep 17, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 17, 2021

@mike-nguyen: This pull request references Bugzilla bug 1982001, which is invalid:

  • expected dependent Bugzilla bug 1981999 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is POST instead
  • expected dependent Bugzilla bug 2004716 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is NEW instead
  • expected dependent Bugzilla bug 2004716 to target a release in 4.9.0, but it targets "4.8.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1982001: Bump RHCOS 4.8 boot image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bgilbert
Copy link
Contributor

/bugzilla refresh

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 17, 2021

@bgilbert: This pull request references Bugzilla bug 1982001, which is invalid:

  • expected dependent Bugzilla bug 1981999 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bgilbert
Copy link
Contributor

Per consensus, we're intentionally landing this bump before the corresponding 4.9 bump, which is blocked on a regression. We'll need an override for the Bugzilla check.

@ashcrow ashcrow added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Sep 20, 2021
@ashcrow
Copy link
Member

ashcrow commented Sep 20, 2021

Overriding BZ check since this is expected to land before going into later boot image bumps.

@mike-nguyen
Copy link
Member Author

/retest

4 similar comments
@mike-nguyen
Copy link
Member Author

/retest

@mike-nguyen
Copy link
Member Author

/retest

@mike-nguyen
Copy link
Member Author

/retest

@mike-nguyen
Copy link
Member Author

/retest

@sdodson
Copy link
Member

sdodson commented Sep 21, 2021

/test e2e-gcp
/test e2e-vsphere

1 similar comment
@sdodson
Copy link
Member

sdodson commented Sep 21, 2021

/test e2e-gcp
/test e2e-vsphere

@mike-nguyen
Copy link
Member Author

/retest

@mike-nguyen
Copy link
Member Author

mike-nguyen commented Sep 22, 2021

It looks like all the installer PR CI tests are failing due to missing images. The possible fix may be here: openshift/release#22103

@mike-nguyen
Copy link
Member Author

/retest

1 similar comment
@mike-nguyen
Copy link
Member Author

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 22, 2021

@mike-nguyen: This pull request references Bugzilla bug 1982001, which is invalid:

  • expected dependent Bugzilla bug 1981999 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Retaining the bugzilla/valid-bug label as it was manually added.

In response to this:

Bug 1982001: Bump RHCOS 4.8 boot image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mike-nguyen
Copy link
Member Author

/test e2e-openstack-kuryr

@sdodson
Copy link
Member

sdodson commented Sep 23, 2021

/test e2e-gcp
/test e2e-vsphere
/test e2e-metal

@mike-nguyen
Copy link
Member Author

/test e2e-vsphere
/test e2e-metal
/test e2e-openstack-kuryr

@sdodson
Copy link
Member

sdodson commented Sep 23, 2021

/lgtm
/approve
Looks like the e2e-metal job is broken and needs to be fixed.
Everything else has passed.

@mike-nguyen
Copy link
Member Author

/test e2e-libvirt

@sdodson
Copy link
Member

sdodson commented Sep 23, 2021

/override ci/prow/e2e-libvirt
@mike-nguyen The installation for libvirt is successful. I'm not worried about the test passing, we're just waiting for patch manager approval now.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 23, 2021

@sdodson: Overrode contexts on behalf of sdodson: ci/prow/e2e-libvirt

In response to this:

/override ci/prow/e2e-libvirt
@mike-nguyen The installation for libvirt is successful. I'm not worried about the test passing, we're just waiting for patch manager approval now.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@miabbott
Copy link
Member

/hold

We found a regression that can affect bare metal customers booting from external media

https://bugzilla.redhat.com/show_bug.cgi?id=2007085

We have a fix in flight and will generate new boot images ASAP

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 23, 2021
@sdodson
Copy link
Member

sdodson commented Sep 23, 2021

/lgtm cancel

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 23, 2021
@dhellmann
Copy link
Contributor

[patch-manager] ⌛ This pull request was not picked by the patch manager for the current z-stream window and have to wait for the next window.

skipped for today

  • Score: 0.20
  • Reason: skipping because "do-not-merge/hold" label found

NOTE: This message was automatically generated, if you have questions please ask on #forum-release

This updates the RHCOS boot image metadata in the installer with the
most recent version of RHCOS 4.8 artifacts.

This includes fixes for the following BZs:
2000696 - RHCOS live ISO can fail to boot in UEFI mode; drops to grub shell
1984086 - Installation with multipath parameters in parmfile fails (DNS resolution missing)
1983773 - coreos-installer fails to download Ignition (DNS error, failed to lookup address)
1982002 - On a Azure IPI installation MCO fails to create new nodes
2004677 - Boot option recovery menu prevents image boot
2004716 - Inexplicably slow kubelet on bootstrap makes installation fail
2007090 - Intermittent failure mounting /run/media/iso when booting live ISO from USB stick

ppc64le=48.84.202109242319-0
s390x=48.84.202109242319-0
x86_64=48.84.202109241901-0
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 27, 2021

@mike-nguyen: This pull request references Bugzilla bug 1982001, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.z) matches configured target release for branch (4.8.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1981999 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 1981999 targets the "4.9.0" release, which is one of the valid target releases: 4.9.0
  • bug has dependents

Requesting review from QA contact:
/cc @HuijingHei

In response to this:

Bug 1982001: Bump RHCOS 4.8 boot image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mike-nguyen
Copy link
Member Author

Updated the boot image with the fix for https://bugzilla.redhat.com/show_bug.cgi?id=2007090. This should be ready when the CI passes.

@miabbott
Copy link
Member

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 27, 2021
@miabbott
Copy link
Member

miabbott commented Sep 27, 2021

/test e2e-gcp

@miabbott
Copy link
Member

miabbott commented Sep 27, 2021

Going to retry e2e-aws-upgrade, but it looks like the OS + API server came up, but some operators didn't roll out

time="2021-09-27T13:50:36Z" level=debug msg="Apply complete! Resources: 126 added, 0 changed, 0 destroyed."
time="2021-09-27T13:50:36Z" level=debug msg="OpenShift Installer unreleased-master-4685-g3d6ad281b466757e133263b08eb690ccf4743a5e-dirty"
time="2021-09-27T13:50:36Z" level=debug msg="Built from commit 3d6ad281b466757e133263b08eb690ccf4743a5e"
time="2021-09-27T13:50:36Z" level=info msg="Waiting up to 20m0s for the Kubernetes API at https://api.ci-op-5xt2t0f5-b9fb5.origin-ci-int-aws.dev.rhcloud.com:6443..."
time="2021-09-27T13:50:36Z" level=info msg="API v1.21.2-1503+a620f506e95653-dirty up"
time="2021-09-27T13:50:36Z" level=info msg="Waiting up to 30m0s for bootstrapping to complete..."

/test e2e-aws-upgrade

@miabbott
Copy link
Member

/test e2e-vsphere

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 27, 2021

@mike-nguyen: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal ec45ec2 link false /test e2e-metal
ci/prow/e2e-libvirt a8d6a2b link false /test e2e-libvirt
ci/prow/e2e-vsphere a8d6a2b link false /test e2e-vsphere

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mike-nguyen
Copy link
Member Author

/test e2e-gcp

@sdodson
Copy link
Member

sdodson commented Sep 28, 2021

/lgtm

@sdodson sdodson added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Sep 28, 2021
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 28, 2021
@openshift-merge-robot openshift-merge-robot merged commit be83b7f into openshift:release-4.8 Sep 28, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 28, 2021

@mike-nguyen: All pull requests linked via external trackers have merged:

Bugzilla bug 1982001 has been moved to the MODIFIED state.

In response to this:

Bug 1982001: Bump RHCOS 4.8 boot image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gpei
Copy link
Contributor

gpei commented Sep 29, 2021

Do we want to update the other standalone boot image spec files as well?
data/data/rhcos-aarch64.json
data/data/rhcos-amd64.json
data/data/rhcos-ppc64le.json
data/data/rhcos-s390x.json
data/data/rhcos.json
They're not consistent with the data/data/rhcos-stream.jsonfile now.

@bgilbert
Copy link
Contributor

Thanks for pointing that out. In a discussion with @cgwalters and @miabbott, we concluded that the inconsistency has no serious consequences. We're going to defer a fix for now, but are tracking the issue in BZ 2009000.

miabbott added a commit to miabbott/installer that referenced this pull request Sep 29, 2021
This updates the "legacy" RHCOS boot image metadata to match what is
contained in the stream metadata in `data/data/rhcos-stream.json`.

Note: this does not touch `data/data/rhcos-aarch64.json` as it already
matches the stream metadata and was not updated as part of openshift#5227
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants