Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.7] Bug 1998244: Fix invalid UPI AWS instance type #5306

Closed
wants to merge 1 commit into from
Closed

[release-4.7] Bug 1998244: Fix invalid UPI AWS instance type #5306

wants to merge 1 commit into from

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #5199

/assign e-tienne

Fix invalid UPI AWS instance type
ad8a271 
m5a.10xlarge is not a valid instance type anymore. Replaced with m5a.12xlarge
per https://docs.aws.amazon.com/AWSEC2/latest/APIReference/API_DescribeInstanceTypes.html

generated with `find . -type f -print0 | xargs -0 sed -i 's|m5a.10xlarge|m5a.12xlarge|'`

https://bugzilla.redhat.com/show_bug.cgi?id=1990206
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Oct 18, 2021
Merged
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 18, 2021

@openshift-cherrypick-robot: Detected clone of Bugzilla bug 2002349 with correct target release. Retitling PR to link to clone:
/retitle [release-4.7] [release-4.8] Bug 2015021: Fix invalid UPI AWS instance type

In response to this:

[release-4.7] [release-4.8] Bug 2002349: Fix invalid UPI AWS instance type

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot changed the title [release-4.7] [release-4.8] Bug 2002349: Fix invalid UPI AWS instance type [release-4.7] [release-4.8] Bug 2015021: Fix invalid UPI AWS instance type Oct 18, 2021
@openshift-ci openshift-ci bot added the bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. label Oct 18, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 18, 2021

@openshift-cherrypick-robot: This pull request references Bugzilla bug 2015021, which is invalid:

  • expected the bug to be open, but it isn't
  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is CLOSED (DUPLICATE) instead
  • expected dependent Bugzilla bug 1990206 to target a release in 4.8.0, 4.8.z, but it targets "4.9.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.7] [release-4.8] Bug 2015021: Fix invalid UPI AWS instance type

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Oct 18, 2021
@e-tienne
Copy link
Contributor

/retitle [release-4.7] Bug 1998244: Fix invalid UPI AWS instance type

@openshift-ci openshift-ci bot changed the title [release-4.7] [release-4.8] Bug 2015021: Fix invalid UPI AWS instance type [release-4.7] Bug 1998244: Fix invalid UPI AWS instance type Oct 18, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 18, 2021

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1998244, which is invalid:

  • expected dependent Bugzilla bug 1998243 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is CLOSED (DUPLICATE) instead
  • expected dependent Bugzilla bug 2015021 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is CLOSED (DUPLICATE) instead
  • expected dependent Bugzilla bug 1990206 to target a release in 4.8.0, 4.8.z, but it targets "4.9.0" instead
  • expected dependent Bugzilla bug 2015021 to target a release in 4.8.0, 4.8.z, but it targets "4.7.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.7] Bug 1998244: Fix invalid UPI AWS instance type

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@e-tienne
Copy link
Contributor

/bugzilla refresh

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 18, 2021

@e-tienne: This pull request references Bugzilla bug 1998244, which is invalid:

  • expected dependent Bugzilla bug 1998243 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is CLOSED (DUPLICATE) instead
  • expected dependent Bugzilla bug 2015021 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is CLOSED (DUPLICATE) instead
  • expected dependent Bugzilla bug 1990206 to target a release in 4.8.0, 4.8.z, but it targets "4.9.0" instead
  • expected dependent Bugzilla bug 2015021 to target a release in 4.8.0, 4.8.z, but it targets "4.7.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@e-tienne
Copy link
Contributor

/bugzilla refresh

@openshift-ci openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Oct 18, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 18, 2021

@e-tienne: This pull request references Bugzilla bug 1998244, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.z) matches configured target release for branch (4.7.z)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 2002349 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 2002349 targets the "4.8.z" release, which is one of the valid target releases: 4.8.0, 4.8.z
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (yunjiang@redhat.com), skipping review request.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

e-tienne
e-tienne approved these changes Oct 18, 2021
View reviewed changes
Copy link
Contributor

@e-tienne e-tienne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 18, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 18, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: e-tienne
To complete the pull request process, please assign jstuever after the PR has been reviewed.
You can assign the PR to them by writing /assign @jstuever in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@e-tienne
Copy link
Contributor

This is required for the openshift Product DOCS as some part of it is auto-generated.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 18, 2021

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-crc ad8a271 link false /test e2e-crc
ci/prow/e2e-aws-fips ad8a271 link false /test e2e-aws-fips

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@e-tienne
Copy link
Contributor

/retest-required

@e-tienne
Copy link
Contributor

We will not be backporting this to 4.7 or earlier. If anyone hits this bug, they should move to a newer version.

/close

@openshift-ci openshift-ci bot closed this Oct 19, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 19, 2021

@e-tienne: Closed this PR.

In response to this:

We will not be backporting this to 4.7 or earlier. If anyone hits this bug, they should move to a newer version.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 19, 2021

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1998244. The bug has been updated to no longer refer to the pull request using the external bug tracker. All external bug links have been closed. The bug has been moved to the NEW state.

In response to this:

[release-4.7] Bug 1998244: Fix invalid UPI AWS instance type

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@e-tienne e-tienne e-tienne approved these changes

@jstuever jstuever Awaiting requested review from jstuever

@patrickdillon patrickdillon Awaiting requested review from patrickdillon

Assignees

@e-tienne e-tienne

Labels
bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@openshift-cherrypick-robot @e-tienne