-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
README: Add more hints about cleanup and reinstallation #532
README: Add more hints about cleanup and reinstallation #532
Conversation
Mitigates #522. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not libvirt-specific. Move it to the README quick-start (which we link here)?
@cgwalters, do you think you'll have time to get back to this in the next day or two? Otherwise, can I help somehow (e.g. push a fixup commit up for you to pull, push a fixup straight to your branch, file a replacement PR, ...)? |
This option seems good to me, but it's up to you too! |
491ff5a
to
6fa6c57
Compare
The stale `auth` directory was what was breaking my cluster reinstalls. Let's encourage people to use `--dir`.
6fa6c57
to
fddc4dc
Compare
I've force-pushed 491ff5a -> fddc4dc to @cgwalters' branch, moving the text to the platform-agnostic README, reformatting to one sentence per line, adding a missing comma, and changing "state directory" -> "asset directory". @cgwalters, does that look good to you? |
/lgtm |
@cgwalters: you cannot LGTM your own PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, wking The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The stale
auth
directory was what was breaking my cluster reinstalls.Let's encourage people to use
--dir
.