Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README: Add more hints about cleanup and reinstallation #532

Merged

Conversation

cgwalters
Copy link
Member

The stale auth directory was what was breaking my cluster reinstalls.
Let's encourage people to use --dir.

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 24, 2018
docs/dev/libvirt-howto.md Outdated Show resolved Hide resolved
@wking
Copy link
Member

wking commented Oct 26, 2018

Mitigates #522.

Copy link
Member

@wking wking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not libvirt-specific. Move it to the README quick-start (which we link here)?

@wking
Copy link
Member

wking commented Oct 31, 2018

@cgwalters, do you think you'll have time to get back to this in the next day or two? Otherwise, can I help somehow (e.g. push a fixup commit up for you to pull, push a fixup straight to your branch, file a replacement PR, ...)?

@cgwalters
Copy link
Member Author

push a fixup straight to your branch,

This option seems good to me, but it's up to you too!

The stale `auth` directory was what was breaking my cluster reinstalls.
Let's encourage people to use `--dir`.
@wking
Copy link
Member

wking commented Oct 31, 2018

I've force-pushed 491ff5a -> fddc4dc to @cgwalters' branch, moving the text to the platform-agnostic README, reformatting to one sentence per line, adding a missing comma, and changing "state directory" -> "asset directory". @cgwalters, does that look good to you?

@wking wking changed the title docs/libvirt: Add more hints about cleanup and reinstallation README: Add more hints about cleanup and reinstallation Oct 31, 2018
@cgwalters
Copy link
Member Author

/lgtm

@openshift-ci-robot
Copy link
Contributor

@cgwalters: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wking
Copy link
Member

wking commented Nov 1, 2018

/lgtm
/retest

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 1, 2018
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 1, 2018
@openshift-merge-robot openshift-merge-robot merged commit 9711339 into openshift:master Nov 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants