Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 2017985: Set AWS Bootstrap Type == Master #5337

Merged
merged 1 commit into from Oct 29, 2021
Merged

Bug 2017985: Set AWS Bootstrap Type == Master #5337

merged 1 commit into from Oct 29, 2021

Conversation

patrickdillon
Copy link
Contributor

This commit sets the boostrap node to use the same instance type as the control-plane nodes
in order to avoid failures that we have seen when the hard-coded instance type of m5 is unavailable in the zone.

@patrickdillon
Bug 2017985: Set AWS Bootstrap Type == Master
fbde2fa 
This commit sets the boostrap node to use the
same instance type as the control-plane nodes
in order to avoid failures that we have seen
when the hard-coded instance type of m5 is
unavailable in the zone.
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 27, 2021

@patrickdillon: This pull request references Bugzilla bug 2017985, which is invalid:

  • expected dependent Bugzilla bug 2016955 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2017985: Set AWS Bootstrap Type == Master

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Oct 27, 2021
@patrickdillon patrickdillon mentioned this pull request Oct 27, 2021
Merged
staebler
staebler approved these changes Oct 27, 2021
View reviewed changes
Copy link
Contributor

@staebler staebler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/backport-risk-assessed

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 27, 2021
@staebler
Copy link
Contributor

/label backport-risk-assessed

@openshift-ci openshift-ci bot added backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 27, 2021
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

7 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 28, 2021

@openshift-bot: This pull request references Bugzilla bug 2017985, which is invalid:

  • expected dependent Bugzilla bug 2016955 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

6 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@patrickdillon
Copy link
Contributor Author

/bugzilla refresh

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 29, 2021

@patrickdillon: An error was encountered querying GitHub for users with public email (gpei@redhat.com) for bug 2017985 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message. non-200 OK status code: 403 Forbidden body: "{\n \"documentation_url\": \"https://docs.github.com/en/free-pro-team@latest/rest/overview/resources-in-the-rest-api#secondary-rate-limits\",\n \"message\": \"You have exceeded a secondary rate limit. Please wait a few minutes before you try again.\"\n}\n"

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@patrickdillon
Copy link
Contributor Author

/bugzilla refresh

@openshift-ci openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Oct 29, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 29, 2021

@patrickdillon: This pull request references Bugzilla bug 2017985, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.z) matches configured target release for branch (4.9.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 2016955 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 2016955 targets the "4.10.0" release, which is one of the valid target releases: 4.10.0
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (gpei@redhat.com), skipping review request.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@gpei
Copy link
Contributor

gpei commented Oct 29, 2021

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Oct 29, 2021
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

8 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 29, 2021 •
edited

@patrickdillon: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-e2e-aws-upgrade fbde2fa link false /test okd-e2e-aws-upgrade
ci/prow/okd-e2e-aws fbde2fa link false /test okd-e2e-aws
ci/prow/e2e-aws-workers-rhel7 fbde2fa link false /test e2e-aws-workers-rhel7
ci/prow/e2e-crc fbde2fa link false /test e2e-crc
ci/prow/e2e-openstack-kuryr fbde2fa link false /test e2e-openstack-kuryr

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@patrickdillon
Copy link
Contributor Author

/override e2e-metal-ipi-ovn-ipv6-required

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 29, 2021

@patrickdillon: /override requires a failed status context or a job name to operate on.
The following unknown contexts were given:

  • e2e-metal-ipi-ovn-ipv6-required

Only the following contexts were expected:

  • ci/prow/e2e-aws
  • ci/prow/e2e-aws-fips
  • ci/prow/e2e-aws-upgrade
  • ci/prow/e2e-aws-workers-rhel7
  • ci/prow/e2e-aws-workers-rhel8
  • ci/prow/e2e-crc
  • ci/prow/e2e-libvirt
  • ci/prow/e2e-metal-ipi-ovn-ipv6
  • ci/prow/e2e-metal-ipi-ovn-ipv6-required
  • ci/prow/e2e-metal-single-node-live-iso
  • ci/prow/e2e-openstack
  • ci/prow/e2e-openstack-kuryr
  • ci/prow/e2e-ovirt
  • ci/prow/gofmt
  • ci/prow/golint
  • ci/prow/govet
  • ci/prow/images
  • ci/prow/okd-e2e-aws
  • ci/prow/okd-e2e-aws-upgrade
  • ci/prow/okd-images
  • ci/prow/okd-unit
  • ci/prow/okd-verify-codegen
  • ci/prow/openstack-manifests
  • ci/prow/shellcheck
  • ci/prow/tf-fmt
  • ci/prow/tf-lint
  • ci/prow/unit
  • ci/prow/verify-codegen
  • ci/prow/verify-vendor
  • ci/prow/yaml-lint
  • pull-ci-openshift-installer-release-4.1-e2e-aws
  • pull-ci-openshift-installer-release-4.1-e2e-aws-upgrade
  • pull-ci-openshift-installer-release-4.1-gofmt
  • pull-ci-openshift-installer-release-4.1-golint
  • pull-ci-openshift-installer-release-4.1-govet
  • pull-ci-openshift-installer-release-4.1-images
  • pull-ci-openshift-installer-release-4.1-shellcheck
  • pull-ci-openshift-installer-release-4.1-tf-fmt
  • pull-ci-openshift-installer-release-4.1-tf-lint
  • pull-ci-openshift-installer-release-4.1-unit
  • pull-ci-openshift-installer-release-4.1-verify-vendor
  • pull-ci-openshift-installer-release-4.1-yaml-lint
  • pull-ci-openshift-installer-release-4.10-e2e-aws-fips
  • pull-ci-openshift-installer-release-4.10-e2e-aws-workers-rhel7
  • pull-ci-openshift-installer-release-4.10-e2e-aws-workers-rhel8
  • pull-ci-openshift-installer-release-4.10-e2e-crc
  • pull-ci-openshift-installer-release-4.10-e2e-libvirt
  • pull-ci-openshift-installer-release-4.10-e2e-metal-ipi-ovn-ipv6
  • pull-ci-openshift-installer-release-4.10-e2e-metal-ipi-ovn-ipv6-required
  • pull-ci-openshift-installer-release-4.10-e2e-metal-single-node-live-iso
  • pull-ci-openshift-installer-release-4.10-e2e-openstack
  • pull-ci-openshift-installer-release-4.10-e2e-openstack-kuryr
  • pull-ci-openshift-installer-release-4.10-e2e-ovirt
  • pull-ci-openshift-installer-release-4.10-okd-e2e-aws
  • pull-ci-openshift-installer-release-4.10-okd-e2e-aws-upgrade
  • pull-ci-openshift-installer-release-4.10-okd-images
  • pull-ci-openshift-installer-release-4.10-okd-unit
  • pull-ci-openshift-installer-release-4.10-okd-verify-codegen
  • pull-ci-openshift-installer-release-4.10-openstack-manifests
  • pull-ci-openshift-installer-release-4.10-verify-codegen
  • tide

In response to this:

/override e2e-metal-ipi-ovn-ipv6-required

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@patrickdillon
Copy link
Contributor Author

/override ci/prow/e2e-metal-ipi-ovn-ipv6-required

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 29, 2021

@patrickdillon: Overrode contexts on behalf of patrickdillon: ci/prow/e2e-metal-ipi-ovn-ipv6-required

In response to this:

/override ci/prow/e2e-metal-ipi-ovn-ipv6-required

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@patrickdillon
Copy link
Contributor Author

/skip

@openshift-merge-robot openshift-merge-robot merged commit 1c538b8 into openshift:release-4.9 Oct 29, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 29, 2021

@patrickdillon: All pull requests linked via external trackers have merged:

Bugzilla bug 2017985 has been moved to the MODIFIED state.

In response to this:

Bug 2017985: Set AWS Bootstrap Type == Master

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@staebler staebler staebler approved these changes

@e-tienne e-tienne e-tienne approved these changes

@jstuever jstuever Awaiting requested review from jstuever

Assignees

@staebler staebler

@e-tienne e-tienne

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@patrickdillon @staebler @openshift-bot @gpei @e-tienne @openshift-merge-robot