Bug 2027329: Handle unset default machine pool #5424

stephenfin · 2021-11-26T17:41:02Z

If the user has explicitly provided controlPlane and compute configuration, then there won't be a default to consider.

This was hit in CI once platform.openstack.computeFlavor was no longer defined in a generated install-config.yaml file. This had been masking the bug since setting that attribute resulted in us initializing config.Platform.OpenStack.DefaultMachinePlatform with an openstack.MachinePool instance and populating the FlavorName attribute of this struct (see pkg/types/conversion/installconfig.go for more info).

/label platform/openstack

If the user has explicitly provided 'controlPlane' and 'compute' configuration, then there won't be a default to consider. This was hit in CI once 'platform.openstack.computeFlavor' was no longer defined in a generated 'install-config.yaml' file. This had been masking the bug since setting that attribute resulted in us initializing 'config.Platform.OpenStack.DefaultMachinePlatform' with an 'openstack.MachinePool' instance and populating the 'FlavorName' attribute of this struct (see 'pkg/types/conversion/installconfig.go' for more info). Signed-off-by: Stephen Finucane <stephenfin@redhat.com>

openshift-ci · 2021-11-26T17:41:03Z

@stephenfin: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

openstack: Handle unset default machine pool

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2021-11-26T17:41:03Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

openshift-ci · 2021-11-29T12:27:52Z

@stephenfin: This pull request references Bugzilla bug 2027329, which is invalid:

expected the bug to target the "4.9.z" release, but it targets "---" instead
expected Bugzilla bug 2027329 to depend on a bug targeting a release in 4.10.0 and in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2027329: Handle unset default machine pool

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

stephenfin · 2021-11-29T12:49:30Z

/bugzilla refresh

openshift-ci · 2021-11-29T12:49:40Z

@stephenfin: This pull request references Bugzilla bug 2027329, which is invalid:

expected Bugzilla bug 2027329 to depend on a bug targeting a release in 4.10.0 and in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2021-11-29T12:53:23Z

@stephenfin: This pull request references Bugzilla bug 2027329, which is invalid:

expected Bugzilla bug 2027329 to depend on a bug targeting a release in 4.10.0 and in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2027329: Handle unset default machine pool

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

stephenfin · 2021-11-29T12:53:35Z

/label platform/openstack

mandre · 2021-11-29T16:03:36Z

/bugzilla refresh

openshift-ci · 2021-11-29T16:03:44Z

@mandre: This pull request references Bugzilla bug 2027329, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.9.z) matches configured target release for branch (4.9.z)
bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 2027425 is in the state CLOSED (CURRENTRELEASE), which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
dependent Bugzilla bug 2027425 targets the "4.10.0" release, which is one of the valid target releases: 4.10.0
bug has dependents

Requesting review from QA contact:
/cc @eurijon

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

pierreprinetti · 2021-11-30T12:54:50Z

/approve
/lgtm
👍

openshift-ci · 2021-11-30T12:55:53Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pierreprinetti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~pkg/types/openstack/OWNERS~~ [pierreprinetti]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2021-11-30T13:07:43Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

mandre

/lgtm
/label backport-risk-assessed

openshift-bot · 2021-11-30T13:31:40Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-11-30T13:43:43Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

eurijon · 2021-11-30T13:45:14Z

/label cherry-pick-approved

openshift-bot · 2021-11-30T13:55:41Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-11-30T14:43:39Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-11-30T14:55:42Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-11-30T15:19:43Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-11-30T15:32:42Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-11-30T15:44:47Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-ci · 2021-11-30T17:06:13Z

@stephenfin: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-ovirt	`5b55356`	link	false	`/test e2e-ovirt`
ci/prow/e2e-aws-workers-rhel7	`5b55356`	link	false	`/test e2e-aws-workers-rhel7`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

stephenfin · 2021-11-30T17:46:52Z

/test e2e-aws-upgrade

openshift-bot · 2021-11-30T18:20:45Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-11-30T18:32:43Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-11-30T18:44:46Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-11-30T19:08:43Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-11-30T19:32:44Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-11-30T19:44:43Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-11-30T20:08:43Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-ci · 2021-11-30T20:19:38Z

@stephenfin: All pull requests linked via external trackers have merged:

openshift/installer#5424

Bugzilla bug 2027329 has been moved to the MODIFIED state.

In response to this:

Bug 2027329: Handle unset default machine pool

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-cherrypick-robot · 2021-11-30T21:28:15Z

@EmilienM: base branch (release-4.9) needs to differ from target branch (release-4.9)

In response to this:

/cherry-pick release-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci bot requested review from EmilienM and mdbooth November 26, 2021 17:42

stephenfin changed the title ~~openstack: Handle unset default machine pool~~ Bug 2027329: Handle unset default machine pool Nov 29, 2021

openshift-ci bot added the platform/openstack label Nov 29, 2021

stephenfin marked this pull request as ready for review November 29, 2021 12:56

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 29, 2021

openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Nov 29, 2021

openshift-ci bot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Nov 29, 2021

openshift-ci bot requested a review from eurijon November 29, 2021 16:03

openshift-ci bot assigned pierreprinetti Nov 30, 2021

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 30, 2021

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 30, 2021

mandre reviewed Nov 30, 2021

View reviewed changes

openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Nov 30, 2021

openshift-ci bot assigned mandre Nov 30, 2021

openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Nov 30, 2021

openshift-merge-robot merged commit e2850d6 into openshift:release-4.9 Nov 30, 2021

stephenfin deleted the issue/5423 branch November 30, 2021 22:24

stephenfin mentioned this pull request Dec 2, 2021

Invalid memory address or nil pointer dereference when 'computeFlavor' is unset #5423

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bug 2027329: Handle unset default machine pool #5424

Bug 2027329: Handle unset default machine pool #5424

stephenfin commented Nov 26, 2021 •

edited

openshift-ci bot commented Nov 26, 2021

openshift-ci bot commented Nov 26, 2021

openshift-ci bot commented Nov 29, 2021

stephenfin commented Nov 29, 2021

openshift-ci bot commented Nov 29, 2021

openshift-ci bot commented Nov 29, 2021

stephenfin commented Nov 29, 2021

mandre commented Nov 29, 2021

openshift-ci bot commented Nov 29, 2021

pierreprinetti commented Nov 30, 2021

openshift-ci bot commented Nov 30, 2021

openshift-bot commented Nov 30, 2021

mandre left a comment

openshift-bot commented Nov 30, 2021

openshift-bot commented Nov 30, 2021

eurijon commented Nov 30, 2021

openshift-bot commented Nov 30, 2021

openshift-bot commented Nov 30, 2021

openshift-bot commented Nov 30, 2021

openshift-bot commented Nov 30, 2021

openshift-bot commented Nov 30, 2021

openshift-bot commented Nov 30, 2021

openshift-ci bot commented Nov 30, 2021 •

edited

stephenfin commented Nov 30, 2021

openshift-bot commented Nov 30, 2021

openshift-bot commented Nov 30, 2021

openshift-bot commented Nov 30, 2021

openshift-bot commented Nov 30, 2021

openshift-bot commented Nov 30, 2021

openshift-bot commented Nov 30, 2021

openshift-bot commented Nov 30, 2021

openshift-ci bot commented Nov 30, 2021

openshift-cherrypick-robot commented Nov 30, 2021

Bug 2027329: Handle unset default machine pool #5424

Bug 2027329: Handle unset default machine pool #5424

Conversation

stephenfin commented Nov 26, 2021 • edited

openshift-ci bot commented Nov 26, 2021

openshift-ci bot commented Nov 26, 2021

openshift-ci bot commented Nov 29, 2021

stephenfin commented Nov 29, 2021

openshift-ci bot commented Nov 29, 2021

openshift-ci bot commented Nov 29, 2021

stephenfin commented Nov 29, 2021

mandre commented Nov 29, 2021

openshift-ci bot commented Nov 29, 2021

pierreprinetti commented Nov 30, 2021

openshift-ci bot commented Nov 30, 2021

openshift-bot commented Nov 30, 2021

mandre left a comment

Choose a reason for hiding this comment

openshift-bot commented Nov 30, 2021

openshift-bot commented Nov 30, 2021

eurijon commented Nov 30, 2021

openshift-bot commented Nov 30, 2021

openshift-bot commented Nov 30, 2021

openshift-bot commented Nov 30, 2021

openshift-bot commented Nov 30, 2021

openshift-bot commented Nov 30, 2021

openshift-bot commented Nov 30, 2021

openshift-ci bot commented Nov 30, 2021 • edited

stephenfin commented Nov 30, 2021

openshift-bot commented Nov 30, 2021

openshift-bot commented Nov 30, 2021

openshift-bot commented Nov 30, 2021

openshift-bot commented Nov 30, 2021

openshift-bot commented Nov 30, 2021

openshift-bot commented Nov 30, 2021

openshift-bot commented Nov 30, 2021

openshift-ci bot commented Nov 30, 2021

openshift-cherrypick-robot commented Nov 30, 2021

stephenfin commented Nov 26, 2021 •

edited

openshift-ci bot commented Nov 30, 2021 •

edited