Alibaba: fix: add the availability zone of worker #5438
Conversation
|
Hi @bd233. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
needs-ok-to-test
|
/ok-to-test |
openshift-ci
bot
added
ok-to-test
|
LGTM. I will let @kwoodson take a look |
openshift-ci
bot
added
the
approved
|
I will test this one now. brb |
There was a problem hiding this comment.
There is other work that needs to happen first before this can go in as is. Currently, the number of master instances created is equal to the number of vswitches. There is one vswitch for every zone. If we make this change to add workers to the zones, then we will end up creating masters in every zone where we have workers, which is not what the user may want. I think this PR is dependent upon #5379.
The comments for the following terraform variables need to be changed.
bd233
force-pushed
the
alibabacloud-worker-zones
branch
from
9f8a8fc
to
9b260cf
Compare
bd233
force-pushed
the
alibabacloud-worker-zones
branch
from
9b260cf
to
9cea453
Compare
|
@bd233: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest-required |
| @@ -25,7 +25,7 @@ variable "ali_private_zone_id" { | |||
|
|
|||
| variable "ali_zone_ids" { | |||
| type = list(string) | |||
| description = "The availability zones in which to create the masters. The length of this list must match master_count." | |||
| description = "The availability zones in which to create the masters, workers and bootstrap node." | |||
There was a problem hiding this comment.
This change will break the masters module. The zone ids passed into the master module must be an ordered list corresponding to the masters that need to be created. There needs to be one variable for the master zone ids and a separate variable for the worker zone ids.
There was a problem hiding this comment.
Yes, your are right. I have updated.
The `ali_zone_ids` needs to contain the availability zone of the workers, and create the VSwitches Signed-off-by: sunhui <wb-sh373163@alibaba-inc.com>
bd233
force-pushed
the
alibabacloud-worker-zones
branch
from
9cea453
to
a9e7d82
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: patrickdillon, staebler The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
4 similar comments
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
The
ali_zone_idsneeds to contain the availability zone of the workers,and create the VSwitches