Bug 2048451: Use proxy dial to validate endpoints #5600
Conversation
rna-afk
changed the title
openshift-ci
bot
added
bugzilla/severity-medium
|
@rna-afk: This pull request references Bugzilla bug 2048451, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Bugzilla (gpei@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
rna-afk
force-pushed
the
use_proxy_dial_aws_endpoint
branch
2 times, most recently
from
ac4d72d
to
927f2fe
Compare
|
You need to update the vendor, too, to get the golang.org/x/net/proxy module. |
rna-afk
force-pushed
the
use_proxy_dial_aws_endpoint
branch
2 times, most recently
from
0c5a72e
to
4bb4737
Compare
Using proxy dial instead of the current net dial for validating service endpoints in AWS since there could be a proxy setup when an IPI restricted installation occurs that might make the the endpoints unreachable without using them.
rna-afk
force-pushed
the
use_proxy_dial_aws_endpoint
branch
from
4bb4737
to
048e009
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: staebler The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
6 similar comments
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
@rna-afk: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@rna-afk: All pull requests linked via external trackers have merged: Bugzilla bug 2048451 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Using proxy dial instead of the current net dial for validating
service endpoints in AWS since there could be a proxy setup
when an IPI restricted installation occurs that might make the
the endpoints unreachable without using them.