New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update declarative assets for Nutanix #5636

Merged

openshift-merge-robot merged 3 commits into openshift:master from nutanix-cloud-native:ntnx-8.1

Apr 6, 2022

Contributor

thunderboltsid commented Feb 10, 2022 •

edited

Update bootkube template to copy static resources for nutanix under data/data/bootstrap/files
Add terraform files for Nutanix platform under data/data/nutanix
Add terraform stages for Nutanix platform under pkg/terraform/stages/nutanix

openshift-ci bot requested review from jhixson74 and jstuever

February 10, 2022 15:31

rvanderp3 reviewed

View reviewed changes

data/data/nutanix/pre-bootstrap/main.tf Outdated Show resolved Hide resolved

rvanderp3 reviewed

View reviewed changes

data/data/nutanix/master/main.tf Outdated Show resolved Hide resolved

thunderboltsid force-pushed the ntnx-8.1 branch 3 times, most recently from 4d25ef7 to e8626da Compare

March 17, 2022 13:17

Contributor Author

thunderboltsid commented Mar 17, 2022

/retest-required

rvanderp3 reviewed

View reviewed changes

data/data/nutanix/variables-nutanix.tf Outdated Show resolved Hide resolved

rvanderp3 mentioned this pull request

Add nutanix-specific terraform variables #5637

Merged

thunderboltsid force-pushed the ntnx-8.1 branch from e8626da to c3bb9e9 Compare

March 21, 2022 12:49

Contributor

rvanderp3 commented Mar 21, 2022

/lgtm

My only comment here is that it would have been helpful to have tools.go in its own commit.

openshift-ci bot assigned rvanderp3

openshift-ci bot added the lgtm label

Contributor

rvanderp3 commented Mar 21, 2022

/lgtm

My only comment here is that it would have been helpful to have tools.go in its own commit.

apologies, this comment is not relevant to this PR

Contributor

rvanderp3 commented Mar 21, 2022

/lgtm cancel

openshift-ci bot removed the lgtm label

Contributor Author

thunderboltsid commented Mar 21, 2022

/retest-required

1 similar comment

Contributor Author

thunderboltsid commented Mar 21, 2022

/retest-required

Contributor

rvanderp3 commented Mar 23, 2022

@thunderboltsid would you mind taking a look at the merge conflict?

thunderboltsid force-pushed the ntnx-8.1 branch from c3bb9e9 to affe38b Compare

March 23, 2022 19:08

Contributor Author

thunderboltsid commented Mar 23, 2022

/retest-required

1 similar comment

Contributor Author

thunderboltsid commented Mar 24, 2022

/retest-required

rvanderp3 reviewed

View reviewed changes

Contributor

rvanderp3 left a comment

Found a nit and had a few questions on the terraform provider timeout value.

data/data/nutanix/bootstrap/main.tf Show resolved Hide resolved

data/data/nutanix/master/main.tf Outdated Show resolved Hide resolved

data/data/nutanix/pre-bootstrap/main.tf Outdated Show resolved Hide resolved

data/data/nutanix/variables-nutanix.tf Outdated Show resolved Hide resolved

thunderboltsid force-pushed the ntnx-8.1 branch from affe38b to cfb4d3d Compare

March 24, 2022 20:08

Contributor

makentenza commented Mar 28, 2022

/retest-required

1 similar comment

Contributor Author

thunderboltsid commented Mar 28, 2022

/retest-required

Contributor

rvanderp3 commented Mar 29, 2022

/lgtm
/assign @staebler

openshift-ci bot assigned staebler

openshift-ci bot added the lgtm label


          Update bootkube template

56ebf1a

Copy static assets for nutanix in bootkube.sh.template

thunderboltsid force-pushed the ntnx-8.1 branch from 424cd14 to cc9a150 Compare

April 1, 2022 18:44

thunderboltsid changed the title ~~Add Nutanix terraform files~~ Update declarative assets for Nutanix

Contributor Author

thunderboltsid commented Apr 2, 2022

/retest-required

thunderboltsid force-pushed the ntnx-8.1 branch from cc9a150 to b8a0846 Compare

April 3, 2022 09:52

Contributor Author

thunderboltsid commented Apr 3, 2022

/retest-required

1 similar comment

Contributor Author

thunderboltsid commented Apr 4, 2022

/retest-required

Contributor

rvanderp3 commented Apr 4, 2022

/lgtm

openshift-ci bot added the lgtm label

staebler reviewed

View reviewed changes

data/data/bootstrap/files/usr/local/bin/bootkube.sh.template Show resolved Hide resolved

data/data/nutanix/pre-bootstrap/main.tf Outdated Show resolved Hide resolved

pkg/terraform/stages/nutanix/stages.go Outdated Show resolved Hide resolved

staebler reviewed

View reviewed changes

data/data/nutanix/pre-bootstrap/main.tf Outdated Show resolved Hide resolved

thunderboltsid force-pushed the ntnx-8.1 branch from b8a0846 to 184e420 Compare

April 6, 2022 09:38

openshift-ci bot removed the lgtm label

thunderboltsid added 2 commits

April 6, 2022 14:43


          Add Nutanix terraform files

372711a

Add terraform files for Nutanix platform under data/data/nutanix
as two stages:
- Bootstrap uploads the bootstrap ignition image and provisions
the bootstrap node.
- Cluster creates the categories, uploads the rhcos image, and
provisions the master nodes in the cluster.


          Add Terraform stages for nutanix

64872b5

Add stages for nutanix terraform files.

thunderboltsid force-pushed the ntnx-8.1 branch from 184e420 to 64872b5 Compare

April 6, 2022 12:44

staebler reviewed

View reviewed changes

Contributor

staebler left a comment

/lgtm
/approve

openshift-ci bot added the lgtm label

Contributor

openshift-ci bot commented Apr 6, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: staebler

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [staebler]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci bot added the approved label

Contributor

openshift-bot commented Apr 6, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

6 similar comments

Contributor

openshift-bot commented Apr 6, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Apr 6, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Apr 6, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Apr 6, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Apr 6, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Apr 6, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-merge-robot merged commit f546bdd into openshift:master

Contributor

openshift-ci bot commented Apr 6, 2022

@thunderboltsid: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-azure-upi	`cfb4d3d`	link	false	`/test e2e-azure-upi`
ci/prow/e2e-gcp-upgrade	`424cd14`	link	true	`/test e2e-gcp-upgrade`
ci/prow/okd-e2e-aws-upgrade	`424cd14`	link	false	`/test okd-e2e-aws-upgrade`
ci/prow/e2e-aws-upgrade	`424cd14`	link	true	`/test e2e-aws-upgrade`
ci/prow/e2e-gcp	`64872b5`	link	false	`/test e2e-gcp`
ci/prow/e2e-crc	`64872b5`	link	false	`/test e2e-crc`
ci/prow/e2e-gcp-shared-vpc	`64872b5`	link	false	`/test e2e-gcp-shared-vpc`
ci/prow/e2e-azurestack	`64872b5`	link	false	`/test e2e-azurestack`
ci/prow/e2e-gcp-upi-xpn	`64872b5`	link	false	`/test e2e-gcp-upi-xpn`
ci/prow/e2e-aws-proxy	`64872b5`	link	false	`/test e2e-aws-proxy`
ci/prow/e2e-libvirt	`64872b5`	link	false	`/test e2e-libvirt`
ci/prow/e2e-aws-disruptive	`64872b5`	link	false	`/test e2e-aws-disruptive`
ci/prow/e2e-metal-ipi-ovn-ipv6	`64872b5`	link	false	`/test e2e-metal-ipi-ovn-ipv6`
ci/prow/e2e-azure	`64872b5`	link	false	`/test e2e-azure`
ci/prow/e2e-ibmcloud	`64872b5`	link	false	`/test e2e-ibmcloud`
ci/prow/e2e-ovirt	`64872b5`	link	false	`/test e2e-ovirt`
ci/prow/e2e-openstack-proxy	`64872b5`	link	false	`/test e2e-openstack-proxy`
ci/prow/e2e-alibaba	`64872b5`	link	false	`/test e2e-alibaba`
ci/prow/e2e-aws-fips	`64872b5`	link	false	`/test e2e-aws-fips`
ci/prow/e2e-vsphere	`64872b5`	link	false	`/test e2e-vsphere`
ci/prow/e2e-azure-resourcegroup	`64872b5`	link	false	`/test e2e-azure-resourcegroup`
ci/prow/e2e-openstack-parallel	`64872b5`	link	false	`/test e2e-openstack-parallel`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

thunderboltsid deleted the ntnx-8.1 branch

May 25, 2022 07:16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment