ipi/vsphere: improve permission error messages

[git-hyagi]

Make it easier to find the missing privileges in case of an error on vSphere installations.
Maybe not the best way to implement it, as it is parsing the error messages (string)
to provide better output, but this is the only way that I could find considering
that the VMware vSphere API is not public, so we cannot make any changes to it.

Proposal implementation for https://issues.redhat.com/browse/RFE-1965

[openshift-ci]

@git-hyagi: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

ipi/vsphere: improve permission error messages

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

Hi @git-hyagi. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[vwalek]

@jhixson74 - any update on the PR?

[openshift-ci]

@git-hyagi: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-bot]

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

[openshift-bot]

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

[sadasu]

@git-hyagi could you please rebase these changes?

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign sdodson for approval by writing /assign @sdodson in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[sadasu]

/remove-lifecycle rotten

[sadasu]

/ok-to-test

[sadasu]

/retest-required

[openshift-ci]

@git-hyagi: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-openstack	b3f665e	link	false	/test e2e-openstack
ci/prow/e2e-ibmcloud	b3f665e	link	false	/test e2e-ibmcloud
ci/prow/e2e-aws-upi-proxy	b3f665e	link	false	/test e2e-aws-upi-proxy
ci/prow/verify-vendor	b3f665e	link	true	/test verify-vendor
ci/prow/e2e-crc	b3f665e	link	false	/test e2e-crc
ci/prow/e2e-libvirt	b3f665e	link	false	/test e2e-libvirt
ci/prow/e2e-metal-ipi	b3f665e	link	false	/test e2e-metal-ipi

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[sadasu]

@git-hyagi this PR needs a BZ to merge into 4.11. Do you have one?

[sadasu]

/lgtm

[vwalek]

@git-hyagi this PR needs a BZ to merge into 4.11. Do you have one?

Hey @sadasu , hyagi is working on different project, different department. Let me know what do you need? I can do it if you want.

[sadasu]

@vwalek this fix has to go into 4.12 first and then backported to 4.11. Can you rebase this fix against master? And then we would need to backport this to 4.11 after associating it with a BZ.

[bostrt]

There's another effort happening in #5741 that solves the issue more broadly. Can we hold this PR until 5741 has some more time to receive reviews?

/hold

[sadasu]

@bostrt #5741 has merged. Does that make this PR obsolete?

[bostrt]

@sadasu thanks for the ping! Yes, let's close this one out since the other PR has merged. Thanks for all the hard work in here!

/close

[openshift-ci]

@bostrt: Closed this PR.

In response to this:

@sadasu thanks for the ping! Yes, let's close this one out since the other PR has merged. Thanks for all the hard work in here!

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.