-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
terraform: upgrade alicloud provider to v1.158.0 #5674
terraform: upgrade alicloud provider to v1.158.0 #5674
Conversation
/test e2e-alicloud |
@staebler: The specified target(s) for
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test e2e-alibaba |
/approve |
eb482f8
to
d5016a0
Compare
When openshift#5507 was merged, the version of the alicloud terraform provider was set to v1.148.0, which is the version in use when the PR was created. However, in the time between creation and merge, openshift#5571 was merged, which upgrade the version to v1.153.0. This change was lost during conflict resolution. Let's upgrade to the latest version (v1.158.0) of the alicloud terraform provider while we are at it.
/reopen |
@staebler: Reopened this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: patrickdillon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: patrickdillon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cc @kwoodson |
Testing cluster install. |
Thanks. Note that this is restoring the version that is used in 4.10. I am open to upgrading to an even more recent version, too. As of now, that would be v1.160.0. |
Unfortunately I'm still seeing this behavior.
Here is a list of the backends:
Teardown logs
I'm willing to test a v1.160.0 PR if you'd like to try it. I'm a little confused as to why this is a problem since this still works in 4.10. |
Sorry, for the confusion. I did not mean to imply that the upgrade of the terraform provider would fix that problem. I am just trying to rectify the mistaken change in versions from 4.10 to 4.11. |
@staebler I'm supportive of this change. Moving back to the 1.158 sounds good to me. If you want to try moving forward I can test that as well. |
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
/remove-lifecycle stale |
/lgtm |
/retest-required |
/hold Revision 5ddbd9c was retested 9 times: holding |
/test e2e-alibaba |
/retest-required |
2 similar comments
/retest-required |
/retest-required |
/hold cancel |
/skip e2e-metal-ipi-ovn-ipv6 |
/skip e2e-azure-upi |
/test e2e-alibaba |
/hold |
/close Latest version is now 1.182.0. Will upgrade to the latest when we see a need. |
@sadasu: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@staebler: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
When #5507 was merged, the version of the alicloud terraform provider was set to v1.148.0, which is the version in use when the PR was created. However, in the time between creation and merge, #5571 was merged, which upgrade the version to v1.153.0. This change was lost during conflict resolution.
Let's upgrade to the latest version (v1.158.0) of the alicloud terraform provider while we are at it.