Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

terraform: upgrade alicloud provider to v1.158.0 #5674

Conversation

staebler
Copy link
Contributor

@staebler staebler commented Mar 2, 2022

When #5507 was merged, the version of the alicloud terraform provider was set to v1.148.0, which is the version in use when the PR was created. However, in the time between creation and merge, #5571 was merged, which upgrade the version to v1.153.0. This change was lost during conflict resolution.

Let's upgrade to the latest version (v1.158.0) of the alicloud terraform provider while we are at it.

@staebler
Copy link
Contributor Author

staebler commented Mar 2, 2022

/test e2e-alicloud

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 2, 2022

@staebler: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test e2e-aws
  • /test e2e-aws-upgrade
  • /test e2e-gcp-upgrade
  • /test e2e-metal-ipi-ovn-ipv6-required
  • /test gofmt
  • /test golint
  • /test govet
  • /test images
  • /test okd-images
  • /test okd-unit
  • /test okd-verify-codegen
  • /test openstack-manifests
  • /test shellcheck
  • /test tf-lint
  • /test unit
  • /test verify-codegen
  • /test verify-vendor
  • /test yaml-lint

The following commands are available to trigger optional jobs:

  • /test e2e-alibaba
  • /test e2e-aws-disruptive
  • /test e2e-aws-fips
  • /test e2e-aws-proxy
  • /test e2e-aws-rhel8
  • /test e2e-aws-shared-vpc
  • /test e2e-aws-single-node
  • /test e2e-aws-upi
  • /test e2e-aws-upi-proxy
  • /test e2e-aws-workers-rhel8
  • /test e2e-azure
  • /test e2e-azure-resourcegroup
  • /test e2e-azure-shared-vpc
  • /test e2e-azure-upi
  • /test e2e-azurestack
  • /test e2e-azurestack-upi
  • /test e2e-crc
  • /test e2e-gcp
  • /test e2e-gcp-shared-vpc
  • /test e2e-gcp-upi
  • /test e2e-gcp-upi-xpn
  • /test e2e-ibmcloud
  • /test e2e-libvirt
  • /test e2e-metal
  • /test e2e-metal-assisted
  • /test e2e-metal-ipi
  • /test e2e-metal-ipi-ovn-dualstack
  • /test e2e-metal-ipi-ovn-ipv6
  • /test e2e-metal-ipi-swapped-hosts
  • /test e2e-metal-ipi-virtualmedia
  • /test e2e-metal-single-node-live-iso
  • /test e2e-openstack
  • /test e2e-openstack-kuryr
  • /test e2e-openstack-parallel
  • /test e2e-openstack-proxy
  • /test e2e-openstack-upi
  • /test e2e-ovirt
  • /test e2e-vsphere
  • /test e2e-vsphere-upi
  • /test okd-e2e-aws
  • /test okd-e2e-aws-upgrade
  • /test okd-e2e-gcp
  • /test okd-e2e-gcp-upgrade
  • /test okd-e2e-vsphere
  • /test tf-fmt

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-installer-master-e2e-aws
  • pull-ci-openshift-installer-master-e2e-aws-fips
  • pull-ci-openshift-installer-master-e2e-aws-single-node
  • pull-ci-openshift-installer-master-e2e-aws-upgrade
  • pull-ci-openshift-installer-master-e2e-aws-workers-rhel8
  • pull-ci-openshift-installer-master-e2e-azure-upi
  • pull-ci-openshift-installer-master-e2e-crc
  • pull-ci-openshift-installer-master-e2e-ibmcloud
  • pull-ci-openshift-installer-master-e2e-libvirt
  • pull-ci-openshift-installer-master-e2e-metal-ipi-ovn-ipv6
  • pull-ci-openshift-installer-master-e2e-metal-single-node-live-iso
  • pull-ci-openshift-installer-master-e2e-openstack
  • pull-ci-openshift-installer-master-e2e-openstack-kuryr
  • pull-ci-openshift-installer-master-e2e-ovirt
  • pull-ci-openshift-installer-master-gofmt
  • pull-ci-openshift-installer-master-golint
  • pull-ci-openshift-installer-master-govet
  • pull-ci-openshift-installer-master-images
  • pull-ci-openshift-installer-master-okd-e2e-aws
  • pull-ci-openshift-installer-master-okd-e2e-aws-upgrade
  • pull-ci-openshift-installer-master-okd-images
  • pull-ci-openshift-installer-master-okd-unit
  • pull-ci-openshift-installer-master-okd-verify-codegen
  • pull-ci-openshift-installer-master-openstack-manifests
  • pull-ci-openshift-installer-master-shellcheck
  • pull-ci-openshift-installer-master-tf-fmt
  • pull-ci-openshift-installer-master-tf-lint
  • pull-ci-openshift-installer-master-unit
  • pull-ci-openshift-installer-master-verify-codegen
  • pull-ci-openshift-installer-master-verify-vendor
  • pull-ci-openshift-installer-master-yaml-lint

In response to this:

/test e2e-alicloud

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@staebler
Copy link
Contributor Author

staebler commented Mar 2, 2022

/test e2e-alibaba

@patrickdillon
Copy link
Contributor

/approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 2, 2022
@staebler staebler closed this Mar 14, 2022
@staebler staebler force-pushed the upgrade_alicloud_terraform_provider branch from eb482f8 to d5016a0 Compare March 14, 2022 14:13
When openshift#5507 was merged, the version of the alicloud terraform provider was set to v1.148.0,
which is the version in use when the PR was created. However, in the time between creation
and merge, openshift#5571 was merged, which upgrade the version to v1.153.0. This change was lost
during conflict resolution.

Let's upgrade to the latest version (v1.158.0) of the alicloud terraform provider while we
are at it.
@staebler
Copy link
Contributor Author

/reopen

@openshift-ci openshift-ci bot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 14, 2022
@openshift-ci openshift-ci bot reopened this Mar 14, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 14, 2022

@staebler: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 14, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 14, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 14, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@staebler
Copy link
Contributor Author

/cc @kwoodson
Would you mind giving this a review, please?

@openshift-ci openshift-ci bot requested a review from kwoodson March 17, 2022 13:29
@kwoodson
Copy link
Contributor

Testing cluster install.

@staebler
Copy link
Contributor Author

Testing cluster install.

Thanks. Note that this is restoring the version that is used in 4.10. I am open to upgrading to an even more recent version, too. As of now, that would be v1.160.0.

@kwoodson
Copy link
Contributor

Unfortunately I'm still seeing this behavior.

+ LDFLAGS=' -X github.com/openshift/installer/pkg/version.Raw=unreleased-master-5702-g5ddbd9c9f44c99dd34beecec77e2030c2b3a17af -X github.com/openshift/installer/pkg/version.Commit=5ddbd9c9f44c99dd34beecec77e2030c2b3a17af -X github.com/openshift/installer/pkg/version.defaultArch=amd64'

Here is a list of the backends:

aliyun slb DescribeLoadBalancerAttribute  --LoadBalancerId  lb-7goe73ixrje3z7n3kk4nf | jq '.BackendServers.BackendServer'
[]

Teardown logs

DEBUG Plan: 0 to add, 0 to change, 11 to destroy.  
DEBUG                                              
DEBUG Changes to Outputs:                          
DEBUG   - bootstrap_ip = "47.253.133.122" -> null  
DEBUG alicloud_ram_role_policy_attachment.attach: Destroying... [id=role:test-vnfj9-policy-bootstrap:Custom:test-vnfj9-role-bootstrap] 
DEBUG alicloud_oss_bucket_object.ignition_file: Destroying... [id=bootstrap.ign] 
DEBUG alicloud_security_group_rule.sg_rule_journald_gateway: Destroying... [id=sg-0xi53j1ca584zrf5syp3:ingress:tcp:19531/19531:intranet:0.0.0.0/0:accept:1] 
DEBUG alicloud_security_group_rule.sg_rule_ssh: Destroying... [id=sg-0xi53j1ca584zrf5syp3:ingress:tcp:22/22:intranet:0.0.0.0/0:accept:1] 
DEBUG alicloud_slb_backend_server.slb_attachment_bootstraps[1]: Destroying... [id=lb-7gorq6wu31bws0oupfi17] 
DEBUG alicloud_slb_backend_server.slb_attachment_bootstraps[0]: Destroying... [id=lb-7goe73ixrje3z7n3kk4nf] 
DEBUG alicloud_oss_bucket_object.ignition_file: Destruction complete after 1s 
DEBUG alicloud_oss_bucket.bucket: Destroying... [id=test-vnfj9-bootstrap] 
DEBUG alicloud_ram_role_policy_attachment.attach: Destruction complete after 2s 
DEBUG alicloud_ram_policy.role_policy: Destroying... [id=test-vnfj9-policy-bootstrap] 
DEBUG alicloud_slb_backend_server.slb_attachment_bootstraps[1]: Destruction complete after 3s 
DEBUG alicloud_security_group_rule.sg_rule_journald_gateway: Destruction complete after 3s 
DEBUG alicloud_slb_backend_server.slb_attachment_bootstraps[0]: Destruction complete after 3s 
DEBUG alicloud_instance.bootstrap: Destroying... [id=i-0xi2cd5lh2maubqqm0a7] 
DEBUG alicloud_ram_policy.role_policy: Destruction complete after 1s 
DEBUG alicloud_security_group_rule.sg_rule_ssh: Destruction complete after 4s 
DEBUG alicloud_oss_bucket.bucket: Destruction complete after 4s 
DEBUG alicloud_instance.bootstrap: Still destroying... [id=i-0xi2cd5lh2maubqqm0a7, 10s elapsed] 
DEBUG alicloud_instance.bootstrap: Destruction complete after 13s 
DEBUG alicloud_security_group.sg_bootstrap: Destroying... [id=sg-0xi53j1ca584zrf5syp3] 
DEBUG alicloud_ram_role.role: Destroying... [id=test-vnfj9-role-bootstrap] 
DEBUG alicloud_ram_role.role: Destruction complete after 1s 
DEBUG alicloud_security_group.sg_bootstrap: Still destroying... [id=sg-0xi53j1ca584zrf5syp3, 10s elapsed] 
DEBUG alicloud_security_group.sg_bootstrap: Destruction complete after 13s 
DEBUG                                              
DEBUG Warning: Value for undeclared variable       
DEBUG                                              
DEBUG The root module does not declare a variable named "control_plane_ips" but a 
DEBUG value was found in file                      
DEBUG "/tmp/openshift-install-bootstrap-3366187287/cluster.tfvars.json". If you 
DEBUG meant to use this value, add a "variable" block to the configuration. 
DEBUG                                              
DEBUG To silence these warnings, use TF_VAR_... environment variables to provide 
DEBUG certain "global" settings to all configurations in your organization. To 
DEBUG reduce the verbosity of these warnings, use the -compact-warnings option. 
DEBUG                                              
DEBUG Warning: Value for undeclared variable       
DEBUG                                              
DEBUG The root module does not declare a variable named "bootstrap_ip" but a value 
DEBUG was found in file                            
DEBUG "/tmp/openshift-install-bootstrap-3366187287/bootstrap.tfvars.json". If you 
DEBUG meant to use this value, add a "variable" block to the configuration. 
DEBUG                                              
DEBUG To silence these warnings, use TF_VAR_... environment variables to provide 
DEBUG certain "global" settings to all configurations in your organization. To 
DEBUG reduce the verbosity of these warnings, use the -compact-warnings option. 
DEBUG                                              
DEBUG Destroy complete! Resources: 11 destroyed.   
DEBUG Loading Install Config...                    
DEBUG   Loading SSH Key...                         
DEBUG   Loading Base Domain...                     
DEBUG     Loading Platform...                      
DEBUG   Loading Cluster Name...                    
DEBUG     Loading Base Domain...                   
DEBUG     Loading Platform...                      
DEBUG   Loading Networking...                      
DEBUG     Loading Platform...                      
DEBUG   Loading Pull Secret...                     
DEBUG   Loading Platform...                        
DEBUG Using Install Config loaded from state file  
INFO Waiting up to 40m0s (until 10:43AM) for the cluster at https://api.test.alicloud-dev.devcluster.openshift.com:6443 to initialize... 
W0317 10:03:32.740897 3218548 reflector.go:324] k8s.io/client-go/tools/watch/informerwatcher.go:146: failed to list *v1.ClusterVersion: Get "https://api.test.alicloud-dev.devcluster.openshift.com:6443/apis/config.openshift.io/v1/clusterversions?fieldSelector=metadata.name%3Dversion&limit=500&resourceVersion=0": dial tcp 47.253.133.98:6443: connect: connection refused
E0317 10:03:32.740951 3218548 reflector.go:138] k8s.io/client-go/tools/watch/informerwatcher.go:146: Failed to watch *v1.ClusterVersion: failed to list *v1.ClusterVersion: Get "https://api.test.alicloud-dev.devcluster.openshift.com:6443/apis/config.openshift.io/v1/clusterversions?fieldSelector=metadata.name%3Dversion&limit=500&resourceVersion=0": dial tcp 47.253.133.98:6443: connect: connection refused

I'm willing to test a v1.160.0 PR if you'd like to try it. I'm a little confused as to why this is a problem since this still works in 4.10.

@staebler
Copy link
Contributor Author

Unfortunately I'm still seeing this behavior.

Sorry, for the confusion. I did not mean to imply that the upgrade of the terraform provider would fix that problem. I am just trying to rectify the mistaken change in versions from 4.10 to 4.11.

@kwoodson
Copy link
Contributor

@staebler I'm supportive of this change. Moving back to the 1.158 sounds good to me. If you want to try moving forward I can test that as well.

@openshift-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 12, 2022
@sadasu
Copy link
Contributor

sadasu commented Jul 25, 2022

/remove-lifecycle stale

@openshift-ci openshift-ci bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 25, 2022
@sadasu
Copy link
Contributor

sadasu commented Aug 10, 2022

/lgtm

@sadasu
Copy link
Contributor

sadasu commented Aug 10, 2022

/retest-required

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 2bc06e1 and 6 for PR HEAD 5ddbd9c in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 2 against base HEAD 26611ff and 5 for PR HEAD 5ddbd9c in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 1 against base HEAD 26611ff and 4 for PR HEAD 5ddbd9c in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 26611ff and 3 for PR HEAD 5ddbd9c in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 2 against base HEAD fdd3902 and 2 for PR HEAD 5ddbd9c in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 1 against base HEAD fdd3902 and 1 for PR HEAD 5ddbd9c in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 2 against base HEAD 8e925f2 and 0 for PR HEAD 5ddbd9c in total

@openshift-ci-robot
Copy link
Contributor

/hold

Revision 5ddbd9c was retested 9 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 12, 2022
@sadasu
Copy link
Contributor

sadasu commented Aug 16, 2022

/test e2e-alibaba

@sadasu
Copy link
Contributor

sadasu commented Aug 16, 2022

/retest-required

2 similar comments
@sadasu
Copy link
Contributor

sadasu commented Aug 17, 2022

/retest-required

@sadasu
Copy link
Contributor

sadasu commented Aug 23, 2022

/retest-required

@sadasu
Copy link
Contributor

sadasu commented Aug 25, 2022

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 25, 2022
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 2 against base HEAD 1c8e79b and 8 for PR HEAD 5ddbd9c in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 1 against base HEAD 1c8e79b and 7 for PR HEAD 5ddbd9c in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 2 against base HEAD 070b006 and 6 for PR HEAD 5ddbd9c in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 2 against base HEAD 2867b6a and 5 for PR HEAD 5ddbd9c in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 1 against base HEAD 2867b6a and 4 for PR HEAD 5ddbd9c in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 2867b6a and 3 for PR HEAD 5ddbd9c in total

@sadasu
Copy link
Contributor

sadasu commented Aug 26, 2022

/skip e2e-metal-ipi-ovn-ipv6

@sadasu
Copy link
Contributor

sadasu commented Aug 26, 2022

/skip e2e-azure-upi

@sadasu
Copy link
Contributor

sadasu commented Aug 26, 2022

/test e2e-alibaba

@sadasu
Copy link
Contributor

sadasu commented Aug 26, 2022

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 26, 2022
@sadasu
Copy link
Contributor

sadasu commented Aug 26, 2022

/close

Latest version is now 1.182.0. Will upgrade to the latest when we see a need.

@openshift-ci openshift-ci bot closed this Aug 26, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 26, 2022

@sadasu: Closed this PR.

In response to this:

/close

Latest version is now 1.182.0. Will upgrade to the latest when we see a need.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 26, 2022

@staebler: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-single-node 5ddbd9c link false /test e2e-aws-single-node
ci/prow/e2e-metal-single-node-live-iso 5ddbd9c link false /test e2e-metal-single-node-live-iso
ci/prow/okd-e2e-aws-upgrade 5ddbd9c link false /test okd-e2e-aws-upgrade
ci/prow/e2e-crc 5ddbd9c link false /test e2e-crc
ci/prow/e2e-metal-ipi 5ddbd9c link false /test e2e-metal-ipi
ci/prow/e2e-metal-ipi-ovn-ipv6 5ddbd9c link true /test e2e-metal-ipi-ovn-ipv6

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants