Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vSphere: ignore bootstrap eagerly scrub changes #5848

Conversation

jcpowermac
Copy link
Contributor

The vsphere terraform provider has a long standing
bug if a disk parameter is changed underneath
terraform by vSphere the apply will fail.

This resolves reported issue:
#5830

The vsphere terraform provider has a long standing
bug if a disk parameter is changed underneath
terraform by vSphere the apply will fail.

This resolves reported issue:
openshift#5830
@jstuever
Copy link
Contributor

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 27, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jstuever

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 27, 2022
@jcpowermac
Copy link
Contributor Author

Watching CI it is past bootstrap (which is what I was concerned about)
I think this is good to go.

@patrickdillon
Copy link
Contributor

+1. LGTM. Holding off on the label because the CI job is not required, and want to wait and see if we need more.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 27, 2022

@jcpowermac: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-vsphere 8b4f7d8 link false /test e2e-vsphere

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jcpowermac
Copy link
Contributor Author

job failure unrelated to installation and PR.

@patrickdillon
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 27, 2022
@openshift-merge-robot openshift-merge-robot merged commit e70d4cd into openshift:master Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants