Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 2080219: OpenStack+Kuryr: Fix cluster destroy with BYON #5855

Merged
merged 2 commits into from May 12, 2022
Merged

Bug 2080219: OpenStack+Kuryr: Fix cluster destroy with BYON #5855

merged 2 commits into from May 12, 2022

Conversation

dulek
Copy link
Contributor

@dulek dulek commented Apr 29, 2022

This includes two backports that are required for cluster destroy with bring your own network mode to work. One backport comes from this BZ [1] and is related to FIPs and second one [2] makes sure all subnets are removed from the created router, not only tagged ones.

[1] https://bugzilla.redhat.com/show_bug.cgi?id=1924701
[2] https://bugzilla.redhat.com/show_bug.cgi?id=1940159

@MaysaMacedo @dulek
Fix FIP detach from Router
d1c5ab3 
During a FIP less installation VMs that were not
created by the installer can get a FIP detached when
the cluster in being destroyed. This commit fixes the
issue by detaching only FIPs that were created by
installer or Kuryr during a FIP less installation.
@MaysaMacedo @dulek
Fix Routers destroy with BYO
292dee5 
When using your own Network for the Machines
connected to a tagged Router created by CNO
on an installation with Kuryr, the Subnet of
that Network is not tagged and consequently
not identified by installer when destroying
the Router. This commit fixes the issue by
ensuring all Subnetes connected to a Router
created by Installer or CNO are removed.
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 29, 2022

@dulek: An error was encountered querying GitHub for users with public email (juriarte@redhat.com) for bug 2080219 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message. Post "http://ghproxy/graphql": dial tcp 172.30.229.2:80: connect: no route to host

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

Bug 2080219: OpenStack+Kuryr: Fix cluster destroy with BYON

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dulek
Copy link
Contributor Author

dulek commented Apr 29, 2022

/bugzilla refresh

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 29, 2022

@dulek: An error was encountered querying GitHub for users with public email (juriarte@redhat.com) for bug 2080219 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message. Post "http://ghproxy/graphql": dial tcp 172.30.229.2:80: connect: no route to host

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dulek
Copy link
Contributor Author

dulek commented Apr 29, 2022

/bugzilla refresh

@dulek
Copy link
Contributor Author

dulek commented Apr 29, 2022

@MaysaMacedo @pierreprinetti: Can you take a look?

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 29, 2022

@dulek: An error was encountered querying GitHub for users with public email (juriarte@redhat.com) for bug 2080219 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message. Post "http://ghproxy/graphql": dial tcp 172.30.229.2:80: connect: no route to host

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from Fedosin and mandre April 29, 2022 09:49
@MaysaMacedo
Copy link
Contributor

/lgtm
/hold for CI
/test e2e-openstack-kuryr

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 29, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 29, 2022

@MaysaMacedo: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test e2e-aws
  • /test e2e-azure-upi
  • /test e2e-metal-ipi
  • /test e2e-vsphere-upi
  • /test gofmt
  • /test golint
  • /test govet
  • /test images
  • /test shellcheck
  • /test tf-lint
  • /test unit
  • /test verify-codegen
  • /test verify-vendor
  • /test yaml-lint

The following commands are available to trigger optional jobs:

  • /test e2e-aws-disruptive
  • /test e2e-aws-fips
  • /test e2e-aws-proxy
  • /test e2e-aws-rhel8
  • /test e2e-aws-shared-vpc
  • /test e2e-aws-upgrade
  • /test e2e-aws-upi
  • /test e2e-aws-workers-rhel7
  • /test e2e-azure
  • /test e2e-azure-shared-vpc
  • /test e2e-crc
  • /test e2e-gcp
  • /test e2e-gcp-shared-vpc
  • /test e2e-gcp-upgrade
  • /test e2e-gcp-upi
  • /test e2e-gcp-upi-xpn
  • /test e2e-libvirt
  • /test e2e-metal
  • /test e2e-openstack
  • /test e2e-ovirt
  • /test e2e-vsphere
  • /test tf-fmt

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-installer-release-4.6-e2e-aws
  • pull-ci-openshift-installer-release-4.6-e2e-aws-fips
  • pull-ci-openshift-installer-release-4.6-e2e-aws-upgrade
  • pull-ci-openshift-installer-release-4.6-e2e-aws-workers-rhel7
  • pull-ci-openshift-installer-release-4.6-e2e-azure-upi
  • pull-ci-openshift-installer-release-4.6-e2e-libvirt
  • pull-ci-openshift-installer-release-4.6-e2e-metal-ipi
  • pull-ci-openshift-installer-release-4.6-e2e-openstack
  • pull-ci-openshift-installer-release-4.6-e2e-ovirt
  • pull-ci-openshift-installer-release-4.6-e2e-vsphere-upi
  • pull-ci-openshift-installer-release-4.6-gofmt
  • pull-ci-openshift-installer-release-4.6-golint
  • pull-ci-openshift-installer-release-4.6-govet
  • pull-ci-openshift-installer-release-4.6-images
  • pull-ci-openshift-installer-release-4.6-shellcheck
  • pull-ci-openshift-installer-release-4.6-tf-fmt
  • pull-ci-openshift-installer-release-4.6-tf-lint
  • pull-ci-openshift-installer-release-4.6-unit
  • pull-ci-openshift-installer-release-4.6-verify-codegen
  • pull-ci-openshift-installer-release-4.6-verify-vendor
  • pull-ci-openshift-installer-release-4.6-yaml-lint

In response to this:

/lgtm
/hold for CI
/test e2e-openstack-kuryr

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 29, 2022
@MaysaMacedo
Copy link
Contributor

ah, we don't have kuryr jobs in 4.6

@dulek
Copy link
Contributor Author

dulek commented Apr 29, 2022

/bugzilla refresh

@openshift-ci openshift-ci bot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Apr 29, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 29, 2022

@dulek: This pull request references Bugzilla bug 2080219, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.z) matches configured target release for branch (4.6.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 2066406 is in the state CLOSED (ERRATA), which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 2066406 targets the "4.7.z" release, which is one of the valid target releases: 4.7.0, 4.7.z
  • bug has dependents

Requesting review from QA contact:
/cc @eurijon

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Apr 29, 2022
@openshift-ci openshift-ci bot requested a review from eurijon April 29, 2022 11:40
@dulek
Copy link
Contributor Author

dulek commented May 4, 2022

/bugzilla refresh

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 4, 2022

@dulek: This pull request references Bugzilla bug 2080219, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.z) matches configured target release for branch (4.6.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 2066406 is in the state CLOSED (ERRATA), which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 2066406 targets the "4.7.z" release, which is one of the valid target releases: 4.7.0, 4.7.z
  • bug has dependents

Requesting review from QA contact:
/cc @eurijon

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dulek
Copy link
Contributor Author

dulek commented May 4, 2022

/retest-required

@dulek
Copy link
Contributor Author

dulek commented May 4, 2022

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 4, 2022
mandre
mandre reviewed May 10, 2022
View reviewed changes
Copy link
Member

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/label backport-risk-assessed
/approve
/retest

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label May 10, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 10, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mandre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 10, 2022
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

19 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@mandre
Copy link
Member

mandre commented May 12, 2022

e2e-azure-upi is permafailing, let's make the job optional with openshift/release#28515.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

5 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 12, 2022

@dulek: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-libvirt 292dee5 link false /test e2e-libvirt
ci/prow/e2e-azure-upi 292dee5 link true /test e2e-azure-upi

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot merged commit ee8de99 into openshift:release-4.6 May 12, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 12, 2022

@dulek: All pull requests linked via external trackers have merged:

Bugzilla bug 2080219 has been moved to the MODIFIED state.

In response to this:

Bug 2080219: OpenStack+Kuryr: Fix cluster destroy with BYON

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mandre mandre mandre left review comments

@Fedosin Fedosin Awaiting requested review from Fedosin

@eurijon eurijon Awaiting requested review from eurijon

Assignees

@eurijon eurijon

@MaysaMacedo MaysaMacedo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dulek @MaysaMacedo @openshift-bot @mandre @eurijon