Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.9] Bug 2087972: Set rc-manager=unmanaged for on-prem bootstrap #5926

Merged
merged 2 commits into from Jun 6, 2022
Merged

[release-4.9] Bug 2087972: Set rc-manager=unmanaged for on-prem bootstrap #5926

merged 2 commits into from Jun 6, 2022

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #5876

/assign cybertron

cybertron and others added 2 commits May 18, 2022 15:15
@cybertron
Set rc-manager=unmanaged for on-prem bootstrap
293b5ed 
There is a dispatcher script on the bootstrap node that is supposed
to be responsible for updating resolv.conf on network changes. We
don't want NetworkManager to step on those changes, so it needs to
be set to unmanaged. This is already the case on cluster nodes[0],
but apparently was missed in the bootstrap config.

0: https://github.com/openshift/machine-config-operator/blob/4b98289781ec5f3fe7313049496afda654f6e0fc/templates/common/on-prem/files/NetworkManager-onprem.conf.yaml#L7
(cherry picked from commit 95a2047)
@jcpowermac
vsphere upi: missing etc resolv
53d23f5 
Using rc-manager=unmanaged
for vsphere upi breaks the bootstrap
process since the RHCOS instance has
no `/etc/resolv.conf`

(cherry picked from commit 00683f1)
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 18, 2022
Merged
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 18, 2022

@openshift-cherrypick-robot: Bugzilla bug 2083335 has been cloned as Bugzilla bug 2087972. Retitling PR to link against new bug.
/retitle [release-4.9] Bug 2087972: Set rc-manager=unmanaged for on-prem bootstrap

In response to this:

[release-4.9] Bug 2083335: Set rc-manager=unmanaged for on-prem bootstrap

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot changed the title [release-4.9] Bug 2083335: Set rc-manager=unmanaged for on-prem bootstrap [release-4.9] Bug 2087972: Set rc-manager=unmanaged for on-prem bootstrap May 18, 2022
@openshift-ci openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels May 18, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 18, 2022

@openshift-cherrypick-robot: This pull request references Bugzilla bug 2087972, which is invalid:

  • expected dependent Bugzilla bug 2083335 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.9] Bug 2087972: Set rc-manager=unmanaged for on-prem bootstrap

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from EmilienM and eslutsky May 18, 2022 15:17
@sadasu
Copy link
Contributor

sadasu commented May 24, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 24, 2022
@openshift-bot
Copy link
Contributor

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 25, 2022

@openshift-bot: This pull request references Bugzilla bug 2087972, which is invalid:

  • expected dependent Bugzilla bug 2083335 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 26, 2022

@openshift-bot: This pull request references Bugzilla bug 2087972, which is invalid:

  • expected dependent Bugzilla bug 2083335 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 27, 2022

@openshift-bot: This pull request references Bugzilla bug 2087972, which is invalid:

  • expected dependent Bugzilla bug 2083335 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

@openshift-ci openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels May 28, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 28, 2022

@openshift-bot: This pull request references Bugzilla bug 2087972, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.z) matches configured target release for branch (4.9.z)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 2083335 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 2083335 targets the "4.10.z" release, which is one of the valid target releases: 4.10.0, 4.10.z
  • bug has dependents

Requesting review from QA contact:
/cc @jinyunma

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from jinyunma May 28, 2022 01:01
@gpei
Copy link
Contributor

gpei commented May 28, 2022

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label May 28, 2022
@patrickdillon
Copy link
Contributor

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 1, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 1, 2022
@patrickdillon
Copy link
Contributor

/retest-required

@patrickdillon
Copy link
Contributor

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Jun 3, 2022
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 2 against base HEAD 79ddfd2 and 8 for PR HEAD 53d23f5 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 1 against base HEAD 79ddfd2 and 7 for PR HEAD 53d23f5 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 79ddfd2 and 6 for PR HEAD 53d23f5 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 3, 2022 •
edited

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-openstack-kuryr 53d23f5 link false /test e2e-openstack-kuryr
ci/prow/okd-e2e-vsphere 53d23f5 link false /test okd-e2e-vsphere
ci/prow/e2e-crc 53d23f5 link false /test e2e-crc
ci/prow/e2e-ovirt 53d23f5 link false /test e2e-ovirt
ci/prow/e2e-aws-workers-rhel8 53d23f5 link false /test e2e-aws-workers-rhel8
ci/prow/e2e-aws-workers-rhel7 53d23f5 link false /test e2e-aws-workers-rhel7
ci/prow/e2e-metal-single-node-live-iso 53d23f5 link false /test e2e-metal-single-node-live-iso

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@cybertron
Copy link
Member

/test e2e-openstack
/test okd-images

@openshift-merge-robot openshift-merge-robot merged commit 14c7dda into openshift:release-4.9 Jun 6, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 6, 2022

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Bugzilla bug 2087972 has been moved to the MODIFIED state.

In response to this:

[release-4.9] Bug 2087972: Set rc-manager=unmanaged for on-prem bootstrap

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EmilienM EmilienM Awaiting requested review from EmilienM

@eslutsky eslutsky Awaiting requested review from eslutsky

@jinyunma jinyunma Awaiting requested review from jinyunma

Assignees

@cybertron cybertron

@sadasu sadasu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@openshift-cherrypick-robot @sadasu @openshift-bot @gpei @patrickdillon @openshift-ci-robot @cybertron @openshift-merge-robot @jcpowermac