WIP: AGENT-139: Get nmstate builtin

[celebdor]

No description provided.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign jhixson74 after the PR has been reviewed.
You can assign the PR to them by writing /assign @jhixson74 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[celebdor]

Still need to vendor the golang part

[patrickdillon]

Speaking with Toni on slack, I wanted to mention a few considerations:

1. Our builds are very iffy right now (failing frequently due to hitting the hour long timeout limit) after our terraform implementation. Each build builds the installer for 3 different architectures, and building and zipping each terraform provider takes a long time; this is why we are frequently hitting timeouts. This limitation needs to be considered and the pattern is not sustainable (long term).
2. It looks like some of the dependencies are not present in the builder image, so that would need to be worked out with ART.

/cc @jhixson74 who is working on profiling the installer build, but is out through early next week at a conference

[celebdor]

@patrickdillon couldn't the builds be separated per architecture to avoid that particular problem?

[patrickdillon]

@patrickdillon couldn't the builds be separated per architecture to avoid that particular problem?

I don't think so. Also I misspoke: for each architecture we're making three builds but it varies by os & arch: mac arm64, mac amd64, and linux amd64.

But this discussion and the links should give more context: https://coreos.slack.com/archives/C68TNFWA2/p1648044301526129

[bfournie]

I found that I needed to make this change to build.sh when building on rhel/Centos

-CGO_LDFLAGS="${CGO_LDFLAGS:--L${REPO_ROOT_DIR}/nmstate/rust/lib}"
+CGO_LDFLAGS="${CGO_LDFLAGS:--L${REPO_ROOT_DIR}/nmstate/rust/lib} -ldl -lrt"

[openshift-ci]

@celebdor: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@celebdor: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/verify-codegen	c0f9210	link	true	/test verify-codegen
ci/prow/golint	c0f9210	link	true	/test golint
ci/prow/e2e-agent-compact	c0f9210	link	true	/test e2e-agent-compact
ci/prow/unit	c0f9210	link	true	/test unit
ci/prow/gofmt	c0f9210	link	true	/test gofmt
ci/prow/govet	c0f9210	link	true	/test govet
ci/prow/verify-vendor	c0f9210	link	true	/test verify-vendor
ci/prow/images	c0f9210	link	true	/test images
ci/prow/e2e-aws	c0f9210	link	false	/test e2e-aws

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-bot]

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

[openshift-bot]

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

[openshift-bot]

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

[openshift-ci]

@openshift-bot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.