Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBMCloud: Pull in latest openshift/api changes #6056

Merged
merged 3 commits into from Aug 25, 2022
Merged

IBMCloud: Pull in latest openshift/api changes #6056

merged 3 commits into from Aug 25, 2022

Conversation

cjschaef
Copy link
Member

IBMCloud DNS support requires a change to PlatformStatus, which
is now available in the openshift/api.

@cjschaef cjschaef marked this pull request as ready for review June 29, 2022 15:18
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 29, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 29, 2022

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 29, 2022
@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 10, 2022
@cjschaef
Copy link
Member Author

/hold Need to rebase and rework go mod changes

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 14, 2022
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 14, 2022
@cjschaef
Copy link
Member Author

Having issues rebasing and trying to pull in these changes now.
Will continue to investigate why go mod is not updating the files and vendor as expected after rebasing off latest master

@cjschaef
Copy link
Member Author

/retest

@cjschaef
Copy link
Member Author

/retitle Bug 2094891: IBMCloud: Pull in latest openshift/api changes

@openshift-ci openshift-ci bot changed the title IBMCloud: Pull in latest openshift/api changes Bug 2094891: IBMCloud: Pull in latest openshift/api changes Jul 19, 2022
@openshift-ci openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jul 19, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 19, 2022

@cjschaef: This pull request references Bugzilla bug 2094891, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2094891: IBMCloud: Pull in latest openshift/api changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cjschaef
Copy link
Member Author

Some more overwhelmed CI workloads
state: waiting, reason: "CreateContainerError", message: "context deadline exceeded"

Will look at re-kicking the tests tomorrow hopefully.

@cjschaef
Copy link
Member Author

/retest required

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 21, 2022

@cjschaef: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

  • /test aro-unit
  • /test e2e-aws
  • /test e2e-aws-upi
  • /test e2e-azure
  • /test e2e-azure-upi
  • /test e2e-gcp
  • /test e2e-gcp-upi
  • /test e2e-metal-ipi-ovn-ipv6
  • /test e2e-vsphere
  • /test e2e-vsphere-upi
  • /test gofmt
  • /test golint
  • /test govet
  • /test images
  • /test okd-images
  • /test okd-unit
  • /test okd-verify-codegen
  • /test openstack-manifests
  • /test shellcheck
  • /test tf-lint
  • /test unit
  • /test verify-codegen
  • /test verify-vendor
  • /test yaml-lint

The following commands are available to trigger optional jobs:

  • /test e2e-alibaba
  • /test e2e-aws-disruptive
  • /test e2e-aws-fips
  • /test e2e-aws-imdsv2
  • /test e2e-aws-proxy
  • /test e2e-aws-shared-vpc
  • /test e2e-aws-single-node
  • /test e2e-aws-upgrade
  • /test e2e-aws-upi-proxy
  • /test e2e-aws-workers-rhel8
  • /test e2e-azure-resourcegroup
  • /test e2e-azure-shared-vpc
  • /test e2e-azurestack
  • /test e2e-azurestack-upi
  • /test e2e-crc
  • /test e2e-gcp-shared-vpc
  • /test e2e-gcp-upgrade
  • /test e2e-gcp-upi-xpn
  • /test e2e-ibmcloud
  • /test e2e-libvirt
  • /test e2e-metal
  • /test e2e-metal-assisted
  • /test e2e-metal-ipi
  • /test e2e-metal-ipi-ovn-dualstack
  • /test e2e-metal-ipi-swapped-hosts
  • /test e2e-metal-ipi-virtualmedia
  • /test e2e-metal-single-node-live-iso
  • /test e2e-nutanix
  • /test e2e-openstack
  • /test e2e-openstack-kuryr
  • /test e2e-openstack-parallel
  • /test e2e-openstack-proxy
  • /test e2e-openstack-upi
  • /test e2e-ovirt
  • /test e2e-vsphere-zones
  • /test okd-e2e-aws
  • /test okd-e2e-aws-upgrade
  • /test okd-e2e-gcp
  • /test okd-e2e-gcp-upgrade
  • /test okd-e2e-vsphere
  • /test tf-fmt

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-installer-master-aro-unit
  • pull-ci-openshift-installer-master-e2e-aws
  • pull-ci-openshift-installer-master-e2e-aws-fips
  • pull-ci-openshift-installer-master-e2e-aws-imdsv2
  • pull-ci-openshift-installer-master-e2e-aws-proxy
  • pull-ci-openshift-installer-master-e2e-aws-shared-vpc
  • pull-ci-openshift-installer-master-e2e-aws-single-node
  • pull-ci-openshift-installer-master-e2e-azure
  • pull-ci-openshift-installer-master-e2e-azure-resourcegroup
  • pull-ci-openshift-installer-master-e2e-azure-shared-vpc
  • pull-ci-openshift-installer-master-e2e-azurestack
  • pull-ci-openshift-installer-master-e2e-gcp
  • pull-ci-openshift-installer-master-e2e-ibmcloud
  • pull-ci-openshift-installer-master-e2e-libvirt
  • pull-ci-openshift-installer-master-e2e-metal-assisted
  • pull-ci-openshift-installer-master-e2e-metal-ipi
  • pull-ci-openshift-installer-master-e2e-openstack
  • pull-ci-openshift-installer-master-e2e-ovirt
  • pull-ci-openshift-installer-master-e2e-vsphere
  • pull-ci-openshift-installer-master-gofmt
  • pull-ci-openshift-installer-master-golint
  • pull-ci-openshift-installer-master-govet
  • pull-ci-openshift-installer-master-images
  • pull-ci-openshift-installer-master-okd-e2e-aws
  • pull-ci-openshift-installer-master-okd-images
  • pull-ci-openshift-installer-master-okd-unit
  • pull-ci-openshift-installer-master-okd-verify-codegen
  • pull-ci-openshift-installer-master-shellcheck
  • pull-ci-openshift-installer-master-tf-fmt
  • pull-ci-openshift-installer-master-tf-lint
  • pull-ci-openshift-installer-master-unit
  • pull-ci-openshift-installer-master-verify-codegen
  • pull-ci-openshift-installer-master-verify-vendor
  • pull-ci-openshift-installer-master-yaml-lint

In response to this:

/retest required

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cjschaef
Copy link
Member Author

/retest-required

1 similar comment
@jeffnowicki
Copy link
Contributor

/retest-required

@cjschaef
Copy link
Member Author

I've opened a separate PR to update the Kubernetes components first (required for kube-openapi update)
#6165

Then can rebase and rework this PR to pull in the openshift/api changes for IBM Cloud DNS CRN support (installconfig.platform.ibmcloud.platformstatus.dnsInstanceCRN)

@cjschaef
Copy link
Member Author

#6165 has merged, will rebase and resolve conflicts to pull in new openshift/api changes.

@cjschaef
Bug 2094891: IBMCloud: openshift/api go vendor update
9b3dc81 
IBMCloud DNS support requires a change to PlatformStatus, which
is now available in the openshift/api. Updating go vendor with
latest api content.
@cjschaef
Bug 2094891: IBMCloud: openshift/api installconfig
be7fca7 
IBMCloud DNS support requires a change to PlatformStatus, which
is now available in the openshift/api. Updating installconfigs
CRD for latest api content.
MayXuQQ
MayXuQQ reviewed Aug 23, 2022
View reviewed changes
Copy link
Contributor

@MayXuQQ MayXuQQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

skip review, will check with feature

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 23, 2022
@r4f4
Copy link
Contributor

r4f4 commented Aug 23, 2022

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 23, 2022
@jeffnowicki
Copy link
Contributor

/retest

@r4f4
Copy link
Contributor

r4f4 commented Aug 23, 2022

/test e2e-ibmcloud

@r4f4
Copy link
Contributor

r4f4 commented Aug 23, 2022

/test okd-images

@r4f4 r4f4 mentioned this pull request Aug 24, 2022
Closed
@r4f4
Copy link
Contributor

r4f4 commented Aug 24, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 24, 2022
@r4f4 r4f4 removed their assignment Aug 24, 2022
@r4f4
Copy link
Contributor

r4f4 commented Aug 24, 2022

/uncc @AnnaZivkovic
/uncc @rna-afk

@r4f4
Copy link
Contributor

r4f4 commented Aug 24, 2022

/test e2e-azure
/test okd-e2e-aws

@barbacbd
Copy link
Contributor

/test e2e-aws-fips
/test e2e-aws-imdsv2
/test e2e-aws-proxy
/test e2e-aws-shared-vpc
/test e2e-azure-shared-vpc
/test e2e-azurestack
/test e2e-libvirt
/test e2e-metal-assisted
/test e2e-openstack
/test e2e-ovirt
/test okd-e2e-aws

@cjschaef
Copy link
Member Author

cjschaef commented Aug 24, 2022 •
edited

I investigated the e2e-ibmcloud failure, and it appears to be an issue with the IBM CSI driver. I plan to open a Jira Bug for that issue.
https://issues.redhat.com/browse/OCPBUGS-539

Otherwise, attempting to retrigger pod timeouts.

/retest

@cjschaef
Copy link
Member Author

/retest

@rvanderp3
Copy link
Contributor

/test okd-e2e-aws

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 24, 2022

@rvanderp3: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test aro-unit
  • /test e2e-aws
  • /test e2e-aws-upi
  • /test e2e-azure
  • /test e2e-azure-upi
  • /test e2e-gcp
  • /test e2e-gcp-upi
  • /test e2e-metal-ipi-ovn-ipv6
  • /test e2e-vsphere
  • /test e2e-vsphere-upi
  • /test gofmt
  • /test golint
  • /test govet
  • /test images
  • /test okd-images
  • /test okd-unit
  • /test okd-verify-codegen
  • /test openstack-manifests
  • /test shellcheck
  • /test tf-lint
  • /test unit
  • /test verify-codegen
  • /test verify-vendor
  • /test yaml-lint

The following commands are available to trigger optional jobs:

  • /test e2e-alibaba
  • /test e2e-aws-disruptive
  • /test e2e-aws-fips
  • /test e2e-aws-imdsv2
  • /test e2e-aws-proxy
  • /test e2e-aws-shared-vpc
  • /test e2e-aws-single-node
  • /test e2e-aws-upgrade
  • /test e2e-aws-upi-proxy
  • /test e2e-aws-workers-rhel8
  • /test e2e-azure-resourcegroup
  • /test e2e-azure-shared-vpc
  • /test e2e-azurestack
  • /test e2e-azurestack-upi
  • /test e2e-crc
  • /test e2e-gcp-shared-vpc
  • /test e2e-gcp-upgrade
  • /test e2e-gcp-upi-xpn
  • /test e2e-ibmcloud
  • /test e2e-libvirt
  • /test e2e-metal-assisted
  • /test e2e-metal-ipi
  • /test e2e-metal-ipi-ovn-dualstack
  • /test e2e-metal-ipi-swapped-hosts
  • /test e2e-metal-ipi-virtualmedia
  • /test e2e-metal-single-node-live-iso
  • /test e2e-nutanix
  • /test e2e-openstack
  • /test e2e-openstack-kuryr
  • /test e2e-openstack-parallel
  • /test e2e-openstack-proxy
  • /test e2e-openstack-upi
  • /test e2e-ovirt
  • /test e2e-vsphere-zones
  • /test okd-e2e-aws-ovn
  • /test okd-e2e-aws-upgrade
  • /test okd-e2e-gcp
  • /test okd-e2e-gcp-upgrade
  • /test okd-e2e-vsphere
  • /test tf-fmt

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-installer-master-aro-unit
  • pull-ci-openshift-installer-master-e2e-aws
  • pull-ci-openshift-installer-master-e2e-aws-fips
  • pull-ci-openshift-installer-master-e2e-aws-imdsv2
  • pull-ci-openshift-installer-master-e2e-aws-proxy
  • pull-ci-openshift-installer-master-e2e-aws-shared-vpc
  • pull-ci-openshift-installer-master-e2e-aws-single-node
  • pull-ci-openshift-installer-master-e2e-azure
  • pull-ci-openshift-installer-master-e2e-azure-resourcegroup
  • pull-ci-openshift-installer-master-e2e-azure-shared-vpc
  • pull-ci-openshift-installer-master-e2e-azurestack
  • pull-ci-openshift-installer-master-e2e-gcp
  • pull-ci-openshift-installer-master-e2e-ibmcloud
  • pull-ci-openshift-installer-master-e2e-libvirt
  • pull-ci-openshift-installer-master-e2e-metal-assisted
  • pull-ci-openshift-installer-master-e2e-metal-ipi
  • pull-ci-openshift-installer-master-e2e-openstack
  • pull-ci-openshift-installer-master-e2e-ovirt
  • pull-ci-openshift-installer-master-e2e-vsphere
  • pull-ci-openshift-installer-master-gofmt
  • pull-ci-openshift-installer-master-golint
  • pull-ci-openshift-installer-master-govet
  • pull-ci-openshift-installer-master-images
  • pull-ci-openshift-installer-master-okd-e2e-aws-ovn
  • pull-ci-openshift-installer-master-okd-images
  • pull-ci-openshift-installer-master-okd-unit
  • pull-ci-openshift-installer-master-okd-verify-codegen
  • pull-ci-openshift-installer-master-shellcheck
  • pull-ci-openshift-installer-master-tf-fmt
  • pull-ci-openshift-installer-master-tf-lint
  • pull-ci-openshift-installer-master-unit
  • pull-ci-openshift-installer-master-verify-codegen
  • pull-ci-openshift-installer-master-verify-vendor
  • pull-ci-openshift-installer-master-yaml-lint

In response to this:

/test okd-e2e-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@r4f4
Copy link
Contributor

r4f4 commented Aug 24, 2022

I see the main cloud providers passed the tests e2e-(azure, aws, gcp, metal-ipi, vsphere, ovirt). I think that could be enough proof the openshift/api bump is not causing problems. I think it's pointless to keep retrying tests, so after the current run we could consider skipping/overriding them.

@patrickdillon
Copy link
Contributor

/skip

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 25, 2022

@cjschaef: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-e2e-aws-ovn be7fca7 link false /test okd-e2e-aws-ovn
ci/prow/e2e-libvirt be7fca7 link false /test e2e-libvirt
ci/prow/e2e-azurestack be7fca7 link false /test e2e-azurestack
ci/prow/e2e-openstack be7fca7 link false /test e2e-openstack
ci/prow/e2e-aws-fips be7fca7 link false /test e2e-aws-fips
ci/prow/e2e-aws-proxy be7fca7 link false /test e2e-aws-proxy

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit a556a89 into openshift:master Aug 25, 2022
@r4f4 r4f4 mentioned this pull request Aug 25, 2022
Closed
@cjschaef cjschaef deleted the api_update branch August 25, 2022 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MayXuQQ MayXuQQ MayXuQQ requested changes

@jstuever jstuever Awaiting requested review from jstuever

@patrickdillon patrickdillon Awaiting requested review from patrickdillon

@rvanderp3 rvanderp3 Awaiting requested review from rvanderp3

@barbacbd barbacbd Awaiting requested review from barbacbd

Assignees

@patrickdillon patrickdillon

@barbacbd barbacbd

@jstuever jstuever

@rvanderp3 rvanderp3

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet