Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBMCloud: BYON Enablement - SG Rule Cleanup #6143

Merged
merged 1 commit into from Jul 27, 2022
Merged

IBMCloud: BYON Enablement - SG Rule Cleanup #6143

merged 1 commit into from Jul 27, 2022

Conversation

cjschaef
Copy link
Member

Setup enablement for Bring Your Own Network support on IBM Cloud
using IPI. This portion focuses on handling cleanup of IPI created
SecurityGroups, and their SecurityGroupRules, which must be
deleted first due to cross-SG reference. Otherwise, SG's and their
SGRules get deleted with the VPC.

@openshift-ci openshift-ci bot requested review from jstuever and rna-afk July 20, 2022 15:22
@cjschaef
IBMCloud: BYON Enablement - SG Rule Cleanup
81c50e9 
Setup enablement for Bring Your Own Network support on IBM Cloud
using IPI. This portion focuses on handling cleanup of IPI created
SecurityGroups, and their SecurityGroupRules, which must be
deleted first due to cross-SG reference. Otherwise, SG's and their
SGRules get deleted with the VPC.
@cjschaef cjschaef force-pushed the ibmcloud_byon_sg_rule_deletion branch from e1dba60 to 81c50e9 Compare July 20, 2022 16:24
@cjschaef
Copy link
Member Author

CI is still flaky

Test started today at 11:49 AM passed after 6m10s. ([more info](https://prow.ci.openshift.org/spyglass/lens/metadata/iframe?req=%7B%22artifacts%22%3A%5B%22finished.json%22%2C%22podinfo.json%22%2C%22prowjob.json%22%2C%22started.json%22%5D%2C%22index%22%3A0%2C%22src%22%3A%22gs%2Forigin-ci-test%2Fpr-logs%2Fpull%2Fopenshift_installer%2F6143%2Fpull-ci-openshift-installer-master-yaml-lint%2F1549792493497749504%22%7D&topURL=https%3A//prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_installer/6143/pull-ci-openshift-installer-master-yaml-lint/1549792493497749504&lensIndex=0#))

Job execution failed: Pod pending timeout.

Will rekick tests in a bit

@jeffnowicki
Copy link
Contributor

/retest

@cjschaef
Copy link
Member Author

/retest-required

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 21, 2022

@cjschaef: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-ibmcloud 81c50e9 link false /test e2e-ibmcloud

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jeffnowicki
Copy link
Contributor

/cc @rvanderp3

@openshift-ci openshift-ci bot requested a review from rvanderp3 July 25, 2022 17:31
@rvanderp3
Copy link
Contributor

/lgtm
/assign @patrickdillon

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 25, 2022
@patrickdillon
Copy link
Contributor

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 25, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 25, 2022
@jeffnowicki
Copy link
Contributor

/retest-required

@jeffnowicki
Copy link
Contributor

/test e2e-aws

@openshift-merge-robot openshift-merge-robot merged commit ffdbc85 into openshift:master Jul 27, 2022
@cjschaef cjschaef deleted the ibmcloud_byon_sg_rule_deletion branch July 27, 2022 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jstuever jstuever Awaiting requested review from jstuever

@rna-afk rna-afk Awaiting requested review from rna-afk

@rvanderp3 rvanderp3 Awaiting requested review from rvanderp3

Assignees

@patrickdillon patrickdillon

@rvanderp3 rvanderp3

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@cjschaef @jeffnowicki @rvanderp3 @patrickdillon @openshift-merge-robot