AGENT-161: install-config validations for agent installer #6193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pawanpinjarkar
force-pushed
the
config-validations
branch
from
4affdd0
to
3bfc277
Compare
bfournie
reviewed
Aug 2, 2022
pawanpinjarkar
force-pushed
the
config-validations
branch
from
3bfc277
to
406b811
Compare
pawanpinjarkar
force-pushed
the
config-validations
branch
from
406b811
to
3e9df2a
Compare
rwsu
suggested changes
Aug 3, 2022
pawanpinjarkar
force-pushed
the
config-validations
branch
from
3e9df2a
to
3252f05
Compare
|
/lgtm |
|
/test unit |
1 similar comment
|
/test unit |
|
/approve Worked for me when I tested it locally. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lranjbar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@pawanpinjarkar: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be able to validate the install-config.yaml as per agent installer requirements,
the install-config is first loaded early in the agent installer OptionalInstallConfig.
Then, the following validations are performed if the loaded file is valid YAML.
e.g.
invalid install-config configuration: Platform: Unsupported value: "aws": supported values: "baremetal", "vsphere", "none"e.g.
invalid install-config configuration: Platform.Baremetal.ApiVip: Required value: ApiVip must be set for baremetal platforminvalid install-config configuration: Platform.VSphere.IngressVip: Required value: IngressVip must be set for vsphere platformthe total number of worker replicas should be 0
e.g.
invalid install-config configuration: [ControlPlane.Replicas: Required value: control plane replicas must be 1 for none platform. Found 3, Compute.Replicas: Required value: total number of worker replicas must be 0 for none platform. Found 2]Once these agent installer specific validations are passed, we rely on the usual generic validations offered by installer repo for
pkg/asset/installconfig/installconfig.go