[WIP] AGENT: Fix releaseImageMirror formatting #6272
Conversation
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
When the image is of the form:
quay.io/openshift-release-dev/ocp-release@sha256:300bce8246cf880e792e106607925de0a404484637627edf5f517375517d54a4
Splitting by ':' means that the extracted location will be:
quay.io/openshift-release-dev/ocp-release@sha256:
Instead of
quay.io/openshift-release-dev/ocp-release
Whereas in registries.conf we'd have the location be:
[[registry]]
location = "quay.io/openshift-release-dev/ocp-release"
Thus. There wouldn't be a match and the release image will be empty in
places like:
/usr/local/share/assisted-service/assisted-service.env
or
/etc/systemd/system/create-cluster-and-infraenv.service
Signed-off-by: Antoni Segura Puimedon <antoni@redhat.com>
celebdor
force-pushed
the
agent-sha-releaseImageMirror-fix
branch
from
a0e932f
to
863cd1e
Compare
|
@celebdor: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm |
Based on openshift#6272, this fixes the mirror generation to handle release images that include the sha256 checksum, e.g: quay.io/openshift-release-dev/ocp-release@sha256:300bce8246cf880e792e106607925de0a404484637627edf5f517375517d54a4
|
/close |
|
@zaneb: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
When the image is of the form:
Splitting by ':' means that the extracted location will be:
Instead of
Whereas in registries.conf we'd have the location be:
Thus. There wouldn't be a match and the release image will be empty in
places like:
or
Signed-off-by: Antoni Segura Puimedon antoni@redhat.com