Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

powervs-delete-named-dhcp #6365

Merged
merged 1 commit into from Sep 22, 2022
Merged

powervs-delete-named-dhcp #6365

merged 1 commit into from Sep 22, 2022

Conversation

hamzy
Copy link
Contributor

@hamzy hamzy commented Sep 16, 2022

Delete named DHCP service for PowerVS

The DHCP service went from:
DHCPSERVER2dc32880758344f08c8ff6933e87d27a_Private to:
DHCPSERVERrdr-maocp-lon06-hszgr_Private
in order to support multiple clusters in a zone. Therefore, we need to delete only a specific DHCP service.

@hamzy
powervs-delete-named-dhcp
5cbd4bd 
Delete named DHCP service for PowerVS

The DHCP service went from:
DHCPSERVER2dc32880758344f08c8ff6933e87d27a_Private
to:
DHCPSERVERrdr-maocp-lon06-hszgr_Private
in order to support multiple clusters in a zone.  Therefore,
we need to delete only a specific DHCP service.
@clnperez
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 16, 2022
@clnperez
Copy link
Contributor

@rna-afk can we get an approve?

@rna-afk
Copy link
Contributor

rna-afk commented Sep 21, 2022

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 21, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rna-afk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 21, 2022
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 9b0831e and 2 for PR HEAD 5cbd4bd in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 21, 2022 •
edited

@hamzy: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-e2e-aws-ovn 5cbd4bd link false /test okd-e2e-aws-ovn
ci/prow/okd-e2e-gcp-ovn-upgrade 5cbd4bd link false /test okd-e2e-gcp-ovn-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rna-afk
Copy link
Contributor

rna-afk commented Sep 21, 2022

/skip

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 9a1d2b7 and 1 for PR HEAD 5cbd4bd in total

@openshift-merge-robot openshift-merge-robot merged commit 78ec785 into openshift:master Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jstuever jstuever Awaiting requested review from jstuever

@rna-afk rna-afk Awaiting requested review from rna-afk

Assignees

@clnperez clnperez

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@hamzy @clnperez @rna-afk @openshift-ci-robot @openshift-merge-robot