Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SPLAT-846: enable static IPs for bootstrap and control plane nodes #6512

Closed
wants to merge 1 commit into from
Closed

SPLAT-846: enable static IPs for bootstrap and control plane nodes #6512

wants to merge 1 commit into from

Conversation

rvanderp3
Copy link
Contributor

@rvanderp3 rvanderp3 commented Oct 21, 2022 •
edited

This PR propagates IP configuration to nodes via the guestinfo.afterburn.initrd.network-kargs extra config property.

This PR depends on #6982

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 21, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 21, 2022

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 10, 2022
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 16, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 16, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign barbacbd for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rvanderp3 rvanderp3 changed the title [WIP] prototype: enable static IPs for bootstrap and control plane nodes SPLAT-846: enable static IPs for bootstrap and control plane nodes Mar 20, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 20, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 20, 2023 •
edited by openshift-ci bot

@rvanderp3: This pull request references SPLAT-846 which is a valid jira issue.

In response to this:

This PR propagates IP configuration to nodes via the guestinfo.afterburn.initrd.network-kargs extra config property.

This PR depends on #6982

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rvanderp3 rvanderp3 marked this pull request as ready for review May 17, 2023 20:45
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 17, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 17, 2023

@rvanderp3: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-agent-compact-ipv4 27618ae link true /test e2e-agent-compact-ipv4
ci/prow/agent-integration-tests 27618ae link true /test agent-integration-tests
ci/prow/aro-unit 009090c link true /test aro-unit
ci/prow/e2e-vsphere-ovn 009090c link true /test e2e-vsphere-ovn
ci/prow/okd-e2e-aws-ovn-upgrade 009090c link false /test okd-e2e-aws-ovn-upgrade
ci/prow/gofmt 009090c link true /test gofmt
ci/prow/e2e-aws-ovn 009090c link true /test e2e-aws-ovn
ci/prow/okd-images 009090c link true /test okd-images
ci/prow/tf-fmt 009090c link false /test tf-fmt
ci/prow/okd-e2e-aws-ovn 009090c link false /test okd-e2e-aws-ovn
ci/prow/images 009090c link true /test images
ci/prow/e2e-agent-ha-dualstack 009090c link false /test e2e-agent-ha-dualstack
ci/prow/govet 009090c link true /test govet
ci/prow/okd-scos-images 009090c link true /test okd-scos-images
ci/prow/okd-unit 009090c link true /test okd-unit
ci/prow/verify-codegen 009090c link true /test verify-codegen
ci/prow/okd-scos-e2e-aws-ovn 009090c link false /test okd-scos-e2e-aws-ovn
ci/prow/unit 009090c link true /test unit
ci/prow/okd-scos-verify-codegen 009090c link false /test okd-scos-verify-codegen
ci/prow/e2e-vsphere-zones 009090c link false /test e2e-vsphere-zones
ci/prow/okd-scos-unit 009090c link false /test okd-scos-unit
ci/prow/okd-verify-codegen 009090c link true /test okd-verify-codegen
ci/prow/golint 009090c link true /test golint

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jcpowermac
Copy link
Contributor

/assign jcpowermac

jcpowermac
jcpowermac reviewed May 23, 2023
View reviewed changes
data/data/vsphere/bootstrap/main.tf
@@ -41,7 +41,13 @@ resource "vsphere_virtual_machine" "vm_bootstrap" {
template_uuid = var.template[0].uuid
}

extra_config = {
extra_config = length(var.vsphere_bootstrap_network_kargs) > 0 ? {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need this branch

https://stackoverflow.com/questions/71157611/making-an-argument-optional-in-terraform-resource-block

Based on ^ it seems if its null then it won't be set.

@openshift-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 22, 2023
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 22, 2023
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Sep 21, 2023
@rvanderp3 rvanderp3 closed this Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcpowermac jcpowermac jcpowermac left review comments

@patrickdillon patrickdillon Awaiting requested review from patrickdillon

Assignees

@jcpowermac jcpowermac

Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@rvanderp3 @openshift-ci-robot @jcpowermac @openshift-bot @openshift-merge-robot