[release-4.11] OCPBUGS-4530: Enable CVO unmanage overrides in bootstrap-in-place installations #6668

omertuc · 2022-12-06T10:27:15Z

This is a manual cherry-pick of #6664

…tallations # Background openshift#5258 introduced a mechanism to tell CVO to not manage some cluster resources, as that management was creating races between bootkube and CVO. In openshift#5271, this mechanism was removed from bootstrap-in-place installations. The reason for the removal was because attempting to apply `original_cvo_overrides.patch` after the cluster-bootstrap podman container was done wasn't working, as in BIP by the time that that container is down, there's no longer a running kube-apiserver apply the patch on (unlike regular installations with a bootstrap node where the API server keeps running on the actual nodes). The justification for simply disabling the mechanism instead of finding a solution was based on an incorrect assumption that "CVO doesn't even run in BIP pre-pivot so there's no need to perform overrides anyway as there's no CVO to race with". # Issue Naturally, since CVO *is* actually running in the pre-pivot phase of bootstrap-in-place, not applying CVO overrides to disable the CVO management of bootkube-created resources led to the same races openshift#5258 was aiming to solve in bootstrap-in-place installations. One manifestation of that is OCPBUGS-4125. # Solution This commit re-introduces the mechanism that was originally introduced in openshift#5258 (and removed in openshift#5271). To solve the issue that motivated openshift#5271, this commit doesn't attempt to apply the `original_cvo_overrides.patch` in bootstrap-in-place pre-reboot, and instead will transfer `original_cvo_overrides.patch` through `master-update.fcc` to the post-pivot phase and the bootstrap-in-place post-reboot script will make sure to apply the patch after the API server is running again.

openshift-ci-robot · 2022-12-06T10:27:21Z

@omertuc: Jira Issue OCPBUGS-4506 has been cloned as Jira Issue OCPBUGS-4530. Retitling PR to link against new bug.
/retitle [release-4.11] OCPBUGS-4530: Enable CVO unmanage overrides in bootstrap-in-place installations

In response to this:

This is an automated cherry-pick of #6664

/assign omertuc

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2022-12-06T10:28:29Z

@omertuc: This pull request references Jira Issue OCPBUGS-4530, which is invalid:

expected dependent Jira Issue OCPBUGS-4506 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #6664

/assign omertuc

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2022-12-06T10:28:31Z

@omertuc: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

[release-4.11] OCPBUGS-4530: Enable CVO unmanage overrides in bootstrap-in-place installations

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2022-12-06T12:45:18Z

@omertuc: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

[release-4.11] OCPBUGS-4530: Enable CVO unmanage overrides in bootstrap-in-place installations

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2022-12-06T12:45:18Z

@omertuc: This pull request references Jira Issue OCPBUGS-4530, which is invalid:

expected dependent Jira Issue OCPBUGS-4506 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

This is a manual cherry-pick of #6664

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

patrickdillon · 2022-12-06T15:30:47Z

/jira-refresh
/approve
/label backport-risk-assessed

patrickdillon · 2022-12-06T15:31:56Z

/jira refresh
/lgtm

openshift-ci-robot · 2022-12-06T15:31:58Z

@patrickdillon: This pull request references Jira Issue OCPBUGS-4530, which is invalid:

expected dependent Jira Issue OCPBUGS-4506 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

patrickdillon · 2022-12-06T23:04:09Z

/skip
/retest-required

gpei · 2022-12-07T01:38:35Z

/label cherry-pick-approved

wking · 2022-12-07T20:00:16Z

/jira refresh

openshift-ci-robot · 2022-12-07T20:00:18Z

@wking: This pull request references Jira Issue OCPBUGS-4530, which is invalid:

expected dependent Jira Issue OCPBUGS-4506 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

chadcrum · 2022-12-09T14:27:20Z

/jira refresh

openshift-ci-robot · 2022-12-09T14:27:27Z

@chadcrum: This pull request references Jira Issue OCPBUGS-4530, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.11.z) matches configured target version for branch (4.11.z)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
dependent bug Jira Issue OCPBUGS-4506 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
dependent Jira Issue OCPBUGS-4506 targets the "4.12.0" version, which is one of the valid target versions: 4.12.0
bug has dependents

Requesting review from QA contact:
/cc @chadcrum

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

chadcrum

/lgtm

openshift-ci · 2022-12-09T14:39:01Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chadcrum, patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [patrickdillon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2022-12-09T15:38:32Z

/retest-required

Remaining retests: 0 against base HEAD 7e60d78 and 2 for PR HEAD 358c722 in total

openshift-ci · 2022-12-09T16:32:19Z

@omertuc: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-vsphere	`358c722`	link	false	`/test e2e-vsphere`
ci/prow/e2e-gcp	`358c722`	link	false	`/test e2e-gcp`
ci/prow/e2e-libvirt	`358c722`	link	false	`/test e2e-libvirt`
ci/prow/e2e-openstack	`358c722`	link	false	`/test e2e-openstack`
ci/prow/e2e-aws-upi-proxy	`358c722`	link	false	`/test e2e-aws-upi-proxy`
ci/prow/e2e-ibmcloud	`358c722`	link	false	`/test e2e-ibmcloud`
ci/prow/e2e-crc	`358c722`	link	false	`/test e2e-crc`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

omertuc · 2022-12-09T16:39:38Z

/test e2e-aws

openshift-ci-robot · 2022-12-09T18:57:21Z

@omertuc: All pull requests linked via external trackers have merged:

openshift/installer#6668

Jira Issue OCPBUGS-4530 has been moved to the MODIFIED state.

In response to this:

This is a manual cherry-pick of #6664

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

omertuc · 2023-01-31T21:22:49Z

/cherry-pick release-4.10

openshift-cherrypick-robot · 2023-01-31T21:24:48Z

@omertuc: new pull request created: #6819

In response to this:

/cherry-pick release-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci bot assigned omertuc Dec 6, 2022

openshift-ci bot changed the title ~~[release-4.11] OCPBUGS-4506: Enable CVO unmanage overrides in bootstrap-in-place installations~~ [release-4.11] OCPBUGS-4530: Enable CVO unmanage overrides in bootstrap-in-place installations Dec 6, 2022

openshift-ci-robot added the jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. label Dec 6, 2022

openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Dec 6, 2022

openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Dec 6, 2022

openshift-ci bot assigned patrickdillon Dec 6, 2022

openshift-ci bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. labels Dec 6, 2022

openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Dec 7, 2022

openshift-ci bot requested a review from chadcrum December 9, 2022 14:27

openshift-ci bot assigned chadcrum Dec 9, 2022

chadcrum approved these changes Dec 9, 2022

View reviewed changes

openshift-merge-robot merged commit 4bf477b into openshift:release-4.11 Dec 9, 2022

openshift-cherrypick-robot mentioned this pull request Jan 31, 2023

[release-4.10] OCPBUGS-6877: Enable CVO unmanage overrides in bootstrap-in-place installations #6819

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[release-4.11] OCPBUGS-4530: Enable CVO unmanage overrides in bootstrap-in-place installations #6668

[release-4.11] OCPBUGS-4530: Enable CVO unmanage overrides in bootstrap-in-place installations #6668

omertuc commented Dec 6, 2022 •

edited

openshift-ci-robot commented Dec 6, 2022

openshift-ci-robot commented Dec 6, 2022

openshift-ci bot commented Dec 6, 2022

openshift-ci bot commented Dec 6, 2022

openshift-ci-robot commented Dec 6, 2022

patrickdillon commented Dec 6, 2022

patrickdillon commented Dec 6, 2022

openshift-ci-robot commented Dec 6, 2022

patrickdillon commented Dec 6, 2022

gpei commented Dec 7, 2022

wking commented Dec 7, 2022

openshift-ci-robot commented Dec 7, 2022

chadcrum commented Dec 9, 2022

openshift-ci-robot commented Dec 9, 2022

chadcrum left a comment

openshift-ci bot commented Dec 9, 2022

openshift-ci-robot commented Dec 9, 2022

openshift-ci bot commented Dec 9, 2022 •

edited

omertuc commented Dec 9, 2022

openshift-ci-robot commented Dec 9, 2022

omertuc commented Jan 31, 2023

openshift-cherrypick-robot commented Jan 31, 2023

[release-4.11] OCPBUGS-4530: Enable CVO unmanage overrides in bootstrap-in-place installations #6668

[release-4.11] OCPBUGS-4530: Enable CVO unmanage overrides in bootstrap-in-place installations #6668

Conversation

omertuc commented Dec 6, 2022 • edited

openshift-ci-robot commented Dec 6, 2022

openshift-ci-robot commented Dec 6, 2022

openshift-ci bot commented Dec 6, 2022

openshift-ci bot commented Dec 6, 2022

openshift-ci-robot commented Dec 6, 2022

patrickdillon commented Dec 6, 2022

patrickdillon commented Dec 6, 2022

openshift-ci-robot commented Dec 6, 2022

patrickdillon commented Dec 6, 2022

gpei commented Dec 7, 2022

wking commented Dec 7, 2022

openshift-ci-robot commented Dec 7, 2022

chadcrum commented Dec 9, 2022

openshift-ci-robot commented Dec 9, 2022

chadcrum left a comment

Choose a reason for hiding this comment

openshift-ci bot commented Dec 9, 2022

openshift-ci-robot commented Dec 9, 2022

openshift-ci bot commented Dec 9, 2022 • edited

omertuc commented Dec 9, 2022

openshift-ci-robot commented Dec 9, 2022

omertuc commented Jan 31, 2023

openshift-cherrypick-robot commented Jan 31, 2023

omertuc commented Dec 6, 2022 •

edited

openshift-ci bot commented Dec 9, 2022 •

edited