[release-4.11] OCPBUGS-4405: UPI: Azure: create HyperV2 rhcos image

[r4f4]

Since HyperV support has been added to the installer, it now prefers the HyperV gen2 whenever the VM type selected supports it. This means that we need to upload both gen1 and gen2 RHCOS images to the storage account when doing UPI with MAO to avoid errors like:

5h2m Warning FailedCreate machine/$cluster_id-worker-northeurope1-f6kc4 InvalidConfiguration: failed to reconcile machine "$cluster_id-worker-northeurope1-f6kc4": failed to create vm $cluster_id-worker-northeurope1-f6kc4: failure sending request for machine $cluster_id-worker-northeurope1-f6kc4: cannot create vm: compute.VirtualMachinesClient#CreateOrUpdate: Failure sending request: StatusCode=404 - Original Error: Code="NotFound" Message="The Image '/subscriptions/$sub_id/resourceGroups/$rgroup-rg/providers/Microsoft.Compute/images/$cluster_id-gen2' cannot be found in 'northeurope' region."

[openshift-ci-robot]

@r4f4: This pull request references Jira Issue OCPBUGS-4405, which is invalid:

• expected the bug to target the "4.11.z" version, but it targets "4.13.0" instead
• expected Jira Issue OCPBUGS-4405 to depend on a bug targeting a version in 4.12.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Since HyperV support has been added to the installer, it now prefers the HyperV gen2 whenever the VM type selected supports it. This means that we need to upload both gen1 and gen2 RHCOS images to the storage account when doing UPI with MAO to avoid errors like:

5h2m Warning FailedCreate machine/$cluster_id-worker-northeurope1-f6kc4 InvalidConfiguration: failed to reconcile machine "$cluster_id-worker-northeurope1-f6kc4": failed to create vm $cluster_id-worker-northeurope1-f6kc4: failure sending request for machine $cluster_id-worker-northeurope1-f6kc4: cannot create vm: compute.VirtualMachinesClient#CreateOrUpdate: Failure sending request: StatusCode=404 - Original Error: Code="NotFound" Message="The Image '/subscriptions/$sub_id/resourceGroups/$rgroup-rg/providers/Microsoft.Compute/images/$cluster_id-gen2' cannot be found in 'northeurope' region."

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@r4f4: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

[release-4.11] OCPBUGS-4405: UPI: Azure: create HyperV2 rhcos image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[sdodson]

Overriding jira/valid-bug because the implementation in 4.12 was changed and doesn't suffer from this, nor would this specific code change be testable in 4.12.

[r4f4]

/cc @MayXuQQ

[patrickdillon]

/label backport-risk-assessed

[r4f4]

/test e2e-azure-upi

[gpei]

/label cherry-pick-approved

[r4f4]

/retest-required

[MayXuQQ]

/label qe-approved
test on 4.11 success 4.11.0-0.nightly-2022-12-08-022337
the update on 02_storage.json is OK

Running Command: az deployment group create --debug --name maxu-upi11_02_storage -g maxu-upi11-7tpsq-rg --template-file '/home/jenkins/ws/workspace/ocp-common/Flexy-install/flexy/private-templates/functionality-testing/aos-4_11/hosts/upi_on_azure-arm-templates/02_storage.json' --parameters vhdBlobURL='https://maxuupi11sa.blob.core.windows.net/maxu-upi11vhd/rhcos-411.86.202210041459-0-azure.x86_64.vhd' --parameters baseName='maxu-upi11-7tpsq' --parameters hyperVGeneration='V2'

$ oc get nodes
NAME STATUS ROLES AGE VERSION
maxu-upi11-7tpsq-master-0 Ready master 48m v1.24.6+5658434
maxu-upi11-7tpsq-master-1 Ready master 48m v1.24.6+5658434
maxu-upi11-7tpsq-master-2 Ready master 48m v1.24.6+5658434
maxu-upi11-7tpsq-worker-eastus-1 Ready worker 32m v1.24.6+5658434
maxu-upi11-7tpsq-worker-eastus-2 Ready worker 31m v1.24.6+5658434
maxu-upi11-7tpsq-worker-eastus3-frszd Ready worker 68s v1.24.6+5658434
$ oc get clusterVersion
NAME VERSION AVAILABLE PROGRESSING SINCE STATUS
version 4.11.0-0.nightly-2022-12-08-022337 True False 22m Cluster version is 4.11.0-0.nightly-2022-12-08-022337
$ oc get machines -A -o wide
NAMESPACE NAME PHASE TYPE REGION ZONE AGE NODE PROVIDERID STATE
openshift-machine-api maxu-upi11-7tpsq-worker-eastus3-frszd Running Standard_D4s_v3 eastus 3 8m55s maxu-upi11-7tpsq-worker-eastus3-frszd azure:///subscriptions/53b8f551-.../resourceGroups/maxu-upi11-7tpsq-rg/providers/Microsoft.Compute/virtualMachines/maxu-upi11-7tpsq-worker-eastus3-frszd Runnin

[r4f4]

/test e2e-azure-upi

[openshift-ci]

@r4f4: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-upi-proxy	3d94ff8	link	false	/test e2e-aws-upi-proxy
ci/prow/e2e-azurestack	3d94ff8	link	false	/test e2e-azurestack
ci/prow/e2e-azurestack-upi	3d94ff8	link	false	/test e2e-azurestack-upi
ci/prow/e2e-azure-resourcegroup	3d94ff8	link	false	/test e2e-azure-resourcegroup
ci/prow/e2e-azure-shared-vpc	3d94ff8	link	false	/test e2e-azure-shared-vpc
ci/prow/okd-e2e-aws	3d94ff8	link	false	/test okd-e2e-aws
ci/prow/e2e-azure-upi	3d94ff8	link	false	/test e2e-azure-upi

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[patrickdillon]

/approve
/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MayXuQQ, patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• upi/azure/OWNERS [patrickdillon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[sdodson]

/label bugzilla/valid-bug

[openshift-ci-robot]

@r4f4: All pull requests linked via external trackers have merged:

• openshift/installer#6681

Jira Issue OCPBUGS-4405 has been moved to the MODIFIED state.

In response to this:

Since HyperV support has been added to the installer, it now prefers the HyperV gen2 whenever the VM type selected supports it. This means that we need to upload both gen1 and gen2 RHCOS images to the storage account when doing UPI with MAO to avoid errors like:

5h2m Warning FailedCreate machine/$cluster_id-worker-northeurope1-f6kc4 InvalidConfiguration: failed to reconcile machine "$cluster_id-worker-northeurope1-f6kc4": failed to create vm $cluster_id-worker-northeurope1-f6kc4: failure sending request for machine $cluster_id-worker-northeurope1-f6kc4: cannot create vm: compute.VirtualMachinesClient#CreateOrUpdate: Failure sending request: StatusCode=404 - Original Error: Code="NotFound" Message="The Image '/subscriptions/$sub_id/resourceGroups/$rgroup-rg/providers/Microsoft.Compute/images/$cluster_id-gen2' cannot be found in 'northeurope' region."

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.