Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.11] OCPBUGS-4685: out-of-bounds read in golang.org/x/text/language leads to DoS #6685

Merged
merged 36 commits into from Jan 13, 2023
Merged

[release-4.11] OCPBUGS-4685: out-of-bounds read in golang.org/x/text/language leads to DoS #6685

merged 36 commits into from Jan 13, 2023

Conversation

r4f4
Copy link
Contributor

@r4f4 r4f4 commented Dec 9, 2022

Manual cherry-pick of #6650

@openshift-ci-robot openshift-ci-robot added the jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. label Dec 9, 2022
@openshift-ci-robot
Copy link
Contributor

@r4f4: This pull request references Jira Issue OCPBUGS-4685, which is invalid:

  • expected dependent Jira Issue OCPBUGS-4547 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Manual cherry-pick of #6650

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Dec 9, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 9, 2022

@r4f4: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

[release-4.11] OCPBUGS-4685: out-of-bounds read in golang.org/x/text/language leads to DoS

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@r4f4
OCPBUGS-4685: go.mod: fix out-of-bounds read in golang.org/x/text/lan…
a696ae5 
…guage
@r4f4
go.mod: vendor newer golang.org/x/text/language
be53eae
@r4f4
terraform: fix out-of-bounds read in golang.org/x/text/language
29237f2
@r4f4
terraform: vendor newer golang.org/x/text
bf4c218
@r4f4
terraform: alicloud: update golang.org/x/text
79a8542
@r4f4
terraform: alicloud: vendor newer golang.org/x/text
c80bb48
@r4f4
terraform: aws: update golang.org/x/text
d683aa4
@r4f4
terraform: aws: vendor newer golang.org/x/text
1f5504f
@r4f4
terraform: azurerm: update golang.org/x/text
a3a860f
@r4f4
terraform: azurerm: vendor newer golang.org/x/text
5860804
@r4f4
terraform: azurestack: update golang.org/x/text
72d905d
@r4f4
terraform: azurestack: vendor newer golang.org/x/text
5bd9d0e
@r4f4
terraform: google: update golang.org/x/text
6dd86bd
@r4f4
terraform: google: vendor newer golang.org/x/text
a42e95b
@r4f4
terraform: ibm: update golang.org/x/text
fb46c03
@r4f4
terraform: ibm: vendor newer golang.org/x/text
8be2e4a
@r4f4
terraform: ignition: update golang.org/x/text
9a719fa
@r4f4
terraform: ignition: vendor newer golang.org/x/text
74f81bd
@r4f4
terraform: ironic: update golang.org/x/text
266fcb1
@r4f4
terraform: ironic: vendor newer golang.org/x/text
247166c
@r4f4
terraform: libvirt: update golang.org/x/text
1f9b447
@r4f4
terraform: libvirt: vendor newer golang.org/x/text
7e1ca09
@r4f4
terraform: local: update golang.org/x/text
ad6295d
@r4f4
terraform: local: vendor newer golang.org/x/text
a1b8500
@r4f4 r4f4 force-pushed the cve-text-language-cherry-pick-4.11 branch from df57e33 to 698bf30 Compare December 9, 2022 16:23
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 9, 2022 •
edited

@r4f4: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-imdsv2 698bf30 link false /test e2e-aws-imdsv2
ci/prow/e2e-openstack-proxy 698bf30 link false /test e2e-openstack-proxy
ci/prow/e2e-gcp 698bf30 link false /test e2e-gcp
ci/prow/e2e-ibmcloud 698bf30 link false /test e2e-ibmcloud
ci/prow/e2e-aws-proxy 698bf30 link false /test e2e-aws-proxy
ci/prow/e2e-crc 698bf30 link false /test e2e-crc
ci/prow/e2e-aws-single-node 698bf30 link false /test e2e-aws-single-node
ci/prow/e2e-alibaba 698bf30 link false /test e2e-alibaba
ci/prow/e2e-aws-fips 698bf30 link false /test e2e-aws-fips
ci/prow/e2e-azurestack 698bf30 link false /test e2e-azurestack
ci/prow/e2e-libvirt 698bf30 link false /test e2e-libvirt
ci/prow/e2e-aws-upi-proxy 698bf30 link false /test e2e-aws-upi-proxy
ci/prow/e2e-aws-shared-vpc 698bf30 link false /test e2e-aws-shared-vpc

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@r4f4
Copy link
Contributor Author

r4f4 commented Jan 2, 2023

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jan 2, 2023
@openshift-ci-robot
Copy link
Contributor

@r4f4: This pull request references Jira Issue OCPBUGS-4685, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.11.z) matches configured target version for branch (4.11.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-4547 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
  • dependent Jira Issue OCPBUGS-4547 targets the "4.12.0" version, which is one of the valid target versions: 4.12.0
  • bug has dependents

Requesting review from QA contact:
/cc @gpei

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Jan 2, 2023
@openshift-ci openshift-ci bot requested a review from gpei January 2, 2023 13:48
@gpei
Copy link
Contributor

gpei commented Jan 3, 2023

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jan 3, 2023
@sadasu
Copy link
Contributor

sadasu commented Jan 4, 2023

/retest-required

@sadasu
Copy link
Contributor

sadasu commented Jan 4, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 4, 2023
@patrickdillon
Copy link
Contributor

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Jan 13, 2023
@patrickdillon
Copy link
Contributor

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 13, 2023
@openshift-merge-robot openshift-merge-robot merged commit b4cce37 into openshift:release-4.11 Jan 13, 2023
@openshift-ci-robot
Copy link
Contributor

@r4f4: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-4685 has been moved to the MODIFIED state.

In response to this:

Manual cherry-pick of #6650

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnnaZivkovic AnnaZivkovic Awaiting requested review from AnnaZivkovic

@eslutsky eslutsky Awaiting requested review from eslutsky

@gpei gpei Awaiting requested review from gpei

Assignees

@sadasu sadasu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@r4f4 @openshift-ci-robot @gpei @sadasu @patrickdillon @openshift-merge-robot