Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG 2110982: GCP skip public loadbalancer ip addresses #6755

Merged
merged 1 commit into from Jan 13, 2023

Conversation

barbacbd
Copy link
Contributor

@barbacbd barbacbd commented Jan 9, 2023

** There is no need to add the public load balancer IP addresses to firewall rules when the cluster is internal. ** The internal load balancer ip addresses will be present for internal and external cluster.

https://issues.redhat.com/browse/OCPBUGSM-47223

@openshift-ci openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jan 9, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 9, 2023

@barbacbd: This pull request references Bugzilla bug 2110982, which is invalid:

  • expected the bug to target the "4.13.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

BUG 2110982: GCP skip public loadbalancer ip addresses

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@barbacbd
Copy link
Contributor Author

/bugzilla refresh

@openshift-ci openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jan 10, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 10, 2023

@barbacbd: This pull request references Bugzilla bug 2110982, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.13.0) matches configured target release for branch (4.13.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @gpei

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from gpei January 10, 2023 12:59
** There is no need to add the public load balancer IP addresses to firewall rules when the cluster is internal.
** The internal load balancer ip addresses will be present for internal and external cluster.
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 10, 2023

@barbacbd: This pull request references Bugzilla bug 2110982, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.13.0) matches configured target release for branch (4.13.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @gpei

In response to this:

BUG 2110982: GCP skip public loadbalancer ip addresses

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@barbacbd
Copy link
Contributor Author

/retest

@gpei
Copy link
Contributor

gpei commented Jan 11, 2023

/bugzilla refresh

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 11, 2023

@gpei: This pull request references Bugzilla bug 2110982, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.13.0) matches configured target release for branch (4.13.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @jianli-wei

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@r4f4
Copy link
Contributor

r4f4 commented Jan 11, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 11, 2023
@r4f4 r4f4 removed their assignment Jan 11, 2023
@barbacbd
Copy link
Contributor Author

/test e2e-gcp-ovn

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 11, 2023

@barbacbd: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-vsphere-ovn b407cd5 link true /test e2e-vsphere-ovn
ci/prow/okd-scos-e2e-aws-upgrade 99f8378 link false /test okd-scos-e2e-aws-upgrade
ci/prow/e2e-aws-ovn-disruptive 99f8378 link false /test e2e-aws-ovn-disruptive
ci/prow/e2e-gcp-ovn-shared-vpc 99f8378 link false /test e2e-gcp-ovn-shared-vpc

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@barbacbd
Copy link
Contributor Author

/skip

@patrickdillon
Copy link
Contributor

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 12, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 12, 2023
@openshift-merge-robot openshift-merge-robot merged commit 960ebcf into openshift:master Jan 13, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 13, 2023

@barbacbd: All pull requests linked via external trackers have merged:

Bugzilla bug 2110982 has been moved to the MODIFIED state.

In response to this:

BUG 2110982: GCP skip public loadbalancer ip addresses

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants