Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GCP: Remove the BYOH code #6771

Merged
merged 1 commit into from Jan 21, 2023
Merged

GCP: Remove the BYOH code #6771

merged 1 commit into from Jan 21, 2023

Conversation

barbacbd
Copy link
Contributor

** If this is needed then it an always be added back. The gcp byoh code is causing bugs and isn't a requirement. It was added at the same time as the shared vpn code, and the two became entangled, but there was no need for the byoh code without a requirement.

CORS-2474

@barbacbd
Copy link
Contributor Author

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 13, 2023
@barbacbd
GCP: Remove the BYOH code
b48206d 
** If this is needed then it an always be added back. The gcp byoh code is causing bugs and
isn't a requirement. It was added at the same time as the shared vpn code, and the two became
entangled, but there was no need for the byoh code without a requirement.
@barbacbd
Copy link
Contributor Author

/test e2e-aws-ovn

@barbacbd
Copy link
Contributor Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 16, 2023
@barbacbd
Copy link
Contributor Author

/skip

r4f4
r4f4 reviewed Jan 16, 2023
View reviewed changes
Copy link
Contributor

@r4f4 r4f4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 16, 2023
@bscott-rh bscott-rh mentioned this pull request Jan 16, 2023
Merged
1 task
@sadasu
Copy link
Contributor

sadasu commented Jan 20, 2023

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sadasu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 20, 2023
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 3d92c1e and 2 for PR HEAD b48206d in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 7c387e7 and 1 for PR HEAD b48206d in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 20, 2023 •
edited

@barbacbd: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-workers-rhel8 b48206d link false /test e2e-aws-ovn-workers-rhel8
ci/prow/okd-scos-e2e-aws-ovn b48206d link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-aws-ovn-upgrade b48206d link false /test e2e-aws-ovn-upgrade
ci/prow/okd-e2e-aws-ovn-upgrade b48206d link false /test okd-e2e-aws-ovn-upgrade
ci/prow/e2e-gcp-ovn-shared-vpc b48206d link false /test e2e-gcp-ovn-shared-vpc
ci/prow/okd-scos-e2e-aws-upgrade b48206d link false /test okd-scos-e2e-aws-upgrade
ci/prow/e2e-aws-ovn-disruptive b48206d link false /test e2e-aws-ovn-disruptive

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 26ce7ce and 0 for PR HEAD b48206d in total

@openshift-merge-robot openshift-merge-robot merged commit 950ed9f into openshift:master Jan 21, 2023
@jianli-wei jianli-wei mentioned this pull request Jan 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r4f4 r4f4 r4f4 left review comments

@patrickdillon patrickdillon Awaiting requested review from patrickdillon

Assignees

@r4f4 r4f4

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@barbacbd @sadasu @openshift-ci-robot @r4f4 @openshift-merge-robot