Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AGENT-506: Copy additional files on startup #6794

Closed
wants to merge 1 commit into from
Closed

AGENT-506: Copy additional files on startup #6794

wants to merge 1 commit into from

Conversation

andfasano
Copy link
Contributor

@andfasano andfasano commented Jan 23, 2023 •
edited

This patch adds a new agent service responsible to extract and copy the required additional files from the agent ISO.

Requires #6786

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 23, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 23, 2023 •
edited by openshift-ci bot

@andfasano: This pull request references AGENT-506 which is a valid jira issue.

In response to this:

This patch adds a new agent service responsible to extract and copy the required additional files from the agent ISO.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 23, 2023 •
edited by openshift-ci bot

@andfasano: This pull request references AGENT-506 which is a valid jira issue.

In response to this:

This patch adds a new agent service responsible to extract and copy the required additional files from the agent ISO.

Requires #6786

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 23, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from andfasano by writing /assign @andfasano in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@andfasano andfasano force-pushed the agent-copy-iso-extra-binaries branch 2 times, most recently from af1a4ce to ce7c06f Compare January 23, 2023 17:44
rwsu
rwsu reviewed Jan 30, 2023
View reviewed changes
data/data/agent/systemd/units/agent-copy-iso-files.service Show resolved Hide resolved
data/data/agent/files/usr/local/bin/agent-copy-iso-files.sh
zcat /run/media/iso/images/ignition.img | cpio -idmv

# agent-tui is required by the agent-interactive-console.service
cp agent-tui /usr/local/bin/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is agent-tui already marked executable?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's my expectation when it will be extracted from the image where it's stored. I think the attribute should be preserved, if not we could add a chmod here

@andfasano andfasano force-pushed the agent-copy-iso-extra-binaries branch from ce7c06f to 7d56694 Compare February 2, 2023 10:14
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 2, 2023

@andfasano: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-secureboot 7d56694 link false /test e2e-gcp-secureboot
ci/prow/e2e-agent-sno-ipv6 7d56694 link false /test e2e-agent-sno-ipv6
ci/prow/e2e-aws-ovn-workers-rhel8 7d56694 link false /test e2e-aws-ovn-workers-rhel8
ci/prow/e2e-aws-ovn-upgrade 7d56694 link false /test e2e-aws-ovn-upgrade
ci/prow/e2e-aws-ovn 7d56694 link true /test e2e-aws-ovn
ci/prow/e2e-aws-ovn-disruptive 7d56694 link false /test e2e-aws-ovn-disruptive
ci/prow/e2e-vsphere-upi-zones 7d56694 link false /test e2e-vsphere-upi-zones

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

rwsu
rwsu reviewed Feb 3, 2023
View reviewed changes
Copy link
Contributor

@rwsu rwsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 3, 2023
@andfasano
Copy link
Contributor Author

/hold

testing another approach

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 8, 2023
@andfasano
Copy link
Contributor Author

Not required due #6842

@andfasano andfasano closed this Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwsu rwsu rwsu left review comments

@bfournie bfournie Awaiting requested review from bfournie

@lranjbar lranjbar Awaiting requested review from lranjbar

Assignees

@rwsu rwsu

Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@andfasano @openshift-ci-robot @rwsu