Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.12] OCPBUGS-8015: make VIP 168.63.129.16 noProxy in all clouds except Public #6909

Merged
merged 1 commit into from Mar 2, 2023
Merged

[release-4.12] OCPBUGS-8015: make VIP 168.63.129.16 noProxy in all clouds except Public #6909

merged 1 commit into from Mar 2, 2023

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #6761

/assign r4f4

@r4f4
OCPBUGS-5734: VIP 168.63.129.16 should be noProxy to all clouds excep…
593cb44 
…t Public

It was previously only added for StackCloud but it's also needed for all
national clouds.
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 28, 2023
Merged
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Jira Issue OCPBUGS-5734 has been cloned as Jira Issue OCPBUGS-8015. Retitling PR to link against new bug.
/retitle [release-4.12] OCPBUGS-8015: make VIP 168.63.129.16 noProxy in all clouds except Public

In response to this:

This is an automated cherry-pick of #6761

/assign r4f4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot changed the title [release-4.12] OCPBUGS-5734: make VIP 168.63.129.16 noProxy in all clouds except Public [release-4.12] OCPBUGS-8015: make VIP 168.63.129.16 noProxy in all clouds except Public Feb 28, 2023
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Feb 28, 2023
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-8015, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.12.z) matches configured target version for branch (4.12.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-5734 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
  • dependent Jira Issue OCPBUGS-5734 targets the "4.13.0" version, which is one of the valid target versions: 4.13.0
  • bug has dependents

Requesting review from QA contact:
/cc @gpei

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #6761

/assign r4f4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from gpei February 28, 2023 09:09
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 28, 2023

@openshift-cherrypick-robot: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Retaining the bugzilla/valid-bug label as it was manually added.

In response to this:

[release-4.12] OCPBUGS-8015: make VIP 168.63.129.16 noProxy in all clouds except Public

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from barbacbd and r4f4 February 28, 2023 09:12
@patrickdillon
Copy link
Contributor

/test e2e-azure-ovn

@patrickdillon
Copy link
Contributor

/approve
/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Feb 28, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 28, 2023
@r4f4
Copy link
Contributor

r4f4 commented Feb 28, 2023

Similar change being backported in cluster-network-operator: openshift/cluster-network-operator#1722

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 28, 2023 •
edited

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-disruptive 593cb44 link false /test e2e-aws-ovn-disruptive
ci/prow/e2e-crc 593cb44 link false /test e2e-crc
ci/prow/okd-scos-e2e-aws-ovn 593cb44 link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@gpei
Copy link
Contributor

gpei commented Mar 1, 2023

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Mar 1, 2023
barbacbd
barbacbd reviewed Mar 1, 2023
View reviewed changes
Copy link
Contributor

@barbacbd barbacbd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 1, 2023
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD fd9e75e and 2 for PR HEAD 593cb44 in total

@openshift-merge-robot openshift-merge-robot merged commit 50a7b8c into openshift:release-4.12 Mar 2, 2023
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-8015 has been moved to the MODIFIED state.

In response to this:

This is an automated cherry-pick of #6761

/assign r4f4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barbacbd barbacbd barbacbd left review comments

@gpei gpei Awaiting requested review from gpei

@r4f4 r4f4 Awaiting requested review from r4f4

Assignees

@r4f4 r4f4

@barbacbd barbacbd

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@openshift-cherrypick-robot @openshift-ci-robot @patrickdillon @r4f4 @gpei @barbacbd @openshift-merge-robot