openstack: document external LB #6920
Conversation
|
/skip |
|
/cc mandre |
|
|
||
| ## Common prerequisites | ||
|
|
||
| * When deploying OpenShift with an external load balancer, it's required to bring your own network(s) before |
There was a problem hiding this comment.
I don't think that's technically correct. As long as the LB has a route to get to the subnets where the nodes are deployed, it should be fine, right? In my understanding these subnets don't have to exist beforehand and we can let the IPI installer create the machineSubnet.
There was a problem hiding this comment.
This is questionable. With terraform-created networks, we don't have the control on the allocation pool for example, so this makes the LB config a bit more difficult I think.
I think we should recommend BYON for simplicity. Also because that's what we have been testing so far.
EmilienM
force-pushed
the
externallb-doc
branch
from
e08d4db
to
5938bdb
Compare
|
/skip |
EmilienM
requested review from
mandre
and removed request for
gryf and
stephenfin
EmilienM
force-pushed
the
externallb-doc
branch
from
5938bdb
to
cf8059c
Compare
|
/skip |
|
/lgtm |
|
|
||
| * `loadBalancer` is a new stanza created in OCP 4.13. The default type is `OpenShiftManagedDefault` (which will deploy HAproxy and Keepalived in OCP, known as the OpenShift managed load balancer). Setting it to `UserManaged` will allow an user managed load balancer to replace the OpenShift managed one. | ||
| * `machinesSubnet` is the subnet ID where both the OpenShift cluster and the user managed load balancer are deployed. | ||
| * `TechPreviewNoUpgrade` featureSet has to be enabled in OCP 4.13, since the feature was on TechPreview. To do that, just add `featureSet: TechPreviewNoUpgrade` into the install-config.yaml. |
There was a problem hiding this comment.
"was on TechPreview" sounds weird. Can we just say "is a Technology Preview feature in this version". I assume we'll update this when it's GA?
Also, format install-config.yaml as a literal
There was a problem hiding this comment.
Or alternatively:
In OCP 4.13 the feature had to be enabled as Technology Preview. This can be done by adding featureSet: TechPreviewNoUpgrade into the install-config.yaml.
And link to https://github.com/openshift/installer/blob/master/docs/user/customization.md#platform-customization
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: stephenfin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/lgtm |
|
|
||
| * `loadBalancer` is a new stanza created in OCP 4.13. The default type is `OpenShiftManagedDefault` (which will deploy HAproxy and Keepalived in OCP, known as the OpenShift managed load balancer). Setting it to `UserManaged` will allow an user managed load balancer to replace the OpenShift managed one. | ||
| * `machinesSubnet` is the subnet ID where both the OpenShift cluster and the user managed load balancer are deployed. | ||
| * `TechPreviewNoUpgrade` featureSet has to be enabled in OCP 4.13, since the feature was on TechPreview. To do that, just add `featureSet: TechPreviewNoUpgrade` into the install-config.yaml. |
There was a problem hiding this comment.
Or alternatively:
In OCP 4.13 the feature had to be enabled as Technology Preview. This can be done by adding featureSet: TechPreviewNoUpgrade into the install-config.yaml.
And link to https://github.com/openshift/installer/blob/master/docs/user/customization.md#platform-customization
EmilienM
force-pushed
the
externallb-doc
branch
2 times, most recently
from
85e7402
to
582c124
Compare
Co-authored-by: Martin André <martin.andre@gmail.com>
|
@EmilienM: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
First iteration to document external LB, when deploying OCP on OSP.