Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CFE-687: Apply user defined labels on created gcp resources #7153

Merged
merged 1 commit into from Aug 16, 2023
Merged

CFE-687: Apply user defined labels on created gcp resources #7153

merged 1 commit into from Aug 16, 2023

Conversation

bharath-b-rh
Copy link
Contributor

PR is for applying OCP default label ("kubernetes-io-cluster-${cluster_id}" = "owned") and user defined labels to all gcp resources created.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 2, 2023
@bharath-b-rh bharath-b-rh marked this pull request as draft May 2, 2023 06:49
barbacbd
barbacbd reviewed May 17, 2023
View reviewed changes
Copy link
Contributor

@barbacbd barbacbd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe that you can add the labels to the boot_disk in cluster/master/main.tf. Can we look into that one?

@bharath-b-rh
Copy link
Contributor Author

I believe that you can add the labels to the boot_disk in cluster/master/main.tf. Can we look into that one?

It's supported, I had missed it. Made the changes and tested it as well, will update the PR. Thank you!

@bharath-b-rh
Copy link
Contributor Author

/hold openshift/enhancements#1217

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 23, 2023
@bharath-b-rh bharath-b-rh force-pushed the cfe-687 branch 3 times, most recently from e3afb73 to 8170c3d Compare June 25, 2023 12:45
@bharath-b-rh bharath-b-rh force-pushed the cfe-687 branch 2 times, most recently from 3e96614 to ba29c68 Compare July 19, 2023 11:57
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 19, 2023
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 24, 2023
@jianli-wei
Copy link
Contributor

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Aug 4, 2023
@bharath-b-rh bharath-b-rh changed the title WIP : CFE-687 : Apply user defined labels on created gcp resources WIP : CFE-687: Apply user defined labels on created gcp resources Aug 9, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 9, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 9, 2023 •
edited by openshift-ci bot

@bharath-b-rh: This pull request references CFE-687 which is a valid jira issue.

In response to this:

PR is for applying OCP default label ("kubernetes-io-cluster-${cluster_id}" = "owned") and user defined labels to all gcp resources created.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bharath-b-rh
Copy link
Contributor Author

/emove-hold

@bharath-b-rh bharath-b-rh marked this pull request as ready for review August 9, 2023 12:05
@bharath-b-rh bharath-b-rh changed the title WIP : CFE-687: Apply user defined labels on created gcp resources CFE-687: Apply user defined labels on created gcp resources Aug 9, 2023
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 9, 2023
@bharath-b-rh
Copy link
Contributor Author

/remove-hold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 9, 2023
@openshift-ci openshift-ci bot requested a review from rwsu August 9, 2023 12:13
@bharath-b-rh
Copy link
Contributor Author

/hold #7126

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 9, 2023
@bharath-b-rh
Copy link
Contributor Author

/remove-hold

1 similar comment
@bharath-b-rh
Copy link
Contributor Author

/remove-hold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 15, 2023
@patrickdillon
Copy link
Contributor

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 15, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 15, 2023
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 8aff336 and 2 for PR HEAD 9b40d22 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 6e5a570 and 1 for PR HEAD 9b40d22 in total

@patrickdillon
Copy link
Contributor

/override ci/prow/okd-images
/skip

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 16, 2023

@patrickdillon: Overrode contexts on behalf of patrickdillon: ci/prow/okd-images

In response to this:

/override ci/prow/okd-images
/skip

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@patrickdillon patrickdillon merged commit d55597a into openshift:master Aug 16, 2023
26 of 27 checks passed
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 16, 2023

@bharath-b-rh: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-e2e-aws-ovn 9b40d22 link false /test okd-e2e-aws-ovn
ci/prow/okd-e2e-aws-ovn-upgrade 9b40d22 link false /test okd-e2e-aws-ovn-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@bharath-b-rh bharath-b-rh deleted the cfe-687 branch August 23, 2023 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barbacbd barbacbd barbacbd left review comments

@patrickdillon patrickdillon Awaiting requested review from patrickdillon

@rwsu rwsu Awaiting requested review from rwsu

Assignees

@patrickdillon patrickdillon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@bharath-b-rh @jianli-wei @openshift-ci-robot @patrickdillon @barbacbd @openshift-merge-robot