Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CFE-829: Remove Azure Tags TechPreview only indicators and checks #7187

Merged
merged 1 commit into from Jun 14, 2023
Merged

CFE-829: Remove Azure Tags TechPreview only indicators and checks #7187

merged 1 commit into from Jun 14, 2023

Conversation

bharath-b-rh
Copy link
Contributor

@bharath-b-rh bharath-b-rh commented May 16, 2023 •
edited

Support for user defined tags for Azure resources was TechPreview only in openshift-4.13 which will be made GA in openshift-4.14. And the changes in this PR are for removing the indications on TechPreview and the featureSet check.

@openshift-ci openshift-ci bot requested review from jhixson74 and r4f4 May 16, 2023 04:27
@bharath-b-rh bharath-b-rh changed the title CFE-829 : Remove Azure Tags TechPreview only indicators anc checks CFE-829 : Remove Azure Tags TechPreview only indicators and checks May 16, 2023
@r4f4
Copy link
Contributor

r4f4 commented May 16, 2023

/retest-required

2 similar comments
@bharath-b-rh
Copy link
Contributor Author

/retest-required

@bharath-b-rh
Copy link
Contributor Author

/retest-required

@bharath-b-rh
Copy link
Contributor Author

/cc @jhixson74 @r4f4

@r4f4
Copy link
Contributor

r4f4 commented May 18, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 18, 2023
@jhixson74
Copy link
Member

/lgtm
/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 23, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhixson74

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 23, 2023
@bharath-b-rh bharath-b-rh changed the title CFE-829 : Remove Azure Tags TechPreview only indicators and checks CFE-829: Remove Azure Tags TechPreview only indicators and checks May 24, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 24, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 24, 2023 •
edited by openshift-ci bot

@bharath-b-rh: This pull request references CFE-829 which is a valid jira issue.

In response to this:

Support for user defined tags for Azure resources was TechPreview only in openshift-4.13 which will be made GA in openshift-4.14. And the changes in this PR are for removing the indications on TechPreview and the featureSet check.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bharath-b-rh
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 25, 2023 •
edited by openshift-ci bot

@bharath-b-rh: This pull request references CFE-829 which is a valid jira issue.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jinyunma
Copy link
Contributor

jinyunma commented Jun 6, 2023

pre-merge test passed, no issue is detected, details can be found from CORS-2653.

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Jun 6, 2023
@deepsm007
Copy link
Contributor

/label jira/valid-bug

@openshift-ci openshift-ci bot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Jun 12, 2023
@neisw
Copy link

neisw commented Jun 13, 2023

/remove-label jira/valid-bug

Merge conflicts need to be resolved

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 13, 2023
@openshift-ci openshift-ci bot removed the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Jun 13, 2023
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 13, 2023
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 13, 2023
@bharath-b-rh
Copy link
Contributor Author

/cc @jhixson74 @r4f4

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 13, 2023

@bharath-b-rh: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn a5acb27 link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-azurestack a5acb27 link false /test e2e-azurestack
ci/prow/okd-e2e-aws-ovn-upgrade a5acb27 link false /test okd-e2e-aws-ovn-upgrade
ci/prow/e2e-agent-ha-dualstack a5acb27 link false /test e2e-agent-ha-dualstack

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

r4f4
r4f4 reviewed Jun 13, 2023
View reviewed changes
Copy link
Contributor

@r4f4 r4f4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 13, 2023
@bharath-b-rh
Copy link
Contributor Author

/cc @neisw @deepsm007

@openshift-ci openshift-ci bot requested review from deepsm007 and neisw June 14, 2023 06:15
@deepsm007
Copy link
Contributor

/label jira/valid-bug

@openshift-ci openshift-ci bot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Jun 14, 2023
@openshift-merge-robot openshift-merge-robot merged commit 4a48f61 into openshift:master Jun 14, 2023
23 of 27 checks passed
@bharath-b-rh bharath-b-rh deleted the cfe-829 branch June 15, 2023 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r4f4 r4f4 r4f4 left review comments

@jhixson74 jhixson74 Awaiting requested review from jhixson74

@deepsm007 deepsm007 Awaiting requested review from deepsm007

@neisw neisw Awaiting requested review from neisw

Assignees

@r4f4 r4f4

@jhixson74 jhixson74

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@bharath-b-rh @r4f4 @jhixson74 @openshift-ci-robot @jinyunma @deepsm007 @neisw @openshift-merge-robot