Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.13] OCPBUGS-13765: Support /dev/disk/by-path root device hints #7193

Merged
merged 1 commit into from Jun 2, 2023
Merged

[release-4.13] OCPBUGS-13765: Support /dev/disk/by-path root device hints #7193

merged 1 commit into from Jun 2, 2023

Conversation

zaneb
Copy link
Member

@zaneb zaneb commented May 18, 2023

In baremetal IPI, we should support /dev/disk/by-path root device hints in the install-config to match the implementation in Metal³.

@zaneb
OCPBUGS-13765: Support /dev/disk/by-path root device hints
296e329 
In baremetal IPI, we should support /dev/disk/by-path root device hints
in the install-config to match the implementation in Metal³
metal3-io/baremetal-operator#1264.

(cherry picked from commit d1dce80)
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 18, 2023

@zaneb: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

OCPBUGS-13765: Support /dev/disk/by-path root device hints

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 18, 2023
@openshift-ci-robot
Copy link
Contributor

@zaneb: This pull request references Jira Issue OCPBUGS-13765, which is invalid:

  • expected dependent Jira Issue OCPBUGS-13764 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but it is POST instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

In baremetal IPI, we should support /dev/disk/by-path root device hints in the install-config to match the implementation in Metal³.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label May 18, 2023
@zaneb
Copy link
Member Author

zaneb commented May 18, 2023

/cherry-pick release-4.12

@openshift-cherrypick-robot
Copy link

@zaneb: once the present PR merges, I will cherry-pick it on top of release-4.12 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from dtantsur and honza May 18, 2023 04:06
@zaneb zaneb changed the title OCPBUGS-13765: Support /dev/disk/by-path root device hints [release-4.13] OCPBUGS-13765: Support /dev/disk/by-path root device hints May 18, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 18, 2023

@zaneb: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

[release-4.13] OCPBUGS-13765: Support /dev/disk/by-path root device hints

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@zaneb
Copy link
Member Author

zaneb commented May 25, 2023

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label May 25, 2023
@zaneb
Copy link
Member Author

zaneb commented May 28, 2023

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label May 28, 2023
@openshift-ci-robot
Copy link
Contributor

@zaneb: This pull request references Jira Issue OCPBUGS-13765, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.13.z) matches configured target version for branch (4.13.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-13764 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
  • dependent Jira Issue OCPBUGS-13764 targets the "4.14.0" version, which is one of the valid target versions: 4.14.0
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (jhajyahy@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label May 28, 2023
@zaneb
Copy link
Member Author

zaneb commented May 29, 2023

/retest-required

@zaneb
Copy link
Member Author

zaneb commented Jun 1, 2023

/cc @dtantsur @bfournie

@openshift-ci openshift-ci bot requested a review from bfournie June 1, 2023 03:43
@dtantsur
Copy link
Member

dtantsur commented Jun 2, 2023

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 2, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtantsur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 2, 2023
@zaneb
Copy link
Member Author

zaneb commented Jun 2, 2023

/cc @honza

@zaneb
Copy link
Member Author

zaneb commented Jun 2, 2023

@pamoedom this needs cherry-pick-approved please

@pamoedom
Copy link
Contributor

pamoedom commented Jun 2, 2023

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jun 2, 2023
@honza
Copy link
Member

honza commented Jun 2, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 2, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 2, 2023 •
edited

@zaneb: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-disruptive 296e329 link false /test e2e-aws-ovn-disruptive
ci/prow/e2e-metal-ipi-sdn-swapped-hosts 296e329 link false /test e2e-metal-ipi-sdn-swapped-hosts
ci/prow/e2e-aws-ovn-workers-rhel8 296e329 link false /test e2e-aws-ovn-workers-rhel8

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD de94138 and 2 for PR HEAD 296e329 in total

@openshift-merge-robot openshift-merge-robot merged commit 90bb61f into openshift:release-4.13 Jun 2, 2023
27 of 30 checks passed
@openshift-ci-robot
Copy link
Contributor

@zaneb: Jira Issue OCPBUGS-13765: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-13765 has been moved to the MODIFIED state.

In response to this:

In baremetal IPI, we should support /dev/disk/by-path root device hints in the install-config to match the implementation in Metal³.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link

@zaneb: new pull request created: #7227

In response to this:

/cherry-pick release-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 2, 2023
Merged
@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.13.0-0.nightly-2023-06-03-031200

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtantsur dtantsur Awaiting requested review from dtantsur

@honza honza Awaiting requested review from honza

@bfournie bfournie Awaiting requested review from bfournie

Assignees

@honza honza

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@zaneb @openshift-ci-robot @openshift-cherrypick-robot @dtantsur @pamoedom @honza @openshift-merge-robot