Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AGENT-596: use agent-installer-utils for agent-tui extraction #7212

Merged
merged 2 commits into from Jun 14, 2023
Merged

AGENT-596: use agent-installer-utils for agent-tui extraction #7212

merged 2 commits into from Jun 14, 2023

Conversation

andfasano
Copy link
Contributor

Since agent-installer-utils image is now shipped within the release payload, it's then possible to start using it (instead of the temporary solution provided by agent-installer-node-agent) for extracting the agent-tui related artifacts

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 29, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 29, 2023 •
edited by openshift-ci bot

@andfasano: This pull request references AGENT-596 which is a valid jira issue.

In response to this:

Since agent-installer-utils image is now shipped within the release payload, it's then possible to start using it (instead of the temporary solution provided by agent-installer-node-agent) for extracting the agent-tui related artifacts

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from bfournie and lranjbar May 29, 2023 16:30
@andfasano
Copy link
Contributor Author

/test agent-integration-tests

@andfasano
Copy link
Contributor Author

andfasano commented May 30, 2023 •
edited

Note: the integration tests use the default release configured in the code, namely registry.ci.openshift.org/origin/release:4.13.

The currently latest available build for that is 4.13.0-0.okd-2023-05-28-030052, so it does not have yet the agent-installer-utils shipped within.

Next (4.14) green origin build should automatically fix this problem

@rwsu
Copy link
Contributor

rwsu commented Jun 1, 2023

/retest-required

@andfasano
Copy link
Contributor Author

Latest 4.14 okd release included agent-installer-utils, so bumping up the default release image

@bfournie
Copy link
Contributor

bfournie commented Jun 5, 2023

/lgtm
/retest

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 5, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 5, 2023

@andfasano: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn bec30dd link false /test okd-scos-e2e-aws-ovn
ci/prow/okd-e2e-aws-ovn bec30dd link false /test okd-e2e-aws-ovn
ci/prow/okd-e2e-aws-ovn-upgrade bec30dd link false /test okd-e2e-aws-ovn-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

rwsu
rwsu reviewed Jun 5, 2023
View reviewed changes
Copy link
Contributor

@rwsu rwsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@r4f4
Copy link
Contributor

r4f4 commented Jun 6, 2023

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: r4f4

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 6, 2023
@deepsm007
Copy link
Contributor

/label jira/valid-bug

@openshift-ci openshift-ci bot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Jun 14, 2023
@openshift-merge-robot openshift-merge-robot merged commit fa3a314 into openshift:master Jun 14, 2023
24 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwsu rwsu rwsu left review comments

@bfournie bfournie Awaiting requested review from bfournie

@lranjbar lranjbar Awaiting requested review from lranjbar

Assignees

@rwsu rwsu

@bfournie bfournie

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@andfasano @openshift-ci-robot @rwsu @bfournie @r4f4 @deepsm007 @openshift-merge-robot