bootkube: Drop cruft in MCO bootstrap #7244
Conversation
These command line arguments *should* be dead code since openshift@322d4fe landed; we just didn't drop them out of conservatism. But it turns out that hyperkube has a duplicate of this code path; it's time to clean it up. Add a cross reference to that code. To rephrase and highlight: A key thing we've done here is entirely remove the need to change openshift/installer (*and* openshift/hyperkube) when adding a new image reference.
|
Resubmit of #6432 which got auto-closed; I will look at the CI failures against latest runs. |
|
@cgwalters: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
yep, I was a big chicken. Looks good. 😄 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: r4f4 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
openshift-merge-robot
merged commit 1ea5874
into
openshift:master
These command line arguments should be dead code since 322d4fe landed; we just didn't drop them out of conservatism.
But it turns out that hyperkube has a duplicate of this code path; it's time to clean it up. Add a cross reference to that code.
To rephrase and highlight: A key thing we've done here is entirely remove the need to change openshift/installer (and openshift/hyperkube) when adding a new image reference.