Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default dataStore is returned the name instead the inventoryPath #7261

Merged
merged 1 commit into from Jun 21, 2023

Conversation

agonzalezrh
Copy link
Contributor

On version 4.13 if only one dataStore is detected, it sets the configuration to the name instead to the path

Example:

% ./openshift-install create install-config --dir vmware-cluster-install                  
? SSH Public Key 
? Platform vsphere
? vCenter portal.vc.opentlc.com
? Username sandbox-mzfsr@vc.opentlc.com
? Password [? for help] ************
INFO Connecting to vCenter portal.vc.opentlc.com  
INFO Defaulting to only available datacenter: SDDC-Datacenter 
INFO Defaulting to only available cluster: /SDDC-Datacenter/host/Cluster-1 
INFO Defaulting to only available datastore: /SDDC-Datacenter/datastore/WorkloadDatastore 
 INFO Defaulting to only available network: segment-sandbox-mzfsr 
? Virtual IP Address for API 192.168.13.201
? Virtual IP Address for Ingress 192.168.13.202
? Base Domain dynamic.opentlc.com
? Cluster Name mzfsr
? Pull Secret [? for help]
After that, I've got en error like:
FATAL failed to fetch Install Config: failed to generate asset "Install Config": invalid install config: platform.vsphere.failureDomains.topology.datastore: Invalid value: "WorkloadDatastore": full path of datastore must be provided in format /<datacenter/datastore/<datastore>

On version 4.13 if only one dataStore is detected, it sets the configuration to the name instead to the path
@jcpowermac
Copy link
Contributor

Thanks @agonzalezrh !
/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 21, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcpowermac

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 21, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 21, 2023

@agonzalezrh: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 099a0d8 into openshift:master Jun 21, 2023
22 checks passed
@jcpowermac
Copy link
Contributor

/cherry-pick release-4.13

@openshift-cherrypick-robot

@jcpowermac: new pull request created: #7343

In response to this:

/cherry-pick release-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants