Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.13] OCPBUGS-15222: terraform: aws: secret regions now support ALIAS record #7262

Merged
merged 1 commit into from Sep 7, 2023
Merged

[release-4.13] OCPBUGS-15222: terraform: aws: secret regions now support ALIAS record #7262

merged 1 commit into from Sep 7, 2023

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #7184

/assign r4f4

@r4f4
terraform: aws: secret regions now support ALIAS record
ed3cb7f 
Switching to use a CNAME instead of an ALIAS record is no longer needed
on C2S regions. Both TC2S and SC2S support ALIAS records now.
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 20, 2023
Merged
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Jira Issue OCPBUGS-9435 has been cloned as Jira Issue OCPBUGS-15222. Will retitle bug to link to clone.
/retitle [release-4.13] OCPBUGS-15222: terraform: aws: secret regions now support ALIAS record

In response to this:

This is an automated cherry-pick of #7184

/assign r4f4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot changed the title [release-4.13] OCPBUGS-9435: terraform: aws: secret regions now support ALIAS record [release-4.13] OCPBUGS-15222: terraform: aws: secret regions now support ALIAS record Jun 20, 2023
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Jun 20, 2023
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-15222, which is invalid:

  • expected dependent Jira Issue OCPBUGS-9435 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #7184

/assign r4f4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Jun 20, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 21, 2023 •
edited

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-disruptive ed3cb7f link false /test e2e-aws-ovn-disruptive
ci/prow/e2e-aws-ovn-proxy ed3cb7f link false /test e2e-aws-ovn-proxy
ci/prow/e2e-aws-ovn-workers-rhel8 ed3cb7f link false /test e2e-aws-ovn-workers-rhel8
ci/prow/e2e-aws-ovn-imdsv2 ed3cb7f link false /test e2e-aws-ovn-imdsv2
ci/prow/e2e-aws-ovn-single-node ed3cb7f link false /test e2e-aws-ovn-single-node
ci/prow/e2e-aws-ovn-shared-vpc ed3cb7f link false /test e2e-aws-ovn-shared-vpc
ci/prow/e2e-aws-ovn-fips ed3cb7f link false /test e2e-aws-ovn-fips
ci/prow/e2e-aws-ovn-upgrade ed3cb7f link false /test e2e-aws-ovn-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@r4f4
Copy link
Contributor

r4f4 commented Jun 28, 2023

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 28, 2023
@openshift-ci-robot
Copy link
Contributor

@r4f4: This pull request references Jira Issue OCPBUGS-15222, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.13.z) matches configured target version for branch (4.13.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-9435 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
  • dependent Jira Issue OCPBUGS-9435 targets the "4.14.0" version, which is one of the valid target versions: 4.14.0
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (yunjiang@redhat.com), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@r4f4
Copy link
Contributor

r4f4 commented Aug 1, 2023

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 1, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: r4f4

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 1, 2023
@r4f4
Copy link
Contributor

r4f4 commented Aug 1, 2023

/cherry-pick release-4.12

@openshift-cherrypick-robot
Copy link
Author

@r4f4: once the present PR merges, I will cherry-pick it on top of release-4.12 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@r4f4
Copy link
Contributor

r4f4 commented Aug 1, 2023

/retest-required

1 similar comment
@sadasu
Copy link
Contributor

sadasu commented Sep 6, 2023

/retest-required

@sadasu
Copy link
Contributor

sadasu commented Sep 6, 2023

/lgtm

@sadasu
Copy link
Contributor

sadasu commented Sep 6, 2023

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Sep 6, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 6, 2023
@gpei
Copy link
Contributor

gpei commented Sep 7, 2023

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Sep 7, 2023
@openshift-merge-robot openshift-merge-robot merged commit 1f2478a into openshift:release-4.13 Sep 7, 2023
21 of 30 checks passed
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Jira Issue OCPBUGS-15222: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-15222 has been moved to the MODIFIED state.

In response to this:

This is an automated cherry-pick of #7184

/assign r4f4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Sep 7, 2023
Merged
@openshift-cherrypick-robot
Copy link
Author

@r4f4: new pull request created: #7472

In response to this:

/cherry-pick release-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.13.0-0.nightly-2023-09-09-104504

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtulio mtulio Awaiting requested review from mtulio

@patrickdillon patrickdillon Awaiting requested review from patrickdillon

Assignees

@r4f4 r4f4

@sadasu sadasu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@openshift-cherrypick-robot @openshift-ci-robot @r4f4 @sadasu @gpei @openshift-merge-robot