Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-15041: Pass releaseImageMirror to assisted if mirror defined #7273

Closed

Conversation

bfournie
Copy link
Contributor

@bfournie bfournie commented Jun 22, 2023

In openshift/assisted-service#5102 a new assisted-service validation was added to check DNS for the releaseImage. This fails in a disconnected environment when the releaseImage is the source. If a mirror is defined, pass in the releaseImage set to the mirror.

Note that an assisted-service bug for the failure in a disconnected environment was created - https://issues.redhat.com/browse/MGMT-15056. If a fix for that merges we can revert this change.

In openshift/assisted-service#5102 a new
assisted-service validation was added to check DNS for the releaseImage.
This fails in a disconnected environment when the releaseImage is the
source.  If a mirror is defined, pass in the releaseImage set to the mirror.
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 22, 2023
@openshift-ci-robot
Copy link
Contributor

@bfournie: This pull request references Jira Issue OCPBUGS-15041, which is invalid:

  • expected the bug to target the "4.14.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

In openshift/assisted-service#5102 a new assisted-service validation was added to check DNS for the releaseImage. This fails in a disconnected environment when the releaseImage is the source. If a mirror is defined, pass in the releaseImage set to the mirror.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bfournie
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 22, 2023
@openshift-ci-robot
Copy link
Contributor

@bfournie: This pull request references Jira Issue OCPBUGS-15041, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @bmanzari

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from bmanzari June 22, 2023 14:06
@bfournie
Copy link
Contributor Author

/cc @andfasano

@openshift-ci openshift-ci bot requested a review from andfasano June 22, 2023 14:06
@openshift-ci-robot
Copy link
Contributor

@bfournie: This pull request references Jira Issue OCPBUGS-15041, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @bmanzari

In response to this:

In openshift/assisted-service#5102 a new assisted-service validation was added to check DNS for the releaseImage. This fails in a disconnected environment when the releaseImage is the source. If a mirror is defined, pass in the releaseImage set to the mirror.

Note that an assisted-service bug for the failure in a disconnected environment was created - https://issues.redhat.com/browse/MGMT-15056. If a fix for that merges we can revert this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bfournie
Copy link
Contributor Author

/test e2e-agent-sno-ipv6

@bfournie
Copy link
Contributor Author

/test e2e-agent-ha-dualstack

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 22, 2023

@bfournie: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 12, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bmanzari
Once this PR has been reviewed and has the lgtm label, please ask for approval from bfournie. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bfournie
Copy link
Contributor Author

bfournie commented Jul 17, 2023

/hold pending verification of fix in assisted-service openshift/assisted-service#5351

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 17, 2023
@bfournie
Copy link
Contributor Author

The change to the validation in assisted-service resolves this issue so no need for this PR.
/close

@openshift-ci openshift-ci bot closed this Jul 17, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 17, 2023

@bfournie: Closed this PR.

In response to this:

The change to the validation in assisted-service resolves this issue so no need for this PR.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bfournie bfournie deleted the release-image-set-to-mirror branch October 26, 2023 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants