New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-15041: Pass releaseImageMirror to assisted if mirror defined #7273
Conversation
In openshift/assisted-service#5102 a new assisted-service validation was added to check DNS for the releaseImage. This fails in a disconnected environment when the releaseImage is the source. If a mirror is defined, pass in the releaseImage set to the mirror.
@bfournie: This pull request references Jira Issue OCPBUGS-15041, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/jira refresh |
@bfournie: This pull request references Jira Issue OCPBUGS-15041, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cc @andfasano |
@bfournie: This pull request references Jira Issue OCPBUGS-15041, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test e2e-agent-sno-ipv6 |
/test e2e-agent-ha-dualstack |
@bfournie: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: bmanzari The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold pending verification of fix in assisted-service openshift/assisted-service#5351 |
The change to the validation in assisted-service resolves this issue so no need for this PR. |
@bfournie: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
In openshift/assisted-service#5102 a new assisted-service validation was added to check DNS for the releaseImage. This fails in a disconnected environment when the releaseImage is the source. If a mirror is defined, pass in the releaseImage set to the mirror.
Note that an assisted-service bug for the failure in a disconnected environment was created - https://issues.redhat.com/browse/MGMT-15056. If a fix for that merges we can revert this change.