Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MULTIARCH-3676: PowerVS add transit gateway destroy #7294

Merged
merged 2 commits into from Jul 28, 2023
Merged

MULTIARCH-3676: PowerVS add transit gateway destroy #7294

merged 2 commits into from Jul 28, 2023

Conversation

hamzy
Copy link
Contributor

@hamzy hamzy commented Jul 5, 2023 •
edited

This is part of the new work for supporting Power Edge Router (PER).
This updates the destroy logic to also cleanup matching PER components in the cloud.

https://issues.redhat.com/browse/MULTIARCH-3676

@hamzy hamzy changed the title Power vs add transit gateway destroy PowerVS add transit gateway destroy Jul 5, 2023
@openshift-ci openshift-ci bot requested review from bfournie and rna-afk July 5, 2023 17:50
@hamzy hamzy changed the title PowerVS add transit gateway destroy WIP: PowerVS add transit gateway destroy Jul 5, 2023
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 5, 2023
@hamzy
Copy link
Contributor Author

hamzy commented Jul 5, 2023

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 5, 2023
@hamzy hamzy changed the title WIP: PowerVS add transit gateway destroy WIP: MULTIARCH-3676: PowerVS add transit gateway destroy Jul 5, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 5, 2023 •
edited by openshift-ci bot

@hamzy: This pull request references MULTIARCH-3676 which is a valid jira issue.

In response to this:

This is part of the new work for supporting Power Edge Router (PER).
This updates the destroy logic to also cleanup matching PER components in the cloud.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 5, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 5, 2023 •
edited by openshift-ci bot

@hamzy: This pull request references MULTIARCH-3676 which is a valid jira issue.

In response to this:

This is part of the new work for supporting Power Edge Router (PER).
This updates the destroy logic to also cleanup matching PER components in the cloud.

https://issues.redhat.com/browse/MULTIARCH-3676

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hamzy
Copy link
Contributor Author

hamzy commented Jul 6, 2023

/retest-required

@hamzy hamzy force-pushed the PowerVS-Add-transit-gateway-destroy branch 5 times, most recently from d5adcd3 to 09ec73f Compare July 10, 2023 14:14
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 13, 2023
@hamzy hamzy force-pushed the PowerVS-Add-transit-gateway-destroy branch from 09ec73f to eecf014 Compare July 24, 2023 18:34
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 24, 2023
@hamzy hamzy changed the title WIP: MULTIARCH-3676: PowerVS add transit gateway destroy MULTIARCH-3676: PowerVS add transit gateway destroy Jul 24, 2023
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 24, 2023
@hamzy
Copy link
Contributor Author

hamzy commented Jul 24, 2023

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 24, 2023
@hamzy hamzy force-pushed the PowerVS-Add-transit-gateway-destroy branch from eecf014 to b4f5ef6 Compare July 24, 2023 19:07
@mjturek
Copy link
Contributor

mjturek commented Jul 24, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 24, 2023
@hamzy
Copy link
Contributor Author

hamzy commented Jul 25, 2023

/retest-required

@hamzy
Copy link
Contributor Author

hamzy commented Jul 25, 2023

/assign @r4f4

r4f4
r4f4 suggested changes Jul 25, 2023
View reviewed changes
Copy link
Contributor

@r4f4 r4f4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash the v4 -> v5 changes into one commit and separate the vendor changes into their own commit.

pkg/destroy/powervs/cloud-transit-gateways.go Outdated Show resolved Hide resolved
pkg/destroy/powervs/cloud-transit-gateways.go Outdated Show resolved Hide resolved
pkg/destroy/powervs/cloud-transit-gateways.go Outdated Show resolved Hide resolved
pkg/destroy/powervs/cloud-transit-gateways.go Outdated Show resolved Hide resolved
@hamzy
PowerVS: Add transit gateways to destroy
b50da8c 
This is part of the new work for supporting Power Edge Router (PER).
This updates the destroy logic to also cleanup matching PER components
in the cloud.
@hamzy hamzy force-pushed the PowerVS-Add-transit-gateway-destroy branch from b4f5ef6 to fad5d5b Compare July 25, 2023 19:09
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 25, 2023
@mjturek
Copy link
Contributor

mjturek commented Jul 25, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 25, 2023
@hamzy
PowerVS: Vendoring changes
6f709ad 
Vendoring bump networking-go-sdk to v0.42.2
Include networking-go-sdk/transitgatewayapisv1
@hamzy hamzy force-pushed the PowerVS-Add-transit-gateway-destroy branch from fad5d5b to 6f709ad Compare July 25, 2023 20:37
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 25, 2023
@mjturek
Copy link
Contributor

mjturek commented Jul 25, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 25, 2023
@hamzy
Copy link
Contributor Author

hamzy commented Jul 26, 2023

/retest-required

r4f4
r4f4 reviewed Jul 26, 2023
View reviewed changes
Copy link
Contributor

@r4f4 r4f4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 26, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: r4f4

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 26, 2023
@hamzy
Copy link
Contributor Author

hamzy commented Jul 26, 2023

/retest-required

1 similar comment
@hamzy
Copy link
Contributor Author

hamzy commented Jul 26, 2023

/retest-required

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD e8de08f and 2 for PR HEAD 6f709ad in total

@hamzy
Copy link
Contributor Author

hamzy commented Jul 27, 2023

/retest-required

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 9dfc08b and 1 for PR HEAD 6f709ad in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 27, 2023 •
edited

@hamzy: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn 6f709ad link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hamzy
Copy link
Contributor Author

hamzy commented Jul 27, 2023

/retest-required

@openshift-merge-robot openshift-merge-robot merged commit 2e218a8 into openshift:master Jul 28, 2023
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r4f4 r4f4 r4f4 requested changes

@AshwinHIBM AshwinHIBM AshwinHIBM left review comments

@bfournie bfournie Awaiting requested review from bfournie

@rna-afk rna-afk Awaiting requested review from rna-afk

Assignees

@r4f4 r4f4

@mjturek mjturek

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@hamzy @openshift-ci-robot @mjturek @r4f4 @AshwinHIBM @openshift-merge-robot