Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hack: pin the release image in build flags #732

Closed
wants to merge 1 commit into from

Commits on Nov 28, 2018

  1. hack: pin the release image in build flags

    But still leave an override env var so that it can be overridden. Use the following env var to pin the image while building the binary:
    ```
    $ # export the release-image variable
    $ export OPENSHIFT_INSTALL_RELEASE_IMAGE=registry.redhat.io/openshift/origin-release:v4.0"
    $ # build the openshift-install binary
    $ ./hack/build.sh
    $ # distribute the binary to customers and run with pinned image being picked up
    $ ./bin/openshift-install create cluster...
    ```
    The only way to override it would be to use an env var OPENSHIFT_INSTALL_RELEASE_IMAGE_OVERRIDE while running the openshift-install binary.
    Rajat Chopra committed Nov 28, 2018
    Configuration menu
    Copy the full SHA
    e890b7b View commit details
    Browse the repository at this point in the history