OCPBUGS-16380: Add /etc/containers volume on create-cluster-and-infraenv #7332
Conversation
As done in assisted-service.service.template, added '-v /etc/containers:/etc/containers' when HaveMirrorConfig flag is true rtp create-cluster-and-infraenv service. This should allow propagation of registries.conf, which is requried on disconnected environments.
|
/cc @bfournie |
The create-cluster-and-infraenv service fails on disconnected using 4.14.0-ec.3 release[*] Hence, overridden the service and added '-v /etc/containers:/etc/containers' for propagating the registries.conf file. Notes: * A proper [fix](openshift/installer#7332) pushed to the installer for later. * It won't affect connect environments as the registries.conf file doesn't have mirrors config by default. [*] create-cluster-and-infraenv[2784]: level=fatal msg="Failed to register cluster with assisted-service: command 'oc adm release info -o template --template '{{.metadata.version}}' --insecure=true quay.io/openshift-release-dev/ocp-release@sha256:3c050cb52fdd3e65c518d4999d238ec026ef724503f275377fee6bf0d33093ab --registry-config=/tmp/registry-config1560177852' exited with non-zero exit code 1: \nerror: unable to read image quay.io/openshift-release-dev/ocp-release@sha256:3c050cb52fdd3e65c518d4999d238ec026ef724503f275377fee6bf0d33093ab: Get \"http://quay.io/v2/\": net/http: request canceled while waiting for connection (Client.Timeout exceeded while awaiting headers)\n"
The create-cluster-and-infraenv service fails on disconnected using 4.14.0-ec.3 release[*] Hence, overridden the service and added '-v /etc/containers:/etc/containers' for propagating the registries.conf file. Notes: * A proper [fix](openshift/installer#7332) pushed to the installer for later. * It won't affect connect environments as the registries.conf file doesn't have mirrors config by default. [*] create-cluster-and-infraenv[2784]: level=fatal msg="Failed to register cluster with assisted-service: command 'oc adm release info -o template --template '{{.metadata.version}}' --insecure=true quay.io/openshift-release-dev/ocp-release@sha256:3c050cb52fdd3e65c518d4999d238ec026ef724503f275377fee6bf0d33093ab --registry-config=/tmp/registry-config1560177852' exited with non-zero exit code 1: \nerror: unable to read image quay.io/openshift-release-dev/ocp-release@sha256:3c050cb52fdd3e65c518d4999d238ec026ef724503f275377fee6bf0d33093ab: Get \"http://quay.io/v2/\": net/http: request canceled while waiting for connection (Client.Timeout exceeded while awaiting headers)\n"
|
/retest-required |
1 similar comment
|
/retest-required |
|
Is the same change needed for apply-host-config.service which also uses agent-installer-client? |
Seems it's unnecessary there as we don't pass the OPENSHIFT_INSTALL_RELEASE_IMAGE_MIRROR env var. |
|
The change looks good but is it possible to create a bug to describe what this is fixing? We haven't seen this omission causing a problem with the general agent installer flow (yet). Was the issue specific to the Openshift appliance? |
I think the issue is specifically for when passing the OPENSHIFT_INSTALL_RELEASE_IMAGE_MIRROR var on disconnected env. So I guess this specific use-case isn't tested on dev-scripts. But sure, I can open a ticket for it if you think it makes sense. |
Opened a ticket: https://issues.redhat.com/browse/OCPBUGS-16380 |
danielerez
changed the title
openshift-ci-robot
added
jira/severity-moderate
|
@danielerez: This pull request references Jira Issue OCPBUGS-16380, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
jira/invalid-bug
|
/jira refresh |
openshift-ci-robot
added
jira/valid-bug
|
@bfournie: This pull request references Jira Issue OCPBUGS-16380, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bfournie The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/retest-required |
|
/retest-required |
|
/test okd-scos-images |
|
@danielerez: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/test e2e-agent-compact-ipv4 |
openshift-merge-robot
merged commit 26a0d5c
into
openshift:master
|
@danielerez: Jira Issue OCPBUGS-16380: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-16380 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Includes the following fixes:
* Static and DHCP networking should work
* Messages should be displayed to console (with agetty)
* When 'UserCorePass' isn't specified, the installer sets
the core pass on load-config-iso to 'auth/kubeadmin-password'.
The following changes were made to support the new ignition:
* Extracted 'podman run' script of registry the service
* Required for supporting static networking
(as values are loaded from config image).
* Used REQUIRED_MASTER_NODES/REQUIRED_WORKER_NODES env vars
in update-hosts script.
* Removed create-cluster-and-infraenv service
(as already added in: openshift/installer#7332)
Includes the following fixes:
* Static and DHCP networking should work
* Messages should be displayed to console (with agetty)
* When 'UserCorePass' isn't specified, the installer sets
the core pass on load-config-iso to 'auth/kubeadmin-password'.
The following changes were made to support the new ignition:
* Extracted 'podman run' script of registry the service
* Required for supporting static networking
(as values are loaded from config image).
* Used REQUIRED_MASTER_NODES/REQUIRED_WORKER_NODES env vars
in update-hosts script.
* Removed create-cluster-and-infraenv service
(as already added in: openshift/installer#7332)
As done in assisted-service.service.template, added '-v /etc/containers:/etc/containers' when HaveMirrorConfig flag is true to the create-cluster-and-infraenv service. This should allow propagation of registries.conf, which is required on disconnected environments when using OPENSHIFT_INSTALL_RELEASE_IMAGE_MIRROR.