Fix the deployment on OpenStack for worker pools with no replicas. #7356
Conversation
Commit a1ea1c8 changed how the machinesets get generated. We no longer generate machineset when the number of replicas is 0, meaning we need to provide a default value for `openstack_worker_server_group_names` so that terraform does not blow up.
|
/retest-required The CI errors look unrelated /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: EmilienM The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/override ci/prow/unit |
|
@r4f4: Overrode contexts on behalf of r4f4: ci/prow/unit In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@mandre: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/hold Revision ff13ec5 was retested 3 times: holding |
openshift-ci
bot
added
the
do-not-merge/hold
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
Can we please have a test for the zero-workers case? |
openshift-merge-robot
merged commit a8fe4d0
into
openshift:master
I'm adding the |
Commit a1ea1c8 changed how the
machinesets get generated. We no longer generate machineset when the
number of replicas is 0, meaning we need to provide a default value for
openstack_worker_server_group_namesso that terraform does not blowup.
Also document the
rootVolume.typeconfig as deprecated. We now need to userootVolume.types.