OCPBUGS-16692: OpenStack: fix crash with empty platform in machinepool #7363
Conversation
openshift-ci-robot
added
jira/severity-important
|
@mandre: This pull request references Jira Issue OCPBUGS-16692, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
I expect openstack-manifests to fail, due to the bug I'm fixing here. Once I proved it failed, I'll remove the revert. |
|
/jira refresh |
openshift-ci-robot
added
jira/valid-bug
|
@mandre: This pull request references Jira Issue OCPBUGS-16692, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (itbrown@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
mandre
force-pushed
the
openstack-platform-none
branch
from
f7f7c29
to
82a9e84
Compare
|
The test failed as expected without my changes: https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_installer/7363/pull-ci-openshift-installer-master-openstack-manifests/1683675624608108544 |
|
/lgtm |
|
/retest |
|
/assign pawanpinjarkar |
Passing an empty platform in machinepools caused the installer to exit with an ugly stack trace. This commit fixes the convertOpenStack() function to account for cases where the platform is not defined in the machine pools.
EmilienM
force-pushed
the
openstack-platform-none
branch
from
82a9e84
to
7e1de0d
Compare
|
@mandre I added unit tests which will help as well with testing. The openstack-manifest addition is nice as well btw. |
|
/lgtm |
|
/retest-required |
|
/retest-required |
|
/retest |
|
The openstack jobs were all successful before the rebase, which didn't change installer code. |
|
/retest |
|
The 2 errors (openstack-ovn and parallel) are not related to this PR and can safely be ignored, I had a look. |
|
/approve |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dulek, EmilienM, r4f4 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@mandre: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest-required |
openshift-merge-robot
merged commit 66cc2e5
into
openshift:master
|
@mandre: Jira Issue OCPBUGS-16692: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-16692 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Passing an empty platform in machinepools caused the installer to exit with an ugly stack trace. This commit fixes the convertOpenStack() function to account for cases where the platform is not defined in the machine pools.