OCPBUGS-17227: gcp: fix validation of custom instance types

[r4f4]

Users can create their own instance types in GCloud. Those types are not returned when listing the machine types for a given project/region. This would cause those installs with custom types to fail with the error:

Internal error: failed to fetch instance type, this error usually occurs if the region or the instance type is not found

after the validations introduced by
#7317 and #7096.

To fix that, let's fallback to the previous way of fetching the specific machine type whenever the aggregated list returns 0 elements.

[openshift-ci-robot]

@r4f4: This pull request references Jira Issue OCPBUGS-17227, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.14.0) matches configured target version for branch (4.14.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @gpei

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Users can create their own instance types in GCloud. Those types are not returned when listing the machine types for a given project/region. This would cause those installs with custom types to fail with the error:

Internal error: failed to fetch instance type, this error usually occurs if the region or the instance type is not found

after the validations introduced by
#7317 and #7096.

To fix that, let's fallback to the previous way of fetching the specific machine type whenever the aggregated list returns 0 elements.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jianli-wei]

/jira refresh

[openshift-ci-robot]

@jianli-wei: This pull request references Jira Issue OCPBUGS-17227, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.14.0) matches configured target version for branch (4.14.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @jianli-wei

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jianli-wei]

/label qe-approved

[barbacbd]

LGTM

We may want to change the search to loop through all of the zones to make sure that the instances are found if they exist in any zone other than the first found.

[barbacbd]

/lgtm

[r4f4]

LGTM

We may want to change the search to loop through all of the zones to make sure that the instances are found if they exist in any zone other than the first found.

This is what was done before the zone validation was introduced. See ad63edf#diff-df0d06427cd5be6b8b56f21664d1f138086071766cb01af9d0ce7b8437396cf7L124-R162

[rna-afk]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jianli-wei, rna-afk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/asset/installconfig/gcp/OWNERS [rna-afk]
• pkg/asset/machines/gcp/OWNERS [rna-afk]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD e20821e and 2 for PR HEAD 087ab4b in total

[openshift-ci]

@r4f4: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-gcp-ovn-shared-vpc	087ab4b	link	false	/test e2e-gcp-ovn-shared-vpc

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[r4f4]

/retest-required

[openshift-ci-robot]

@r4f4: Jira Issue OCPBUGS-17227: All pull requests linked via external trackers have merged:

• openshift/installer#7388

Jira Issue OCPBUGS-17227 has been moved to the MODIFIED state.

In response to this:

Users can create their own instance types in GCloud. Those types are not returned when listing the machine types for a given project/region. This would cause those installs with custom types to fail with the error:

Internal error: failed to fetch instance type, this error usually occurs if the region or the instance type is not found

after the validations introduced by
#7317 and #7096.

To fix that, let's fallback to the previous way of fetching the specific machine type whenever the aggregated list returns 0 elements.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.