Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openstack: Test zero replicas in worker machine-pool #7400

Merged
merged 1 commit into from Aug 7, 2023
Merged

openstack: Test zero replicas in worker machine-pool #7400

merged 1 commit into from Aug 7, 2023

Conversation

pierreprinetti
Copy link
Member

@pierreprinetti pierreprinetti commented Aug 7, 2023 •
edited

Assert that:

  • setting zero workers does not crash the Installer
  • there always is at least one MachineSet

A follow-up to #7380

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 7, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 7, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@pierreprinetti
Copy link
Member Author

/test openstack-manifests

@pierreprinetti
openstack: Test zero replicas in worker machine-pool
ed2a27d 
Assert that:
* setting zero workers does not crash the Installer
* there always is at least one MachineSet
@pierreprinetti pierreprinetti changed the title openstack: Test no worker machine-pool openstack: Test zero replicas in worker machine-pool Aug 7, 2023
@pierreprinetti pierreprinetti marked this pull request as ready for review August 7, 2023 12:11
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 7, 2023
@pierreprinetti
Copy link
Member Author

/cc emilienm mandre

@openshift-ci openshift-ci bot requested review from EmilienM, mandre and gryf August 7, 2023 12:13
@EmilienM
Copy link
Member

EmilienM commented Aug 7, 2023

/lgtm
/approve

Thanks @pierreprinetti !

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 7, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: EmilienM

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 7, 2023
@openshift-merge-robot openshift-merge-robot merged commit 0367c39 into openshift:master Aug 7, 2023
23 of 29 checks passed
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 7, 2023

@pierreprinetti: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-openstack-kuryr ed2a27d link false /test e2e-openstack-kuryr
ci/prow/e2e-openstack-nfv-intel ed2a27d link false /test e2e-openstack-nfv-intel
ci/prow/okd-e2e-aws-ovn ed2a27d link false /test okd-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@pierreprinetti pierreprinetti deleted the osp_zero_workers branch August 7, 2023 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EmilienM EmilienM Awaiting requested review from EmilienM

@mandre mandre Awaiting requested review from mandre

@gryf gryf Awaiting requested review from gryf

Assignees

@EmilienM EmilienM

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pierreprinetti @EmilienM @openshift-merge-robot