Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-13408: Log message and add integration test #7408

Merged
merged 2 commits into from Aug 10, 2023
Merged

OCPBUGS-13408: Log message and add integration test #7408

merged 2 commits into from Aug 10, 2023

Conversation

pawanpinjarkar
Copy link
Contributor

Log message and add integration test for openshift-install agent create agent-config-template command

Signed-Off by:
@marcbrown2024
@pawanpinjarkar

marcbrown2024 and others added 2 commits August 3, 2023 14:38
@marcbrown2024
OCPBUGS-13408 solved
e93cadd
@pawanpinjarkar
Agent: Integration test for agent config template
9d13846 
Signed-off-by: Pawan Pinjarkar <ppinjark@redhat.com>
@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Aug 8, 2023
@openshift-ci-robot
Copy link
Contributor

@pawanpinjarkar: This pull request references Jira Issue OCPBUGS-13408, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @mhanss

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Log message and add integration test for openshift-install agent create agent-config-template command

Signed-Off by:
@marcbrown2024
@pawanpinjarkar

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from mhanss August 8, 2023 20:19
@pawanpinjarkar
Copy link
Contributor Author

/cc @rwsu @andfasano @bfournie

@pawanpinjarkar pawanpinjarkar mentioned this pull request Aug 8, 2023
Merged
@openshift-ci openshift-ci bot requested a review from dhellmann August 8, 2023 20:21
@pawanpinjarkar pawanpinjarkar mentioned this pull request Aug 8, 2023
Closed
rwsu
rwsu reviewed Aug 8, 2023
View reviewed changes
Copy link
Contributor

@rwsu rwsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 8, 2023
@andfasano
Copy link
Contributor

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 9, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andfasano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 9, 2023
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 610fe13 and 2 for PR HEAD 9d13846 in total

@pawanpinjarkar
Copy link
Contributor Author

/retest-required

1 similar comment
@pawanpinjarkar
Copy link
Contributor Author

/retest-required

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 10, 2023 •
edited

@pawanpinjarkar: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-agent-compact-ipv4-appliance 9d13846 link false /test e2e-agent-compact-ipv4-appliance
ci/prow/e2e-agent-ha-dualstack 9d13846 link false /test e2e-agent-ha-dualstack
ci/prow/e2e-agent-sno-ipv6 9d13846 link false /test e2e-agent-sno-ipv6
ci/prow/e2e-agent-sno-ipv4-pxe 9d13846 link false /test e2e-agent-sno-ipv4-pxe
ci/prow/okd-scos-e2e-aws-ovn 9d13846 link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 0be5579 and 1 for PR HEAD 9d13846 in total

@openshift-merge-robot openshift-merge-robot merged commit 69e6e6f into openshift:master Aug 10, 2023
25 of 30 checks passed
@openshift-ci-robot
Copy link
Contributor

@pawanpinjarkar: Jira Issue OCPBUGS-13408: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-13408 has been moved to the MODIFIED state.

In response to this:

Log message and add integration test for openshift-install agent create agent-config-template command

Signed-Off by:
@marcbrown2024
@pawanpinjarkar

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 11, 2023

/test remaining-required

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwsu rwsu rwsu left review comments

@mhanss mhanss Awaiting requested review from mhanss

@andfasano andfasano Awaiting requested review from andfasano

@bfournie bfournie Awaiting requested review from bfournie

@dhellmann dhellmann Awaiting requested review from dhellmann

Assignees

@rwsu rwsu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@pawanpinjarkar @openshift-ci-robot @andfasano @rwsu @openshift-merge-robot @marcbrown2024