Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-17073: Revert "Merge pull request #7205 from rna-afk/azure_managed_by_tag" #7412

Merged
merged 2 commits into from Aug 24, 2023
Merged

OCPBUGS-17073: Revert "Merge pull request #7205 from rna-afk/azure_managed_by_tag" #7412

merged 2 commits into from Aug 24, 2023

Conversation

rna-afk
Copy link
Contributor

@rna-afk rna-afk commented Aug 9, 2023

This reverts commit 87fbf26, reversing changes made to 26a0d5c.

@rna-afk
Revert "Merge pull request openshift#7205 from rna-afk/azure_managed_…
f828b08 
…by_tag"

This reverts commit 87fbf26, reversing
changes made to 26a0d5c.
r4f4
r4f4 reviewed Aug 9, 2023
View reviewed changes
Copy link
Contributor

@r4f4 r4f4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 9, 2023
@openshift-ci openshift-ci bot requested review from jhixson74 and mtulio August 9, 2023 16:38
@r4f4
Copy link
Contributor

r4f4 commented Aug 9, 2023

/lgtm cancel
We need tf-azure provider >= 3.43.0 for the confidential VM feature

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 9, 2023
r4f4
r4f4 reviewed Aug 10, 2023
View reviewed changes
Copy link
Contributor

@r4f4 r4f4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The terraform chagnes need to be vendored in.

@r4f4
Copy link
Contributor

r4f4 commented Aug 10, 2023

/refresh

@rna-afk
Copy link
Contributor Author

rna-afk commented Aug 14, 2023

/retest

@patrickdillon
Copy link
Contributor

/approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 14, 2023
@patrickdillon
Copy link
Contributor

/lgtm

@patrickdillon patrickdillon changed the title Revert "Merge pull request #7205 from rna-afk/azure_managed_by_tag" OCPBUGS-17073: Revert "Merge pull request #7205 from rna-afk/azure_managed_by_tag" Aug 15, 2023
@patrickdillon
Copy link
Contributor

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 15, 2023
@openshift-ci-robot
Copy link
Contributor

@patrickdillon: This pull request references Jira Issue OCPBUGS-17073, which is invalid:

  • expected the bug to target the "4.14.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

@rna-afk: This pull request references Jira Issue OCPBUGS-17073, which is invalid:

  • expected the bug to target the "4.14.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

This reverts commit 87fbf26, reversing changes made to 26a0d5c.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 15, 2023
@rna-afk
Copy link
Contributor Author

rna-afk commented Aug 15, 2023

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 15, 2023
@openshift-ci-robot
Copy link
Contributor

@rna-afk: This pull request references Jira Issue OCPBUGS-17073, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @MayXuQQ

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from MayXuQQ August 15, 2023 21:22
@MayXuQQ
Copy link
Contributor

MayXuQQ commented Aug 16, 2023

MAG cluster install succeed with pre-merge build

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 16, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MayXuQQ, patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rna-afk
Copy link
Contributor Author

rna-afk commented Aug 22, 2023

/retest

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD e20821e and 2 for PR HEAD a34b535 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 02357cc and 1 for PR HEAD a34b535 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 87f73b5 and 0 for PR HEAD a34b535 in total

@r4f4
Copy link
Contributor

r4f4 commented Aug 23, 2023

/test tf-fmt

@openshift-ci-robot
Copy link
Contributor

/hold

Revision a34b535 was retested 3 times: holding

@openshift-ci openshift-ci bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed lgtm Indicates that a PR is ready to be merged. labels Aug 23, 2023
@r4f4
Copy link
Contributor

r4f4 commented Aug 23, 2023

@rna-afk do you plan on squashing d957492 into a34b535?

@rna-afk
terraform: set azurerm version to v3.43.0
fa32bf0 
Setting to v3.43.0 to support confidential VMs.
@rna-afk
Copy link
Contributor Author

rna-afk commented Aug 23, 2023

@r4f4 squashed

@r4f4
Copy link
Contributor

r4f4 commented Aug 23, 2023

/hold cancel
/lgtm

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Aug 23, 2023
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD af5e9d1 and 2 for PR HEAD fa32bf0 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 24, 2023

@rna-afk: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-ovn-xpn 85de538 link false /test e2e-gcp-ovn-xpn
ci/prow/e2e-gcp-ovn 85de538 link true /test e2e-gcp-ovn
ci/prow/e2e-gcp-secureboot 85de538 link false /test e2e-gcp-secureboot
ci/prow/e2e-gcp-ovn-shared-vpc 85de538 link false /test e2e-gcp-ovn-shared-vpc
ci/prow/e2e-azurestack fa32bf0 link false /test e2e-azurestack

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit d7f39ed into openshift:master Aug 24, 2023
25 of 26 checks passed
@openshift-ci-robot
Copy link
Contributor

@rna-afk: Jira Issue OCPBUGS-17073: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-17073 has been moved to the MODIFIED state.

In response to this:

This reverts commit 87fbf26, reversing changes made to 26a0d5c.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

patrickdillon pushed a commit to patrickdillon/installer that referenced this pull request Oct 24, 2023
@openshift-merge-robot
Merge pull request openshift#7412 from rna-afk/revert_azure_managed_by
e930015 
OCPBUGS-17073: Revert "Merge pull request openshift#7205 from rna-afk/azure_managed_by_tag"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r4f4 r4f4 r4f4 left review comments

@MayXuQQ MayXuQQ MayXuQQ approved these changes

@jhixson74 jhixson74 Awaiting requested review from jhixson74

@mtulio mtulio Awaiting requested review from mtulio

Assignees

@r4f4 r4f4

@patrickdillon patrickdillon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@rna-afk @r4f4 @patrickdillon @openshift-ci-robot @MayXuQQ @openshift-merge-robot