Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused method #7438

Merged
merged 1 commit into from Oct 12, 2023
Merged

Remove unused method #7438

merged 1 commit into from Oct 12, 2023

Conversation

zaneb
Copy link
Member

@zaneb zaneb commented Aug 21, 2023

This is not a WritableAsset so it doesn't need a Files() method.

@bfournie
Copy link
Contributor

/approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 21, 2023
@zaneb
Copy link
Member Author

zaneb commented Aug 25, 2023

/retest-required

pawanpinjarkar
pawanpinjarkar approved these changes Sep 5, 2023
View reviewed changes
Copy link
Contributor

@pawanpinjarkar pawanpinjarkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 5, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 5, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bfournie, pawanpinjarkar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 10, 2023
@zaneb
Remove unused method
ab8b08f 
This is not a WritableAsset so it doesn't need a Files() method.
@zaneb zaneb force-pushed the agent-artifacts-not-writable branch from 36541ac to ab8b08f Compare October 1, 2023 23:49
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 1, 2023
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 1, 2023
@sadasu
Copy link
Contributor

sadasu commented Oct 4, 2023

/lgtm

@sadasu
Copy link
Contributor

sadasu commented Oct 4, 2023

/retest-required

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 4, 2023
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 732271d and 2 for PR HEAD ab8b08f in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 3a738d8 and 1 for PR HEAD ab8b08f in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 3c3f41c and 0 for PR HEAD ab8b08f in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 6, 2023 •
edited

@zaneb: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-e2e-agent-compact-ipv4 ab8b08f link false /test okd-e2e-agent-compact-ipv4
ci/prow/okd-scos-e2e-agent-sno-ipv6 ab8b08f link false /test okd-scos-e2e-agent-sno-ipv6
ci/prow/e2e-aws-custom-security-groups ab8b08f link false /test e2e-aws-custom-security-groups
ci/prow/e2e-agent-compact-ipv4-appliance ab8b08f link false /test e2e-agent-compact-ipv4-appliance
ci/prow/e2e-agent-sno-ipv6 ab8b08f link false /test e2e-agent-sno-ipv6
ci/prow/okd-e2e-agent-sno-ipv6 ab8b08f link false /test okd-e2e-agent-sno-ipv6
ci/prow/e2e-agent-sno-ipv4-pxe ab8b08f link false /test e2e-agent-sno-ipv4-pxe
ci/prow/okd-scos-e2e-agent-compact-ipv4 ab8b08f link false /test okd-scos-e2e-agent-compact-ipv4
ci/prow/e2e-agent-compact-ipv4-none-platform ab8b08f link false /test e2e-agent-compact-ipv4-none-platform
ci/prow/e2e-agent-ha-dualstack ab8b08f link false /test e2e-agent-ha-dualstack

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link
Contributor

/hold

Revision ab8b08f was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 6, 2023
@zaneb
Copy link
Member Author

zaneb commented Oct 10, 2023

/test okd-images
/test okd-scos-images

@bfournie
Copy link
Contributor

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 11, 2023
@openshift-ci openshift-ci bot merged commit 8d55325 into openshift:master Oct 12, 2023
23 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pawanpinjarkar pawanpinjarkar pawanpinjarkar approved these changes

@dhellmann dhellmann Awaiting requested review from dhellmann

@lranjbar lranjbar Awaiting requested review from lranjbar

Assignees

@sadasu sadasu

@pawanpinjarkar pawanpinjarkar

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@zaneb @bfournie @sadasu @openshift-ci-robot @pawanpinjarkar @openshift-merge-robot